[INFO] fetching crate rs-smtp 1.0.1... [INFO] checking rs-smtp-1.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rs-smtp 1.0.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate rs-smtp 1.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rs-smtp 1.0.1 [INFO] finished tweaking crates.io crate rs-smtp 1.0.1 [INFO] tweaked toml for crates.io crate rs-smtp 1.0.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 88 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding ring v0.16.20 (latest: v0.17.8) [INFO] [stderr] Adding rustls v0.20.9 (latest: v0.23.12) [INFO] [stderr] Adding spin v0.5.2 (latest: v0.9.8) [INFO] [stderr] Adding tokio-rustls v0.23.4 (latest: v0.26.0) [INFO] [stderr] Adding untrusted v0.7.1 (latest: v0.9.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 535b4c03de4dfeb6963f4d3e71c9375bae5f86770061d9bcc2e92b4100091bf7 [INFO] running `Command { std: "docker" "start" "-a" "535b4c03de4dfeb6963f4d3e71c9375bae5f86770061d9bcc2e92b4100091bf7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "535b4c03de4dfeb6963f4d3e71c9375bae5f86770061d9bcc2e92b4100091bf7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "535b4c03de4dfeb6963f4d3e71c9375bae5f86770061d9bcc2e92b4100091bf7", kill_on_drop: false }` [INFO] [stdout] 535b4c03de4dfeb6963f4d3e71c9375bae5f86770061d9bcc2e92b4100091bf7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9ae08b5c3b4da185e594823782db925b46328c8166b5b2fb6649eea70ca242fc [INFO] running `Command { std: "docker" "start" "-a" "9ae08b5c3b4da185e594823782db925b46328c8166b5b2fb6649eea70ca242fc", kill_on_drop: false }` [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling rustls v0.20.9 [INFO] [stderr] Checking ring v0.16.20 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking webpki v0.22.4 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-rustls v0.23.4 [INFO] [stderr] Checking rs-smtp v1.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `future::Future` [INFO] [stdout] --> src/data.rs:1:21 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{pin::Pin, future::Future, task::Poll, io::{ErrorKind, Error}}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `future::Future` [INFO] [stdout] --> src/data.rs:1:21 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{pin::Pin, future::Future, task::Poll, io::{ErrorKind, Error}}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/data.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | use tokio::io::{self, AsyncRead, AsyncBufReadExt, AsyncBufRead, BufReader}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/data.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | use tokio::io::{self, AsyncRead, AsyncBufReadExt, AsyncBufRead, BufReader}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `enhanced_code` is never read [INFO] [stdout] --> src/data.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct SMTPError { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 8 | code: u16, [INFO] [stdout] 9 | enhanced_code: EnhancedCode, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `err_data_too_large`, `err_auth_required`, `err_auth_unsupported`, `error`, and `is_temporary` are never used [INFO] [stdout] --> src/data.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 34 | impl SMTPError { [INFO] [stdout] | -------------- associated items in this implementation [INFO] [stdout] 35 | pub fn err_data_too_large() -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 43 | pub fn err_auth_required() -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 51 | pub fn err_auth_unsupported() -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 59 | pub fn error(&self) -> String { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 63 | fn is_temporary(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `ERR_TOO_LONG_LINE` is never used [INFO] [stdout] --> src/lengthlimit_reader.rs:4:7 [INFO] [stdout] | [INFO] [stdout] 4 | const ERR_TOO_LONG_LINE: &str = "smtp: too long a line in input stream"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LineLimitReader` is never constructed [INFO] [stdout] --> src/lengthlimit_reader.rs:6:12 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct LineLimitReader { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `read` are never used [INFO] [stdout] --> src/lengthlimit_reader.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 13 | impl LineLimitReader { [INFO] [stdout] | --------------------------------------------- associated items in this implementation [INFO] [stdout] 14 | pub fn new(r: R, line_limit: usize) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 22 | async fn read(&mut self, b: &mut [u8]) -> Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:183:21 [INFO] [stdout] | [INFO] [stdout] 107 | let bytes = match futures::ready!(Pin::new(&mut this.r).poll_fill_buf(cx)) { [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | Err(e) => return std::task::Poll::Ready(Err(e)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | Poll::Ready(Ok(())) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:23:28 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(unsafe_stream: TcpStream) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Self { [INFO] [stdout] 23 | unsafe_stream: Some(unsafe_stream), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:24:26 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(unsafe_stream: TcpStream) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | safe_stream: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rs-smtp` (lib test) due to 4 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `enhanced_code` is never read [INFO] [stdout] --> src/data.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct SMTPError { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 8 | code: u16, [INFO] [stdout] 9 | enhanced_code: EnhancedCode, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `err_data_too_large`, `err_auth_required`, `err_auth_unsupported`, `error`, and `is_temporary` are never used [INFO] [stdout] --> src/data.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 34 | impl SMTPError { [INFO] [stdout] | -------------- associated items in this implementation [INFO] [stdout] 35 | pub fn err_data_too_large() -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 43 | pub fn err_auth_required() -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 51 | pub fn err_auth_unsupported() -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 59 | pub fn error(&self) -> String { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 63 | fn is_temporary(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `ERR_TOO_LONG_LINE` is never used [INFO] [stdout] --> src/lengthlimit_reader.rs:4:7 [INFO] [stdout] | [INFO] [stdout] 4 | const ERR_TOO_LONG_LINE: &str = "smtp: too long a line in input stream"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LineLimitReader` is never constructed [INFO] [stdout] --> src/lengthlimit_reader.rs:6:12 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct LineLimitReader { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `read` are never used [INFO] [stdout] --> src/lengthlimit_reader.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 13 | impl LineLimitReader { [INFO] [stdout] | --------------------------------------------- associated items in this implementation [INFO] [stdout] 14 | pub fn new(r: R, line_limit: usize) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 22 | async fn read(&mut self, b: &mut [u8]) -> Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:183:21 [INFO] [stdout] | [INFO] [stdout] 107 | let bytes = match futures::ready!(Pin::new(&mut this.r).poll_fill_buf(cx)) { [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | Err(e) => return std::task::Poll::Ready(Err(e)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | Poll::Ready(Ok(())) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:23:28 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(unsafe_stream: TcpStream) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Self { [INFO] [stdout] 23 | unsafe_stream: Some(unsafe_stream), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:24:26 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(unsafe_stream: TcpStream) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | safe_stream: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rs-smtp` (lib) due to 4 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9ae08b5c3b4da185e594823782db925b46328c8166b5b2fb6649eea70ca242fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9ae08b5c3b4da185e594823782db925b46328c8166b5b2fb6649eea70ca242fc", kill_on_drop: false }` [INFO] [stdout] 9ae08b5c3b4da185e594823782db925b46328c8166b5b2fb6649eea70ca242fc