[INFO] fetching crate rs-simple-logging 0.3.0... [INFO] checking rs-simple-logging-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rs-simple-logging 0.3.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate rs-simple-logging 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rs-simple-logging 0.3.0 [INFO] finished tweaking crates.io crate rs-simple-logging 0.3.0 [INFO] tweaked toml for crates.io crate rs-simple-logging 0.3.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 888f139c564afc90c7eb788d95112d85ff8ef8c6586f50bf497b4ce6e8e16448 [INFO] running `Command { std: "docker" "start" "-a" "888f139c564afc90c7eb788d95112d85ff8ef8c6586f50bf497b4ce6e8e16448", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "888f139c564afc90c7eb788d95112d85ff8ef8c6586f50bf497b4ce6e8e16448", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "888f139c564afc90c7eb788d95112d85ff8ef8c6586f50bf497b4ce6e8e16448", kill_on_drop: false }` [INFO] [stdout] 888f139c564afc90c7eb788d95112d85ff8ef8c6586f50bf497b4ce6e8e16448 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3eb9ff5b5d36252ec8fc47523d06e78f4847ec64e2e927e4e1fab9ad6d75f77d [INFO] running `Command { std: "docker" "start" "-a" "3eb9ff5b5d36252ec8fc47523d06e78f4847ec64e2e927e4e1fab9ad6d75f77d", kill_on_drop: false }` [INFO] [stderr] Checking rs-simple-logging v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `ProxyNop` is never constructed [INFO] [stdout] --> src/proxy/copy.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | struct ProxyNop {} [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/copy.rs:16:24 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn logger_new_from_proxy(original: L, proxy: P) -> impl Logger [INFO] [stdout] | ----------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | logger_new_from_fn(move |old: Item| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 17 | | let neo: Item = proxy.get_item(old); [INFO] [stdout] 18 | | original.log(neo) [INFO] [stdout] 19 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy/copy.rs:42:23 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn proxy_join(p: P, q: Q) -> impl Proxy [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | proxy_new_from_fn(move |original: Item| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 43 | | let after_p: Item = p.get_item(original); [INFO] [stdout] 44 | | q.get_item(after_p) [INFO] [stdout] 45 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy/copy.rs:70:23 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn proxy_new_from_resource_proxy(resource_proxy: R) -> impl Proxy [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | proxy_new_from_fn(move |mut original: Item| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 71 | | for pair in original.resource.iter_mut() { [INFO] [stdout] 72 | | let (key, val) = pair; [INFO] [stdout] 73 | | let neo: Option<&str> = resource_proxy.get_resource(key); [INFO] [stdout] ... | [INFO] [stdout] 82 | | original [INFO] [stdout] 83 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:47:16 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn limited_writer_new(original: L, log_available: S) -> impl LogWrite [INFO] [stdout] | ----------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | state: Mutex::new(log_available), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ProxyNop` is never constructed [INFO] [stdout] --> src/proxy/copy.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | struct ProxyNop {} [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/copy.rs:16:24 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn logger_new_from_proxy(original: L, proxy: P) -> impl Logger [INFO] [stdout] | ----------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | logger_new_from_fn(move |old: Item| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 17 | | let neo: Item = proxy.get_item(old); [INFO] [stdout] 18 | | original.log(neo) [INFO] [stdout] 19 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy/copy.rs:42:23 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn proxy_join(p: P, q: Q) -> impl Proxy [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | proxy_new_from_fn(move |original: Item| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 43 | | let after_p: Item = p.get_item(original); [INFO] [stdout] 44 | | q.get_item(after_p) [INFO] [stdout] 45 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy/copy.rs:70:23 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn proxy_new_from_resource_proxy(resource_proxy: R) -> impl Proxy [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | proxy_new_from_fn(move |mut original: Item| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 71 | | for pair in original.resource.iter_mut() { [INFO] [stdout] 72 | | let (key, val) = pair; [INFO] [stdout] 73 | | let neo: Option<&str> = resource_proxy.get_resource(key); [INFO] [stdout] ... | [INFO] [stdout] 82 | | original [INFO] [stdout] 83 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:47:16 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn limited_writer_new(original: L, log_available: S) -> impl LogWrite [INFO] [stdout] | ----------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | state: Mutex::new(log_available), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rs-simple-logging` (lib) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rs-simple-logging` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "3eb9ff5b5d36252ec8fc47523d06e78f4847ec64e2e927e4e1fab9ad6d75f77d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3eb9ff5b5d36252ec8fc47523d06e78f4847ec64e2e927e4e1fab9ad6d75f77d", kill_on_drop: false }` [INFO] [stdout] 3eb9ff5b5d36252ec8fc47523d06e78f4847ec64e2e927e4e1fab9ad6d75f77d