[INFO] fetching crate rs-git-lib 0.2.1... [INFO] checking rs-git-lib-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rs-git-lib 0.2.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate rs-git-lib 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rs-git-lib 0.2.1 [INFO] finished tweaking crates.io crate rs-git-lib 0.2.1 [INFO] tweaked toml for crates.io crate rs-git-lib 0.2.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 160 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bytes v0.5.6 (latest: v1.7.1) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding crc v1.8.1 (latest: v3.2.1) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding h2 v0.2.7 (latest: v0.4.6) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding http-body v0.3.1 (latest: v1.0.1) [INFO] [stderr] Adding httpdate v0.3.2 (latest: v1.0.3) [INFO] [stderr] Adding hyper v0.13.10 (latest: v1.4.1) [INFO] [stderr] Adding hyper-tls v0.4.3 (latest: v0.6.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itoa v0.4.8 (latest: v1.0.11) [INFO] [stderr] Adding lexical-core v0.7.6 (latest: v0.8.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding nom v5.1.3 (latest: v7.1.3) [INFO] [stderr] Adding num-derive v0.3.3 (latest: v0.4.2) [INFO] [stderr] Adding pin-project-lite v0.1.12 (latest: v0.2.14) [INFO] [stderr] Adding rand v0.3.23 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding reqwest v0.10.10 (latest: v0.12.7) [INFO] [stderr] Adding socket2 v0.3.19 (latest: v0.5.7) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding time v0.1.45 (latest: v0.3.36) [INFO] [stderr] Adding tokio v0.2.25 (latest: v1.40.0) [INFO] [stderr] Adding tokio-util v0.3.1 (latest: v0.7.11) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding winreg v0.7.0 (latest: v0.52.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5be8c098a40eb0b3e9e2b3741a7ef5b4a21d338c428e78cc0177965e02451f2c [INFO] running `Command { std: "docker" "start" "-a" "5be8c098a40eb0b3e9e2b3741a7ef5b4a21d338c428e78cc0177965e02451f2c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5be8c098a40eb0b3e9e2b3741a7ef5b4a21d338c428e78cc0177965e02451f2c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5be8c098a40eb0b3e9e2b3741a7ef5b4a21d338c428e78cc0177965e02451f2c", kill_on_drop: false }` [INFO] [stdout] 5be8c098a40eb0b3e9e2b3741a7ef5b4a21d338c428e78cc0177965e02451f2c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6ab9c3e8c12cb0b90513b68dfb667ff910c580ad9a40e5af85a358ee4395ec3d [INFO] running `Command { std: "docker" "start" "-a" "6ab9c3e8c12cb0b90513b68dfb667ff910c580ad9a40e5af85a358ee4395ec3d", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Compiling build_const v0.2.2 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Compiling nom v5.1.3 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking rustc-serialize v0.3.25 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Compiling crc v1.8.1 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Checking tokio v0.2.25 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Checking tokio-util v0.3.1 [INFO] [stderr] Checking tokio-tls v0.3.1 [INFO] [stderr] Checking h2 v0.2.7 [INFO] [stderr] Checking hyper v0.13.10 [INFO] [stderr] Checking hyper-tls v0.4.3 [INFO] [stderr] Checking reqwest v0.10.10 [INFO] [stderr] Checking rs-git-lib v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDateTime::from_timestamp`: use `DateTime::from_timestamp` instead [INFO] [stdout] --> src/store/commit.rs:98:40 [INFO] [stdout] | [INFO] [stdout] 98 | let naive = NaiveDateTime::from_timestamp(ts as i64, 0); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDateTime::from_timestamp`: use `DateTime::from_timestamp` instead [INFO] [stdout] --> src/store/commit.rs:98:40 [INFO] [stdout] | [INFO] [stdout] 98 | let naive = NaiveDateTime::from_timestamp(ts as i64, 0); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::FixedOffset::east`: use `east_opt()` instead [INFO] [stdout] --> src/store/commit.rs:99:39 [INFO] [stdout] | [INFO] [stdout] 99 | let offset = FixedOffset::east(sgn * tz/100 * 3600); [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::FixedOffset::east`: use `east_opt()` instead [INFO] [stdout] --> src/store/commit.rs:99:39 [INFO] [stdout] | [INFO] [stdout] 99 | let offset = FixedOffset::east(sgn * tz/100 * 3600); [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stdout] --> src/store/commit.rs:100:39 [INFO] [stdout] | [INFO] [stdout] 100 | let timestamp = DateTime::from_utc(naive, offset); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stdout] --> src/store/commit.rs:100:39 [INFO] [stdout] | [INFO] [stdout] 100 | let timestamp = DateTime::from_utc(naive, offset); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `get_offset` is never read [INFO] [stdout] --> src/delta/mod.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 10 | struct DeltaHeader { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | get_offset: usize, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DeltaHeader` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `get_offset` is never read [INFO] [stdout] --> src/delta/mod.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 10 | struct DeltaHeader { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | get_offset: usize, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DeltaHeader` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `index` is never read [INFO] [stdout] --> src/packfile/mod.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct PackFile { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 24 | pub index: PackIndex, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `timestamp` is never read [INFO] [stdout] --> src/store/commit.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Person<'a> { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | timestamp: DateTime, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Person` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `raw` is never read [INFO] [stdout] --> src/store/commit.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct Commit<'a> { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 23 | raw: &'a GitObject, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Commit` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name`, `email`, and `timestamp` are never read [INFO] [stdout] --> src/store/commit.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Person<'a> { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 11 | name: &'a str, [INFO] [stdout] | ^^^^ [INFO] [stdout] 12 | email: &'a str, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 13 | timestamp: DateTime, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Person` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `protocol` is never used [INFO] [stdout] --> src/transport/client/mod.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 12 | pub trait Protocol { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 15 | fn protocol(&self) -> &'static str; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `raw` is never read [INFO] [stdout] --> src/store/commit.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct Commit<'a> { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 23 | raw: &'a GitObject, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Commit` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rs-git-lib` (lib test) due to 6 previous errors; 12 warnings emitted [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> src/transport/client/file_client.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct FileProtocol { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 9 | path: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FileProtocol` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `protocol` is never used [INFO] [stdout] --> src/transport/client/mod.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 12 | pub trait Protocol { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 15 | fn protocol(&self) -> &'static str; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rs-git-lib` (lib) due to 6 previous errors; 12 warnings emitted [INFO] [stdout] warning: field `url` is never read [INFO] [stdout] --> src/transport/client/git_client.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct GitProtocol { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 10 | url: Url, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GitProtocol` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> src/transport/client/file_client.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct FileProtocol { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 9 | path: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FileProtocol` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> src/transport/client/local_client.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct LocalProtocol { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 9 | path: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LocalProtocol` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `url` is never read [INFO] [stdout] --> src/transport/client/git_client.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct GitProtocol { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 10 | url: Url, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GitProtocol` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `url` is never read [INFO] [stdout] --> src/transport/client/ssh_client.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct SshProtocol { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 10 | url: Url, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SshProtocol` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> src/transport/client/local_client.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct LocalProtocol { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 9 | path: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LocalProtocol` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:157:27 [INFO] [stdout] | [INFO] [stdout] 157 | .and_then(|t| self.walk_tree(&self.dir, &t, &mut idx).ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `url` is never read [INFO] [stdout] --> src/transport/client/ssh_client.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct SshProtocol { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 10 | url: Url, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SshProtocol` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:187:39 [INFO] [stdout] | [INFO] [stdout] 187 | .and_then(|t| self.walk_tree(path_str, &t, idx).ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:157:27 [INFO] [stdout] | [INFO] [stdout] 157 | .and_then(|t| self.walk_tree(&self.dir, &t, &mut idx).ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:225:13 [INFO] [stdout] | [INFO] [stdout] 219 | GitObject::open(&self.dir, sha).or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | pack.find_by_sha(sha).map(|o| o.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:187:39 [INFO] [stdout] | [INFO] [stdout] 187 | .and_then(|t| self.walk_tree(path_str, &t, idx).ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:225:13 [INFO] [stdout] | [INFO] [stdout] 219 | GitObject::open(&self.dir, sha).or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | pack.find_by_sha(sha).map(|o| o.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packfile/index.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn open>(path: P) -> IOResult> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let mut file = match File::open(path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Err(io) => return Err(io), [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | Self::parse(&contents).map(Some) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/mod.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 24 | let (client, output_dir) = match res { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(Transport { client, output_dir }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packfile/index.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn open>(path: P) -> IOResult> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let mut file = match File::open(path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Err(io) => return Err(io), [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | Self::parse(&contents).map(Some) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message contains an unused formatting placeholder [INFO] [stdout] --> src/transport/url_parser.rs:225:38 [INFO] [stdout] | [INFO] [stdout] 225 | panic!("failed ssh parse {:?}"); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this message is not used as a format string when given without arguments, but will be in Rust 2021 [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add the missing argument [INFO] [stdout] | [INFO] [stdout] 225 | panic!("failed ssh parse {:?}", ...); [INFO] [stdout] | +++++ [INFO] [stdout] help: or add a "{}" format string to use the message literally [INFO] [stdout] | [INFO] [stdout] 225 | panic!("{}", "failed ssh parse {:?}"); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/mod.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 24 | let (client, output_dir) = match res { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(Transport { client, output_dir }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "6ab9c3e8c12cb0b90513b68dfb667ff910c580ad9a40e5af85a358ee4395ec3d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6ab9c3e8c12cb0b90513b68dfb667ff910c580ad9a40e5af85a358ee4395ec3d", kill_on_drop: false }` [INFO] [stdout] 6ab9c3e8c12cb0b90513b68dfb667ff910c580ad9a40e5af85a358ee4395ec3d