[INFO] fetching crate rpz 1.0.0... [INFO] checking rpz-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rpz 1.0.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate rpz 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-4-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate rpz 1.0.0 [INFO] finished tweaking crates.io crate rpz 1.0.0 [INFO] tweaked toml for crates.io crate rpz 1.0.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate rpz 1.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 146c08ee35b75b92d46a7069ebd97eaf370ae4d161d2ea0b65e206221b6f4c30 [INFO] running `Command { std: "docker" "start" "-a" "146c08ee35b75b92d46a7069ebd97eaf370ae4d161d2ea0b65e206221b6f4c30", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "146c08ee35b75b92d46a7069ebd97eaf370ae4d161d2ea0b65e206221b6f4c30", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "146c08ee35b75b92d46a7069ebd97eaf370ae4d161d2ea0b65e206221b6f4c30", kill_on_drop: false }` [INFO] [stdout] 146c08ee35b75b92d46a7069ebd97eaf370ae4d161d2ea0b65e206221b6f4c30 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0d9923ea84677967a30d4347cf22844a03c33da5ca93f03cf724bce8a18ab0d0 [INFO] running `Command { std: "docker" "start" "-a" "0d9923ea84677967a30d4347cf22844a03c33da5ca93f03cf724bce8a18ab0d0", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling serde v1.0.208 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling cc v1.1.13 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Compiling syn v2.0.75 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking tokio v1.39.3 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Compiling zfc v0.3.2 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking flate2 v1.0.32 [INFO] [stderr] Checking rustls-native-certs v0.7.2 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling ascii_domain v0.6.1 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking brotli v6.0.0 [INFO] [stderr] Checking indexmap v2.4.0 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking superset_map v0.2.3 [INFO] [stderr] Compiling serde_derive v1.0.208 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking rustls-webpki v0.102.6 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking async-compression v0.4.12 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking hyper-rustls v0.27.2 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking rpz v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom.rs:709:9 [INFO] [stdout] | [INFO] [stdout] 708 | fn write_to_rpz(&self, action: RpzAction, mut writer: W) -> Result<(), Error> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 709 | write_rpz_line(&mut writer, self.domain(), action, false).and_then(|()| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | rust_2024_compatibility, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[deny(tail_expr_drop_order)]` implied by `#[deny(rust_2024_compatibility)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom.rs:709:76 [INFO] [stdout] | [INFO] [stdout] 708 | fn write_to_rpz(&self, action: RpzAction, mut writer: W) -> Result<(), Error> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 709 | write_rpz_line(&mut writer, self.domain(), action, false).and_then(|()| { [INFO] [stdout] | ____________________________________________________________________________^ [INFO] [stdout] 710 | | if self.subdomains { [INFO] [stdout] 711 | | write_rpz_line(writer, self.domain(), action, true) [INFO] [stdout] 712 | | } else { [INFO] [stdout] 713 | | Ok(()) [INFO] [stdout] 714 | | } [INFO] [stdout] 715 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:593:48 [INFO] [stdout] | [INFO] [stdout] 593 | .fold((), |(), line| match T::parse_value(line) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:663:13 [INFO] [stdout] | [INFO] [stdout] 662 | fn exists>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 663 | fs::metadata(path).map_or_else( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:854:17 [INFO] [stdout] | [INFO] [stdout] 849 | let resp = client [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 854 | resp.bytes().await.map_or_else( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:855:31 [INFO] [stdout] | [INFO] [stdout] 855 | |err| Err(ExtFileErr::Http(err)), [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:857:25 [INFO] [stdout] | [INFO] [stdout] 856 | |bytes| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 857 | / String::from_utf8(bytes.into()) [INFO] [stdout] 858 | | .map_err(ExtFileErr::InvalidUtf8) [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom.rs:709:9 [INFO] [stdout] | [INFO] [stdout] 708 | fn write_to_rpz(&self, action: RpzAction, mut writer: W) -> Result<(), Error> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 709 | write_rpz_line(&mut writer, self.domain(), action, false).and_then(|()| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | rust_2024_compatibility, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[deny(tail_expr_drop_order)]` implied by `#[deny(rust_2024_compatibility)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom.rs:709:76 [INFO] [stdout] | [INFO] [stdout] 708 | fn write_to_rpz(&self, action: RpzAction, mut writer: W) -> Result<(), Error> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 709 | write_rpz_line(&mut writer, self.domain(), action, false).and_then(|()| { [INFO] [stdout] | ____________________________________________________________________________^ [INFO] [stdout] 710 | | if self.subdomains { [INFO] [stdout] 711 | | write_rpz_line(writer, self.domain(), action, true) [INFO] [stdout] 712 | | } else { [INFO] [stdout] 713 | | Ok(()) [INFO] [stdout] 714 | | } [INFO] [stdout] 715 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:593:48 [INFO] [stdout] | [INFO] [stdout] 593 | .fold((), |(), line| match T::parse_value(line) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:663:13 [INFO] [stdout] | [INFO] [stdout] 662 | fn exists>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 663 | fs::metadata(path).map_or_else( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:854:17 [INFO] [stdout] | [INFO] [stdout] 849 | let resp = client [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 854 | resp.bytes().await.map_or_else( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:855:31 [INFO] [stdout] | [INFO] [stdout] 855 | |err| Err(ExtFileErr::Http(err)), [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:857:25 [INFO] [stdout] | [INFO] [stdout] 856 | |bytes| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 857 | / String::from_utf8(bytes.into()) [INFO] [stdout] 858 | | .map_err(ExtFileErr::InvalidUtf8) [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rpz` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rpz` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "0d9923ea84677967a30d4347cf22844a03c33da5ca93f03cf724bce8a18ab0d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0d9923ea84677967a30d4347cf22844a03c33da5ca93f03cf724bce8a18ab0d0", kill_on_drop: false }` [INFO] [stdout] 0d9923ea84677967a30d4347cf22844a03c33da5ca93f03cf724bce8a18ab0d0