[INFO] fetching crate rpds-pathtree 0.8.4... [INFO] checking rpds-pathtree-0.8.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rpds-pathtree 0.8.4 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate rpds-pathtree 0.8.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rpds-pathtree 0.8.4 [INFO] finished tweaking crates.io crate rpds-pathtree 0.8.4 [INFO] tweaked toml for crates.io crate rpds-pathtree 0.8.4 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 13 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4855304a7a961e03d8b4b6efdb025770b63ef20be51df714d354610ec2a33736 [INFO] running `Command { std: "docker" "start" "-a" "4855304a7a961e03d8b4b6efdb025770b63ef20be51df714d354610ec2a33736", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4855304a7a961e03d8b4b6efdb025770b63ef20be51df714d354610ec2a33736", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4855304a7a961e03d8b4b6efdb025770b63ef20be51df714d354610ec2a33736", kill_on_drop: false }` [INFO] [stdout] 4855304a7a961e03d8b4b6efdb025770b63ef20be51df714d354610ec2a33736 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fde0439fbc33953586a3048aa334d51977cd2d59da222b344e124b4e5c2b3f53 [INFO] running `Command { std: "docker" "start" "-a" "fde0439fbc33953586a3048aa334d51977cd2d59da222b344e124b4e5c2b3f53", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking triomphe v0.1.13 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking archery v1.2.1 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking rpds v1.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking rpds-pathtree v0.8.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:142:23 [INFO] [stdout] | [INFO] [stdout] 140 | pub(crate) fn new(value: T::InnerValue) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | Self { [INFO] [stdout] 142 | children: new_hash_map(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:450:12 [INFO] [stdout] | [INFO] [stdout] 353 | mut new_inner_value: impl FnMut() -> T::InnerValue, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 354 | try_clone_leaf_into_inner_value: impl FnOnce(&T::LeafValue) -> Option, [INFO] [stdout] | ------------------------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 362 | let mut try_clone_leaf_into_inner_value = Some(try_clone_leaf_into_inner_value); [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 363 | let mut next_parent_node = Arc::clone(self.root_node()); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 364 | let (parent_path_segments, child_path_segment) = child_path.parent_child_segments(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 431 | let next_parent_node = match try_replace_leaf_with_inner_node( [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 436 | Ok(next_parent_node) => next_parent_node, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 437 | Err(parent_node) => { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 446 | let parent_node = match next_parent_node.node { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 450 | Ok(TreeNodeParentChildContext { [INFO] [stdout] | ____________^ [INFO] [stdout] 451 | | parent_node, [INFO] [stdout] 452 | | child_path_segment, [INFO] [stdout] 453 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:654:12 [INFO] [stdout] | [INFO] [stdout] 525 | new_value: NodeValue, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 539 | let (inner_node, child_node, replaced_child_node, removed_subtree) = if let Some( [INFO] [stdout] | ---------- ---------- ------------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 548 | let old_child_node = Arc::clone(child_node); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 551 | let new_child_node = self.update_node_value(&old_child_node, new_value)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 559 | let (inner_node, new_child_node, removed_subtree) = { [INFO] [stdout] | ---------- -------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 560 | let new_parent = HalfEdge { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 564 | let updated_child_node = [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 565 | old_child_node.try_clone_with_parent_and_value(Some(new_parent), new_value)?; [INFO] [stdout] 566 | let (mut inner_node, removed_subtree) = if let Some(subtree_root_node_id) = [INFO] [stdout] | ---------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 570 | let removed_subtree = self.remove_subtree_by_id(subtree_root_node_id); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 573 | parent_node, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 574 | child_path_segment: removed_child_path_segment, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 575 | removed_subtree, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 595 | let new_child_node = Arc::new(updated_child_node); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 618 | let new_child_node = TreeNode { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 627 | let new_child_node = Arc::new(new_child_node); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 634 | let mut inner_node = inner_node.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 645 | let parent_node = TreeNode { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 651 | let new_parent_node = Arc::new(parent_node); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 654 | Ok(ParentChildTreeNode { [INFO] [stdout] | ____________^ [INFO] [stdout] 655 | | parent_node: Some(new_parent_node), [INFO] [stdout] 656 | | child_node, [INFO] [stdout] 657 | | replaced_child_node, [INFO] [stdout] 658 | | removed_subtree, [INFO] [stdout] 659 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:779:14 [INFO] [stdout] | [INFO] [stdout] 700 | let node = self.nodes.get(&node_id).map(Arc::clone)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 716 | let mut subtree_nodes: HashMap<_, _> = descendant_node_ids [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 727 | let new_parent_node = { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 738 | let mut inner_node = inner_node.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 755 | let new_parent_node = Arc::new(new_parent_node); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 762 | let TreeNode { id, parent, node } = Arc::unwrap_or_clone(node); [INFO] [stdout] | ------ ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 763 | let parent = parent.expect("has a parent"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 764 | debug_assert_eq!(parent.node_id, new_parent_node.id); [INFO] [stdout] 765 | let child_path_segment = parent.path_segment; [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 766 | let subtree_root_node = Arc::new(TreeNode { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 772 | let removed_subtree = Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 779 | Some(RemovedSubtree { [INFO] [stdout] | ______________^ [INFO] [stdout] 780 | | parent_node: new_parent_node, [INFO] [stdout] 781 | | child_path_segment, [INFO] [stdout] 782 | | removed_subtree, [INFO] [stdout] 783 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:722:22 [INFO] [stdout] | [INFO] [stdout] 719 | let node = self.nodes.get(&node_id).map(Arc::clone)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 722 | Some((node_id, node)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:904:12 [INFO] [stdout] | [INFO] [stdout] 804 | mut subtree: Self, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 807 | let mut subtree_parent_node = None; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 811 | let mut subtree_replaced_child_node = None; [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 812 | let mut subtree_removed_subtree = None; [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 904 | Ok(InsertedOrReplacedSubtree { [INFO] [stdout] | ____________^ [INFO] [stdout] 905 | | parent_node: subtree_parent_node.expect("has been updated"), [INFO] [stdout] 906 | | child_node_id: subtree_child_node_id, [INFO] [stdout] 907 | | replaced_child_node: subtree_replaced_child_node, [INFO] [stdout] 908 | | removed_subtree: subtree_removed_subtree, [INFO] [stdout] 909 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:1020:46 [INFO] [stdout] | [INFO] [stdout] 1018 | new_value: NodeValue, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1019 | ) -> Result> { [INFO] [stdout] 1020 | self.try_clone_with_parent_and_value(None, new_value) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rpds-pathtree` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:142:23 [INFO] [stdout] | [INFO] [stdout] 140 | pub(crate) fn new(value: T::InnerValue) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | Self { [INFO] [stdout] 142 | children: new_hash_map(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:450:12 [INFO] [stdout] | [INFO] [stdout] 353 | mut new_inner_value: impl FnMut() -> T::InnerValue, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 354 | try_clone_leaf_into_inner_value: impl FnOnce(&T::LeafValue) -> Option, [INFO] [stdout] | ------------------------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 362 | let mut try_clone_leaf_into_inner_value = Some(try_clone_leaf_into_inner_value); [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 363 | let mut next_parent_node = Arc::clone(self.root_node()); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 364 | let (parent_path_segments, child_path_segment) = child_path.parent_child_segments(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 431 | let next_parent_node = match try_replace_leaf_with_inner_node( [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 436 | Ok(next_parent_node) => next_parent_node, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 437 | Err(parent_node) => { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 446 | let parent_node = match next_parent_node.node { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 450 | Ok(TreeNodeParentChildContext { [INFO] [stdout] | ____________^ [INFO] [stdout] 451 | | parent_node, [INFO] [stdout] 452 | | child_path_segment, [INFO] [stdout] 453 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:654:12 [INFO] [stdout] | [INFO] [stdout] 525 | new_value: NodeValue, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 539 | let (inner_node, child_node, replaced_child_node, removed_subtree) = if let Some( [INFO] [stdout] | ---------- ---------- ------------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 548 | let old_child_node = Arc::clone(child_node); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 551 | let new_child_node = self.update_node_value(&old_child_node, new_value)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 559 | let (inner_node, new_child_node, removed_subtree) = { [INFO] [stdout] | ---------- -------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 560 | let new_parent = HalfEdge { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 564 | let updated_child_node = [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 565 | old_child_node.try_clone_with_parent_and_value(Some(new_parent), new_value)?; [INFO] [stdout] 566 | let (mut inner_node, removed_subtree) = if let Some(subtree_root_node_id) = [INFO] [stdout] | ---------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 570 | let removed_subtree = self.remove_subtree_by_id(subtree_root_node_id); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 573 | parent_node, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 574 | child_path_segment: removed_child_path_segment, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 575 | removed_subtree, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 595 | let new_child_node = Arc::new(updated_child_node); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 618 | let new_child_node = TreeNode { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 627 | let new_child_node = Arc::new(new_child_node); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 634 | let mut inner_node = inner_node.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 645 | let parent_node = TreeNode { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 651 | let new_parent_node = Arc::new(parent_node); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 654 | Ok(ParentChildTreeNode { [INFO] [stdout] | ____________^ [INFO] [stdout] 655 | | parent_node: Some(new_parent_node), [INFO] [stdout] 656 | | child_node, [INFO] [stdout] 657 | | replaced_child_node, [INFO] [stdout] 658 | | removed_subtree, [INFO] [stdout] 659 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:779:14 [INFO] [stdout] | [INFO] [stdout] 700 | let node = self.nodes.get(&node_id).map(Arc::clone)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 716 | let mut subtree_nodes: HashMap<_, _> = descendant_node_ids [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 727 | let new_parent_node = { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 738 | let mut inner_node = inner_node.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 755 | let new_parent_node = Arc::new(new_parent_node); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 762 | let TreeNode { id, parent, node } = Arc::unwrap_or_clone(node); [INFO] [stdout] | ------ ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 763 | let parent = parent.expect("has a parent"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 764 | debug_assert_eq!(parent.node_id, new_parent_node.id); [INFO] [stdout] 765 | let child_path_segment = parent.path_segment; [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 766 | let subtree_root_node = Arc::new(TreeNode { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 772 | let removed_subtree = Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 779 | Some(RemovedSubtree { [INFO] [stdout] | ______________^ [INFO] [stdout] 780 | | parent_node: new_parent_node, [INFO] [stdout] 781 | | child_path_segment, [INFO] [stdout] 782 | | removed_subtree, [INFO] [stdout] 783 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:722:22 [INFO] [stdout] | [INFO] [stdout] 719 | let node = self.nodes.get(&node_id).map(Arc::clone)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 722 | Some((node_id, node)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:904:12 [INFO] [stdout] | [INFO] [stdout] 804 | mut subtree: Self, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 807 | let mut subtree_parent_node = None; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 811 | let mut subtree_replaced_child_node = None; [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 812 | let mut subtree_removed_subtree = None; [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 904 | Ok(InsertedOrReplacedSubtree { [INFO] [stdout] | ____________^ [INFO] [stdout] 905 | | parent_node: subtree_parent_node.expect("has been updated"), [INFO] [stdout] 906 | | child_node_id: subtree_child_node_id, [INFO] [stdout] 907 | | replaced_child_node: subtree_replaced_child_node, [INFO] [stdout] 908 | | removed_subtree: subtree_removed_subtree, [INFO] [stdout] 909 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:1020:46 [INFO] [stdout] | [INFO] [stdout] 1018 | new_value: NodeValue, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1019 | ) -> Result> { [INFO] [stdout] 1020 | self.try_clone_with_parent_and_value(None, new_value) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:61:10 [INFO] [stdout] | [INFO] [stdout] 60 | let (parent_segments, child_segment) = self.parent_child_segments(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | (Box::new(parent_segments), child_segment) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rpds-pathtree` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "fde0439fbc33953586a3048aa334d51977cd2d59da222b344e124b4e5c2b3f53", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fde0439fbc33953586a3048aa334d51977cd2d59da222b344e124b4e5c2b3f53", kill_on_drop: false }` [INFO] [stdout] fde0439fbc33953586a3048aa334d51977cd2d59da222b344e124b4e5c2b3f53