[INFO] fetching crate royal_road_archiver 1.0.3... [INFO] checking royal_road_archiver-1.0.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate royal_road_archiver 1.0.3 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate royal_road_archiver 1.0.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate royal_road_archiver 1.0.3 [INFO] finished tweaking crates.io crate royal_road_archiver 1.0.3 [INFO] tweaked toml for crates.io crate royal_road_archiver 1.0.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate royal_road_archiver 1.0.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 44dfa370f80b13c6437233f3f97cc828a5aec770c80e82fd5d8198515ea3b16a [INFO] running `Command { std: "docker" "start" "-a" "44dfa370f80b13c6437233f3f97cc828a5aec770c80e82fd5d8198515ea3b16a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "44dfa370f80b13c6437233f3f97cc828a5aec770c80e82fd5d8198515ea3b16a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "44dfa370f80b13c6437233f3f97cc828a5aec770c80e82fd5d8198515ea3b16a", kill_on_drop: false }` [INFO] [stdout] 44dfa370f80b13c6437233f3f97cc828a5aec770c80e82fd5d8198515ea3b16a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4343e1d8cc603881614c498e8e3af9b05cdff117082bdef41fe8626b42416bd6 [INFO] running `Command { std: "docker" "start" "-a" "4343e1d8cc603881614c498e8e3af9b05cdff117082bdef41fe8626b42416bd6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling pkg-config v0.3.29 [INFO] [stderr] Compiling ppv-lite86 v0.2.17 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking new_debug_unreachable v1.0.4 [INFO] [stderr] Checking phf_shared v0.10.0 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Checking mac v0.1.1 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking phf v0.10.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling openssl v0.10.63 [INFO] [stderr] Compiling zstd-safe v5.0.2+zstd.1.5.2 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking http v0.2.11 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling rustix v0.38.30 [INFO] [stderr] Checking dtoa v1.0.9 [INFO] [stderr] Checking password-hash v0.4.2 [INFO] [stderr] Compiling jobserver v0.1.27 [INFO] [stderr] Compiling getrandom v0.2.12 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking dtoa-short v0.3.4 [INFO] [stderr] Checking aes v0.8.3 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking time v0.3.31 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling ahash v0.8.7 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Compiling eyre v0.6.11 [INFO] [stderr] Compiling rustls v0.21.10 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking anstream v0.6.11 [INFO] [stderr] Checking servo_arc v0.3.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking iana-time-zone v0.1.59 [INFO] [stderr] Checking utf8-width v0.1.7 [INFO] [stderr] Checking html-escape v0.2.13 [INFO] [stderr] Checking clap_builder v4.4.18 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling phf_codegen v0.10.0 [INFO] [stderr] Compiling string_cache_codegen v0.5.2 [INFO] [stderr] Compiling openssl-sys v0.9.99 [INFO] [stderr] Compiling zstd-sys v2.0.9+zstd.1.5.5 [INFO] [stderr] Compiling ring v0.17.7 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Compiling selectors v0.25.0 [INFO] [stderr] Checking chrono v0.4.33 [INFO] [stderr] Compiling markup5ever v0.11.0 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking uuid v1.7.0 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking string_cache v0.8.7 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking upon v0.7.1 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking ego-tree v0.6.2 [INFO] [stderr] Checking indicatif v0.17.7 [INFO] [stderr] Checking path-slash v0.2.1 [INFO] [stderr] Checking regex-automata v0.4.4 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking tempfile v3.9.0 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking h2 v0.3.24 [INFO] [stderr] Checking xml5ever v0.17.0 [INFO] [stderr] Compiling html5ever v0.26.0 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Compiling cssparser-macros v0.6.1 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking cssparser v0.31.2 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking clap v4.4.18 [INFO] [stderr] Checking markup5ever_rcdom v0.2.0 [INFO] [stderr] Checking html2md v0.2.14 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking scraper v0.18.1 [INFO] [stderr] Checking zstd v0.11.2+zstd.1.5.2 [INFO] [stderr] Checking zip v0.6.6 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking zip-extract v0.1.3 [INFO] [stderr] Checking epub-builder v0.7.4 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.23 [INFO] [stderr] Checking royal_road_archiver v1.0.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `audiobook_args` [INFO] [stdout] --> src/library.rs:70:27 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn generate_audiobook(audiobook_args: AudiobookArgs, book_url: Url, output_directory: PathBuf) -> Result src/library.rs:70:58 [INFO] [stdout] | [INFO] [stdout] 70 | ...obook_args: AudiobookArgs, book_url: Url, output_directory: PathBuf) -> Result, GenerationErro... [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_book_url` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `output_directory` [INFO] [stdout] --> src/library.rs:70:73 [INFO] [stdout] | [INFO] [stdout] 70 | ...gs, book_url: Url, output_directory: PathBuf) -> Result, GenerationError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_output_directory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `audiobook_args` [INFO] [stdout] --> src/library.rs:70:27 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn generate_audiobook(audiobook_args: AudiobookArgs, book_url: Url, output_directory: PathBuf) -> Result src/library.rs:70:58 [INFO] [stdout] | [INFO] [stdout] 70 | ...obook_args: AudiobookArgs, book_url: Url, output_directory: PathBuf) -> Result, GenerationErro... [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_book_url` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `output_directory` [INFO] [stdout] --> src/library.rs:70:73 [INFO] [stdout] | [INFO] [stdout] 70 | ...gs, book_url: Url, output_directory: PathBuf) -> Result, GenerationError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_output_directory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `html_args` [INFO] [stdout] --> src/library.rs:211:22 [INFO] [stdout] | [INFO] [stdout] 211 | pub fn generate_html(html_args: HtmlArgs, book_url: Url, output_directory: PathBuf) -> Result, Ge... [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_html_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `book_url` [INFO] [stdout] --> src/library.rs:211:43 [INFO] [stdout] | [INFO] [stdout] 211 | pub fn generate_html(html_args: HtmlArgs, book_url: Url, output_directory: PathBuf) -> Result, Ge... [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_book_url` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `output_directory` [INFO] [stdout] --> src/library.rs:211:58 [INFO] [stdout] | [INFO] [stdout] 211 | ...gs, book_url: Url, output_directory: PathBuf) -> Result, GenerationError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_output_directory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `html_args` [INFO] [stdout] --> src/library.rs:211:22 [INFO] [stdout] | [INFO] [stdout] 211 | pub fn generate_html(html_args: HtmlArgs, book_url: Url, output_directory: PathBuf) -> Result, Ge... [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_html_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `book_url` [INFO] [stdout] --> src/library.rs:211:43 [INFO] [stdout] | [INFO] [stdout] 211 | pub fn generate_html(html_args: HtmlArgs, book_url: Url, output_directory: PathBuf) -> Result, Ge... [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_book_url` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `output_directory` [INFO] [stdout] --> src/library.rs:211:58 [INFO] [stdout] | [INFO] [stdout] 211 | ...gs, book_url: Url, output_directory: PathBuf) -> Result, GenerationError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_output_directory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `index_html` is never read [INFO] [stdout] --> src/book.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct Book { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 29 | index_html: Html, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `count_paragraphs` is never used [INFO] [stdout] --> src/book.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 38 | impl Book { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 88 | pub fn count_paragraphs(&self) -> u128 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `chapter_url` and `raw_chapter_html` are never read [INFO] [stdout] --> src/book.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 95 | pub struct Chapter { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 96 | /// The Url of the chapter. [INFO] [stdout] 97 | chapter_url: Url, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 103 | raw_chapter_html: Html, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library.rs:204:8 [INFO] [stdout] | [INFO] [stdout] 79 | let book = book::Book::new(book_url)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let mut epub_builder = EpubBuilder::new(ZipLibrary::new().unwrap()).unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let cover_image = http::get_response(book.cover_image_url)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | let html2xhtml_dir = file_system_crap::setup_html2xhtml()?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | let mut output_file = match OpenOptions::new().write(true).create_new(true).open(&output_path) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | Ok(output_file) => output_file, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | Err(error) => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | Ok(WARNINGS.lock().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library.rs:261:8 [INFO] [stdout] | [INFO] [stdout] 220 | let book = book::Book::new(book_url)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | let mut output_file = match OpenOptions::new().write(true).create_new(true).open(&output_path) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | Ok(output_file) => output_file, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | Err(error) => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 261 | Ok(WARNINGS.lock().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_system_crap.rs:78:11 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn delete_html2xhtml(html2xhtml_dir: TempDir) { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | match html2xhtml_dir.close() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 22 | let selector = Selector::parse("meta").unwrap(); // Build a selector that finds the 'meta' html tag [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | Err(GenerationError::BookTitleFetchError{url: book_url.clone()}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 42 | let selector = Selector::parse("meta").unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | Err(GenerationError::BookAuthorFetchError{url: book_url.clone()}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 58 | let selector = Selector::parse("meta").unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Err(GenerationError::BookCoverImageUrlFetchError{url: book_url.clone()}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 126 | let page_html = Html::parse_document(&raw_chapter_html.html()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | [INFO] [stdout] 128 | let selector = Selector::parse("div").unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | Err(GenerationError::ChapterContentIsolationError{url: chapter_url.clone()}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http.rs:22:15 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn get_text(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | match self.response.text() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn get_bytes(self) -> Result{ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | match self.response.bytes() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `index_html` is never read [INFO] [stdout] --> src/book.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct Book { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 29 | index_html: Html, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `count_paragraphs` is never used [INFO] [stdout] --> src/book.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 38 | impl Book { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 88 | pub fn count_paragraphs(&self) -> u128 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `chapter_url` and `raw_chapter_html` are never read [INFO] [stdout] --> src/book.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 95 | pub struct Chapter { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 96 | /// The Url of the chapter. [INFO] [stdout] 97 | chapter_url: Url, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 103 | raw_chapter_html: Html, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library.rs:204:8 [INFO] [stdout] | [INFO] [stdout] 79 | let book = book::Book::new(book_url)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let mut epub_builder = EpubBuilder::new(ZipLibrary::new().unwrap()).unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let cover_image = http::get_response(book.cover_image_url)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | let html2xhtml_dir = file_system_crap::setup_html2xhtml()?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | let mut output_file = match OpenOptions::new().write(true).create_new(true).open(&output_path) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | Ok(output_file) => output_file, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | Err(error) => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | Ok(WARNINGS.lock().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library.rs:261:8 [INFO] [stdout] | [INFO] [stdout] 220 | let book = book::Book::new(book_url)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | let mut output_file = match OpenOptions::new().write(true).create_new(true).open(&output_path) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | Ok(output_file) => output_file, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | Err(error) => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 261 | Ok(WARNINGS.lock().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_system_crap.rs:78:11 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn delete_html2xhtml(html2xhtml_dir: TempDir) { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | match html2xhtml_dir.close() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 22 | let selector = Selector::parse("meta").unwrap(); // Build a selector that finds the 'meta' html tag [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | Err(GenerationError::BookTitleFetchError{url: book_url.clone()}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 42 | let selector = Selector::parse("meta").unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | Err(GenerationError::BookAuthorFetchError{url: book_url.clone()}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 58 | let selector = Selector::parse("meta").unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Err(GenerationError::BookCoverImageUrlFetchError{url: book_url.clone()}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 126 | let page_html = Html::parse_document(&raw_chapter_html.html()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | [INFO] [stdout] 128 | let selector = Selector::parse("div").unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | Err(GenerationError::ChapterContentIsolationError{url: chapter_url.clone()}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http.rs:22:15 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn get_text(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | match self.response.text() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn get_bytes(self) -> Result{ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | match self.response.bytes() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `royal_road_archiver` (lib) due to 10 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 9 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `royal_road_archiver` (lib test) due to 10 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4343e1d8cc603881614c498e8e3af9b05cdff117082bdef41fe8626b42416bd6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4343e1d8cc603881614c498e8e3af9b05cdff117082bdef41fe8626b42416bd6", kill_on_drop: false }` [INFO] [stdout] 4343e1d8cc603881614c498e8e3af9b05cdff117082bdef41fe8626b42416bd6