[INFO] fetching crate routefinder 0.5.4... [INFO] checking routefinder-0.5.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate routefinder 0.5.4 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate routefinder 0.5.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate routefinder 0.5.4 [INFO] finished tweaking crates.io crate routefinder 0.5.4 [INFO] tweaked toml for crates.io crate routefinder 0.5.4 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate routefinder 0.5.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 814ff48a9243748f15a738f78f8b407ef00710c0f2b08729c2a727414c7112cb [INFO] running `Command { std: "docker" "start" "-a" "814ff48a9243748f15a738f78f8b407ef00710c0f2b08729c2a727414c7112cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "814ff48a9243748f15a738f78f8b407ef00710c0f2b08729c2a727414c7112cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "814ff48a9243748f15a738f78f8b407ef00710c0f2b08729c2a727414c7112cb", kill_on_drop: false }` [INFO] [stdout] 814ff48a9243748f15a738f78f8b407ef00710c0f2b08729c2a727414c7112cb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5fec0f3d9b897688bb65ae75173467995486aa15fbfa1bca54e2034e584d74ce [INFO] running `Command { std: "docker" "start" "-a" "5fec0f3d9b897688bb65ae75173467995486aa15fbfa1bca54e2034e584d74ce", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Compiling serde_json v1.0.113 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking anstyle v1.0.5 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Compiling smartstring v1.0.1 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking half v2.3.1 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking clap_builder v4.4.18 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking smartcow v0.2.1 [INFO] [stderr] Checking routefinder v0.5.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/captures.rs:20:18 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(key: impl Into>, value: impl Into>) -> Self { [INFO] [stdout] | ------------------------------ ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Self { [INFO] [stdout] 20 | key: key.into().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/captures.rs:21:20 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(key: impl Into>, value: impl Into>) -> Self { [INFO] [stdout] | ------------------------------ ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | value: value.into().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/captures.rs:41:18 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn into_owned(self) -> Capture<'static, 'static> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Capture { [INFO] [stdout] 41 | key: self.key.into_owned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/captures.rs:42:20 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn into_owned(self) -> Capture<'static, 'static> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | value: self.value.into_owned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/captures.rs:66:21 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn into_owned(self) -> Captures<'static, 'static> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | Captures { [INFO] [stdout] 66 | params: self.params.into_iter().map(|c| c.into_owned()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/captures.rs:67:23 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn into_owned(self) -> Captures<'static, 'static> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | wildcard: self.wildcard.map(SmartCow::into_owned), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/captures.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 153 | fn from(f: F) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | f.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/captures.rs:163:21 [INFO] [stdout] | [INFO] [stdout] 161 | fn from_iter>(iter: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | Self { [INFO] [stdout] 163 | params: iter.into_iter().map(Into::into).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/captures.rs:164:23 [INFO] [stdout] | [INFO] [stdout] 161 | fn from_iter>(iter: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | wildcard: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:72:21 [INFO] [stdout] | [INFO] [stdout] 70 | fn from_iter>(iter: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Self { [INFO] [stdout] 72 | routes: iter.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 209 | pub fn get_handler(&self, spec: impl TryInto) -> Option<&Handler> { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | spec.try_into().ok().and_then(|sp| self.routes.get(&sp)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:215:9 [INFO] [stdout] | [INFO] [stdout] 214 | pub fn get_handler_mut(&mut self, spec: impl TryInto) -> Option<&mut Handler> { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | / spec.try_into() [INFO] [stdout] 216 | | .ok() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/route_spec.rs:224:12 [INFO] [stdout] | [INFO] [stdout] 175 | let segments = index_iter [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 225 | | source: Some(SmartString::from(source)), [INFO] [stdout] 226 | | segments, [INFO] [stdout] 227 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/route_spec.rs:250:21 [INFO] [stdout] | [INFO] [stdout] 247 | fn from(segments: Vec) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | source: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `routefinder` (lib) due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "5fec0f3d9b897688bb65ae75173467995486aa15fbfa1bca54e2034e584d74ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5fec0f3d9b897688bb65ae75173467995486aa15fbfa1bca54e2034e584d74ce", kill_on_drop: false }` [INFO] [stdout] 5fec0f3d9b897688bb65ae75173467995486aa15fbfa1bca54e2034e584d74ce