[INFO] fetching crate rotor-dns 0.4.0... [INFO] checking rotor-dns-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rotor-dns 0.4.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate rotor-dns 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rotor-dns 0.4.0 [INFO] finished tweaking crates.io crate rotor-dns 0.4.0 [INFO] tweaked toml for crates.io crate rotor-dns 0.4.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 37 packages to latest compatible versions [INFO] [stderr] Adding bitflags v0.4.0 (latest: v2.6.0) [INFO] [stderr] Adding byteorder v0.4.2 (latest: v1.5.0) [INFO] [stderr] Adding bytes v0.3.0 (latest: v1.7.1) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding dns-parser v0.3.5 (latest: v0.8.0) [INFO] [stderr] Adding log v0.3.9 (latest: v0.4.22) [INFO] [stderr] Adding mio v0.5.1 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.1.5 (latest: v0.6.0) [INFO] [stderr] Adding nix v0.5.1 (latest: v0.29.0) [INFO] [stderr] Adding quick-error v0.2.2 (latest: v2.0.1) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding rand v0.3.23 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding resolv-conf v0.4.0 (latest: v0.7.0) [INFO] [stderr] Adding slab v0.1.3 (latest: v0.4.9) [INFO] [stderr] Adding time v0.1.45 (latest: v0.3.36) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0f5343ed882d92d5a6a114bd32d035b21b316b974137f83db2c44255fd8d05bf [INFO] running `Command { std: "docker" "start" "-a" "0f5343ed882d92d5a6a114bd32d035b21b316b974137f83db2c44255fd8d05bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0f5343ed882d92d5a6a114bd32d035b21b316b974137f83db2c44255fd8d05bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f5343ed882d92d5a6a114bd32d035b21b316b974137f83db2c44255fd8d05bf", kill_on_drop: false }` [INFO] [stdout] 0f5343ed882d92d5a6a114bd32d035b21b316b974137f83db2c44255fd8d05bf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fe723482e1b0bbc5365d60407f47b7bdf189b3e53bd784685f3c403614ce3105 [INFO] running `Command { std: "docker" "start" "-a" "fe723482e1b0bbc5365d60407f47b7bdf189b3e53bd784685f3c403614ce3105", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Checking bitflags v0.4.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking slab v0.1.3 [INFO] [stderr] Checking bytes v0.3.0 [INFO] [stderr] Checking quick-error v0.2.2 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Compiling ws2_32-sys v0.2.1 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Checking byteorder v0.4.2 [INFO] [stderr] Checking resolv-conf v0.4.0 [INFO] [stderr] Checking argparse v0.2.2 [INFO] [stderr] Checking miow v0.1.5 [INFO] [stderr] Checking dns-parser v0.3.5 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking rotor v0.6.3 [INFO] [stderr] Checking rotor-tools v0.3.2 [INFO] [stderr] Checking rotor-dns v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/config.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | try!(File::open("/etc/resolv.conf") [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/config.rs:41:19 [INFO] [stdout] | [INFO] [stdout] 41 | let cfg = try!(resolv_conf::Config::parse(&buf)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/fsm.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 229 | try!(self.sock.send_to(&pack, &server)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/fsm.rs:223:20 [INFO] [stdout] | [INFO] [stdout] 223 | let pack = try!(builder.build() [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/resolver.rs:48:18 [INFO] [stdout] | [INFO] [stdout] 48 | let id = try!(res.send_request(&query, server)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/resolver.rs:31:54 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn query(&self, query: Query, scope: &mut GenericScope) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 31 | pub fn query(&self, query: Query, scope: &mut dyn GenericScope) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/config.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | try!(File::open("/etc/resolv.conf") [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/config.rs:41:19 [INFO] [stdout] | [INFO] [stdout] 41 | let cfg = try!(resolv_conf::Config::parse(&buf)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/fsm.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 229 | try!(self.sock.send_to(&pack, &server)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/fsm.rs:223:20 [INFO] [stdout] | [INFO] [stdout] 223 | let pack = try!(builder.build() [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/resolver.rs:48:18 [INFO] [stdout] | [INFO] [stdout] 48 | let id = try!(res.send_request(&query, server)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/resolver.rs:31:54 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn query(&self, query: Query, scope: &mut GenericScope) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 31 | pub fn query(&self, query: Query, scope: &mut dyn GenericScope) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:117:18 [INFO] [stdout] | [INFO] [stdout] 96 | let machine = DnsMachine { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | Ok(sock) => sock, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | Err(e) => return Response::error(Box::new(e)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let arc = Arc::new(Mutex::new(machine)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | Response::ok((Fsm(arc.clone(), PhantomData), Resolver(arc.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fsm.rs:258:22 [INFO] [stdout] | [INFO] [stdout] 250 | fn ready(self, _events: EventSet, scope: &mut Scope) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 254 | let mut res = self.0.lock().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | deadline_opt(Response::ok(self), deadline) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fsm.rs:267:22 [INFO] [stdout] | [INFO] [stdout] 263 | fn timeout(self, scope: &mut Scope) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 267 | deadline_opt(Response::ok(self), deadline) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fsm.rs:273:22 [INFO] [stdout] | [INFO] [stdout] 269 | fn wakeup(self, scope: &mut Scope) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 273 | deadline_opt(Response::ok(self), deadline) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rotor-dns` (lib) due to 5 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:117:18 [INFO] [stdout] | [INFO] [stdout] 96 | let machine = DnsMachine { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | Ok(sock) => sock, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | Err(e) => return Response::error(Box::new(e)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let arc = Arc::new(Mutex::new(machine)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | Response::ok((Fsm(arc.clone(), PhantomData), Resolver(arc.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fsm.rs:258:22 [INFO] [stdout] | [INFO] [stdout] 250 | fn ready(self, _events: EventSet, scope: &mut Scope) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 254 | let mut res = self.0.lock().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | deadline_opt(Response::ok(self), deadline) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fsm.rs:267:22 [INFO] [stdout] | [INFO] [stdout] 263 | fn timeout(self, scope: &mut Scope) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 267 | deadline_opt(Response::ok(self), deadline) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fsm.rs:273:22 [INFO] [stdout] | [INFO] [stdout] 269 | fn wakeup(self, scope: &mut Scope) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 273 | deadline_opt(Response::ok(self), deadline) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rotor-dns` (lib test) due to 5 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "fe723482e1b0bbc5365d60407f47b7bdf189b3e53bd784685f3c403614ce3105", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe723482e1b0bbc5365d60407f47b7bdf189b3e53bd784685f3c403614ce3105", kill_on_drop: false }` [INFO] [stdout] fe723482e1b0bbc5365d60407f47b7bdf189b3e53bd784685f3c403614ce3105