[INFO] fetching crate rosu-pp 1.1.0... [INFO] checking rosu-pp-1.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rosu-pp 1.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate rosu-pp 1.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rosu-pp 1.1.0 [INFO] finished tweaking crates.io crate rosu-pp 1.1.0 [INFO] tweaked toml for crates.io crate rosu-pp 1.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 53 packages to latest compatible versions [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d1782e4f666ed157ade9c8a1c251f37cbe86be4aec756f130c5fda426bb551b2 [INFO] running `Command { std: "docker" "start" "-a" "d1782e4f666ed157ade9c8a1c251f37cbe86be4aec756f130c5fda426bb551b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d1782e4f666ed157ade9c8a1c251f37cbe86be4aec756f130c5fda426bb551b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d1782e4f666ed157ade9c8a1c251f37cbe86be4aec756f130c5fda426bb551b2", kill_on_drop: false }` [INFO] [stdout] d1782e4f666ed157ade9c8a1c251f37cbe86be4aec756f130c5fda426bb551b2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b567ca9bee4b4831fa68aa69ec11c38ce66441f2c98a32f970966ab276f84102 [INFO] running `Command { std: "docker" "start" "-a" "b567ca9bee4b4831fa68aa69ec11c38ce66441f2c98a32f970966ab276f84102", kill_on_drop: false }` [INFO] [stderr] Checking rosu-map v0.1.2 [INFO] [stderr] Checking rosu-mods v0.1.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rosu-pp v1.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking proptest v1.5.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/any/performance/mod.rs:75:15 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn try_mode(self, mode: GameMode) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | match (self, mode) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/any/performance/into.rs:36:76 [INFO] [stdout] | [INFO] [stdout] 35 | fn into_performance(self) -> ::Performance<'map> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | ::Performance::from_map_or_attrs(self.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 93 | / impl_from_mode!( [INFO] [stdout] 94 | | osu { [INFO] [stdout] 95 | | Osu, [INFO] [stdout] 96 | | OsuDifficultyAttributes, [INFO] [stdout] ... | [INFO] [stdout] 113 | | }, [INFO] [stdout] 114 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_from_mode` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/any/performance/into.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 59 | fn into_performance(self) -> Performance<'map> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Performance::$mode( [INFO] [stdout] 61 | >::into_performance(self) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 93 | / impl_from_mode!( [INFO] [stdout] 94 | | osu { [INFO] [stdout] 95 | | Osu, [INFO] [stdout] 96 | | OsuDifficultyAttributes, [INFO] [stdout] ... | [INFO] [stdout] 113 | | }, [INFO] [stdout] 114 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_from_mode` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/any/performance/into.rs:118:39 [INFO] [stdout] | [INFO] [stdout] 117 | fn into_performance(self) -> Performance<'a> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | map_to_performance(self.mode, Cow::Owned(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/osu/difficulty/mod.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 212 | osu_objects: impl ExactSizeIterator>, [INFO] [stdout] | ------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | let mut osu_objects_iter = osu_objects [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | / osu_objects_iter [INFO] [stdout] 228 | | .enumerate() [INFO] [stdout] 229 | | .map(|(idx, h)| { [INFO] [stdout] 230 | | let diff_object = OsuDifficultyObject::new( [INFO] [stdout] ... | [INFO] [stdout] 242 | | diff_object [INFO] [stdout] 243 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/taiko/difficulty/color/alternating_mono_pattern.rs:37:30 [INFO] [stdout] | [INFO] [stdout] 37 | .and_then(|mono| mono.get().first_hit_object()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/taiko/difficulty/color/mono_streak.rs:32:22 [INFO] [stdout] | [INFO] [stdout] 32 | .map(|h| h.get().base_hit_type) [INFO] [stdout] | - ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/taiko/difficulty/color/preprocessor.rs:86:32 [INFO] [stdout] | [INFO] [stdout] 86 | .filter(|prev| taiko_object.get().base_hit_type == prev.get().base_hit_type); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/taiko/difficulty/color/preprocessor.rs:86:68 [INFO] [stdout] | [INFO] [stdout] 86 | .filter(|prev| taiko_object.get().base_hit_type == prev.get().base_hit_type); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/taiko/difficulty/color/preprocessor.rs:152:40 [INFO] [stdout] | [INFO] [stdout] 152 | .map_or(false, |other| data[0].get().is_repetition_of(&other.get())); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/taiko/difficulty/color/preprocessor.rs:152:72 [INFO] [stdout] | [INFO] [stdout] 152 | .map_or(false, |other| data[0].get().is_repetition_of(&other.get())); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/taiko/difficulty/color/preprocessor.rs:163:48 [INFO] [stdout] | [INFO] [stdout] 163 | .map_or(false, |other| data[0].get().is_repetition_of(&other.get())); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/taiko/difficulty/color/preprocessor.rs:163:80 [INFO] [stdout] | [INFO] [stdout] 163 | .map_or(false, |other| data[0].get().is_repetition_of(&other.get())); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/taiko/difficulty/color/preprocessor.rs:184:33 [INFO] [stdout] | [INFO] [stdout] 184 | .for_each(|pattern| pattern.get_mut().find_repetition_interval()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/taiko/difficulty/color/repeating_hit_patterns.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(prev: Option>) -> RefCount { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | RefCount::new(Self { [INFO] [stdout] | _______________________^ [INFO] [stdout] 22 | | alternating_mono_patterns: Vec::new(), [INFO] [stdout] 23 | | prev, [INFO] [stdout] 24 | | repetition_interval: 0, [INFO] [stdout] 25 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/taiko/difficulty/color/repeating_hit_patterns.rs:62:42 [INFO] [stdout] | [INFO] [stdout] 62 | .all(|(self_pat, other_pat)| self_pat.get().has_identical_mono_len(&other_pat.get())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/taiko/difficulty/color/repeating_hit_patterns.rs:62:81 [INFO] [stdout] | [INFO] [stdout] 62 | .all(|(self_pat, other_pat)| self_pat.get().has_identical_mono_len(&other_pat.get())) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/taiko/difficulty/color/repeating_hit_patterns.rs:68:30 [INFO] [stdout] | [INFO] [stdout] 68 | .and_then(|mono| mono.get().first_hit_object()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/taiko/difficulty/skills/color.rs:68:33 [INFO] [stdout] | [INFO] [stdout] 68 | .map_or(0.0, |prev| prev.get().start_time); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/taiko/difficulty/skills/peaks.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 44 | fn norm(p: f64, values: impl IntoIterator) -> f64 { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | / values [INFO] [stdout] 46 | | .into_iter() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/taiko/difficulty/skills/rhythm.rs:164:33 [INFO] [stdout] | [INFO] [stdout] 164 | .map_or(0.0, |prev| prev.get().start_time); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/taiko/difficulty/skills/stamina.rs:41:33 [INFO] [stdout] | [INFO] [stdout] 41 | .map_or(0.0, |prev| prev.get().start_time); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/taiko/performance/mod.rs:374:12 [INFO] [stdout] | [INFO] [stdout] 348 | fn try_from(mut osu: OsuPerformance<'map>) -> Result { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 349 | let MapOrAttrs::Map(converted) = osu.map_or_attrs else { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 353 | let map = match converted.try_convert() { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 354 | Ok(map) => map, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 355 | Err(map) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 374 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 375 | | map_or_attrs: MapOrAttrs::Map(map), [INFO] [stdout] 376 | | difficulty, [INFO] [stdout] 377 | | combo, [INFO] [stdout] ... | [INFO] [stdout] 382 | | misses, [INFO] [stdout] 383 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catch/difficulty/mod.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 105 | mut palpable_objects: impl ExactSizeIterator, [INFO] [stdout] | ----------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | / palpable_objects [INFO] [stdout] 117 | | .enumerate() [INFO] [stdout] 118 | | .map(|(i, hit_object)| { [INFO] [stdout] 119 | | let diff_object = CatchDifficultyObject::new( [INFO] [stdout] ... | [INFO] [stdout] 128 | | diff_object [INFO] [stdout] 129 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catch/performance/mod.rs:484:12 [INFO] [stdout] | [INFO] [stdout] 458 | fn try_from(mut osu: OsuPerformance<'map>) -> Result { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 459 | let MapOrAttrs::Map(converted) = osu.map_or_attrs else { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 463 | let map = match converted.try_convert() { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 464 | Ok(map) => map, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 465 | Err(map) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 484 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 485 | | map_or_attrs: MapOrAttrs::Map(map), [INFO] [stdout] 486 | | difficulty, [INFO] [stdout] 487 | | acc, [INFO] [stdout] ... | [INFO] [stdout] 493 | | misses, [INFO] [stdout] 494 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mania/performance/mod.rs:837:12 [INFO] [stdout] | [INFO] [stdout] 811 | fn try_from(mut osu: OsuPerformance<'map>) -> Result { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 812 | let MapOrAttrs::Map(converted) = osu.map_or_attrs else { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 816 | let map = match converted.try_convert() { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 817 | Ok(map) => map, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 818 | Err(map) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 837 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 838 | | map_or_attrs: MapOrAttrs::Map(map), [INFO] [stdout] 839 | | difficulty, [INFO] [stdout] 840 | | n320: None, [INFO] [stdout] ... | [INFO] [stdout] 847 | | hitresult_priority, [INFO] [stdout] 848 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/beatmap/converted.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn unchecked_from_owned(map: Beatmap) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | Self::try_from_owned(map).unwrap_or_else(|_| panic!("{}", INCOMPATIBLE_MODES)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/beatmap/converted.rs:166:77 [INFO] [stdout] | [INFO] [stdout] 166 | Converted::::try_from_owned(map).map_err(|map| Self::new(Cow::Owned(map))) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/sync.rs:19:18 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(inner: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Self(Rc::new(RefCell::new(inner))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 29 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rosu-pp` (lib) due to 30 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "b567ca9bee4b4831fa68aa69ec11c38ce66441f2c98a32f970966ab276f84102", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b567ca9bee4b4831fa68aa69ec11c38ce66441f2c98a32f970966ab276f84102", kill_on_drop: false }` [INFO] [stdout] b567ca9bee4b4831fa68aa69ec11c38ce66441f2c98a32f970966ab276f84102