[INFO] fetching crate roreo-common 0.0.1... [INFO] checking roreo-common-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate roreo-common 0.0.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate roreo-common 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate roreo-common 0.0.1 [INFO] finished tweaking crates.io crate roreo-common 0.0.1 [INFO] tweaked toml for crates.io crate roreo-common 0.0.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 130 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v3.2.25 (latest: v4.5.16) [INFO] [stderr] Adding clap_lex v0.2.4 (latest: v0.7.2) [INFO] [stderr] Adding criterion v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding darling v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_core v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_macro v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding fixedbitset v0.4.2 (latest: v0.5.7) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding multimap v0.8.3 (latest: v0.10.0) [INFO] [stderr] Adding os_str_bytes v6.6.1 (latest: v7.0.0) [INFO] [stderr] Adding prettyplease v0.1.25 (latest: v0.2.22) [INFO] [stderr] Adding prost v0.11.9 (latest: v0.13.2) [INFO] [stderr] Adding prost-build v0.11.9 (latest: v0.13.2) [INFO] [stderr] Adding prost-derive v0.11.9 (latest: v0.13.2) [INFO] [stderr] Adding prost-types v0.11.9 (latest: v0.13.2) [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding which v4.4.2 (latest: v6.0.3) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] aa0ba06e34e52a9ffcc6d33266c0451a6ba0545d728e003161c94c540759f8c4 [INFO] running `Command { std: "docker" "start" "-a" "aa0ba06e34e52a9ffcc6d33266c0451a6ba0545d728e003161c94c540759f8c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "aa0ba06e34e52a9ffcc6d33266c0451a6ba0545d728e003161c94c540759f8c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa0ba06e34e52a9ffcc6d33266c0451a6ba0545d728e003161c94c540759f8c4", kill_on_drop: false }` [INFO] [stdout] aa0ba06e34e52a9ffcc6d33266c0451a6ba0545d728e003161c94c540759f8c4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 736c55519442308014310312f9480d0d2675df2cfef04a9aab38e4b9bc501a2d [INFO] running `Command { std: "docker" "start" "-a" "736c55519442308014310312f9480d0d2675df2cfef04a9aab38e4b9bc501a2d", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling prettyplease v0.1.25 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking lock_api v0.4.12 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling tempfile v3.12.0 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling prost-derive v0.11.9 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Compiling derivit-core v0.1.5 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Compiling prost v0.11.9 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling viewit v0.1.5 [INFO] [stderr] Compiling prost-types v0.11.9 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Compiling prost-build v0.11.9 [INFO] [stderr] Compiling roreo-common v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/pb.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | #[cfg_attr(feature = "serde", derive(::serde::Serialize, ::serde::Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `crc32fast`, `default`, `indexmap`, `manifest`, `parking_lot`, `prost`, `prost-build`, `tracing`, and `viewit` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/pb.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | #[cfg_attr(feature = "serde", derive(::serde::Serialize, ::serde::Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `crc32fast`, `default`, `indexmap`, `manifest`, `parking_lot`, `prost`, `prost-build`, `tracing`, and `viewit` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest.rs:496:5 [INFO] [stdout] | [INFO] [stdout] 453 | let mut file = opts [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 465 | let mut buf_writter = std::io::BufWriter::with_capacity( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 496 | / opts [INFO] [stdout] 497 | | .create(false) [INFO] [stdout] 498 | | .write(true) [INFO] [stdout] 499 | | .append(true) [INFO] [stdout] ... | [INFO] [stdout] 503 | | .and_then(|_| File::open(&manifest_opts.dir).and_then(|dir| dir.sync_all())) [INFO] [stdout] 504 | | .map(|_| creations) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest.rs:502:25 [INFO] [stdout] | [INFO] [stdout] 502 | .and_then(|mut f| f.seek(SeekFrom::End(0)).map(|_| self.wal.write(f))) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest.rs:502:54 [INFO] [stdout] | [INFO] [stdout] 502 | .and_then(|mut f| f.seek(SeekFrom::End(0)).map(|_| self.wal.write(f))) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest.rs:503:21 [INFO] [stdout] | [INFO] [stdout] 503 | .and_then(|_| File::open(&manifest_opts.dir).and_then(|dir| dir.sync_all())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest.rs:538:11 [INFO] [stdout] | [INFO] [stdout] 533 | .and_then(|mut f| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 538 | f.write_all(&magic_buf).map(|_| Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest.rs:538:39 [INFO] [stdout] | [INFO] [stdout] 533 | .and_then(|mut f| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 538 | f.write_all(&magic_buf).map(|_| Self { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 539 | | opts: opt, [INFO] [stdout] 540 | | inner: Arc::new(Mutex::new(ManifestFileInner { [INFO] [stdout] 541 | | manifest: Default::default(), [INFO] [stdout] 542 | | wal: MaybeUninit::new(f), [INFO] [stdout] 543 | | })), [INFO] [stdout] 544 | | }) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest.rs:540:20 [INFO] [stdout] | [INFO] [stdout] 533 | .and_then(|mut f| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 540 | inner: Arc::new(Mutex::new(ManifestFileInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 541 | | manifest: Default::default(), [INFO] [stdout] 542 | | wal: MaybeUninit::new(f), [INFO] [stdout] 543 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest.rs:550:7 [INFO] [stdout] | [INFO] [stdout] 549 | opts.open(&file_path).map_err(From::from).and_then(|mut f| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 550 | replay(&mut f, opt.external_magic_version, opt.read_only).map(|m| Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest.rs:550:69 [INFO] [stdout] | [INFO] [stdout] 549 | opts.open(&file_path).map_err(From::from).and_then(|mut f| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 550 | replay(&mut f, opt.external_magic_version, opt.read_only).map(|m| Self { [INFO] [stdout] | _____________________________________________________________________^ [INFO] [stdout] 551 | | opts: opt, [INFO] [stdout] 552 | | inner: Arc::new(Mutex::new(ManifestFileInner { [INFO] [stdout] 553 | | manifest: m, [INFO] [stdout] 554 | | wal: MaybeUninit::new(f), [INFO] [stdout] 555 | | })), [INFO] [stdout] 556 | | }) [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest.rs:552:16 [INFO] [stdout] | [INFO] [stdout] 549 | opts.open(&file_path).map_err(From::from).and_then(|mut f| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 550 | replay(&mut f, opt.external_magic_version, opt.read_only).map(|m| Self { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 551 | opts: opt, [INFO] [stdout] 552 | inner: Arc::new(Mutex::new(ManifestFileInner { [INFO] [stdout] | ________________^ [INFO] [stdout] 553 | | manifest: m, [INFO] [stdout] 554 | | wal: MaybeUninit::new(f), [INFO] [stdout] 555 | | })), [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `roreo-common` (lib) due to 11 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "736c55519442308014310312f9480d0d2675df2cfef04a9aab38e4b9bc501a2d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "736c55519442308014310312f9480d0d2675df2cfef04a9aab38e4b9bc501a2d", kill_on_drop: false }` [INFO] [stdout] 736c55519442308014310312f9480d0d2675df2cfef04a9aab38e4b9bc501a2d