[INFO] fetching crate ropenttd 0.0.2... [INFO] checking ropenttd-0.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ropenttd 0.0.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate ropenttd 0.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ropenttd 0.0.2 [INFO] finished tweaking crates.io crate ropenttd 0.0.2 [INFO] tweaked toml for crates.io crate ropenttd 0.0.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate ropenttd 0.0.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e8ff3662b2c010ae01cadab8f38d528f2d83d414bf982c2ae1246866be3139fd [INFO] running `Command { std: "docker" "start" "-a" "e8ff3662b2c010ae01cadab8f38d528f2d83d414bf982c2ae1246866be3139fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e8ff3662b2c010ae01cadab8f38d528f2d83d414bf982c2ae1246866be3139fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e8ff3662b2c010ae01cadab8f38d528f2d83d414bf982c2ae1246866be3139fd", kill_on_drop: false }` [INFO] [stdout] e8ff3662b2c010ae01cadab8f38d528f2d83d414bf982c2ae1246866be3139fd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6294e9a03a651b4752e8c7ccc5ea412e649585839bb7174ae25c2da0e17cb7a7 [INFO] running `Command { std: "docker" "start" "-a" "6294e9a03a651b4752e8c7ccc5ea412e649585839bb7174ae25c2da0e17cb7a7", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking bytecount v0.6.7 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling convert_case v0.5.0 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking textwrap v0.16.0 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Checking papergrid v0.5.1 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling rust-lzma v0.5.1 [INFO] [stderr] Checking subslice v0.2.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling darling_core v0.13.4 [INFO] [stderr] Compiling clap_derive v3.2.25 [INFO] [stderr] Compiling tabled_derive v0.4.0 [INFO] [stderr] Checking tabled v0.8.0 [INFO] [stderr] Compiling darling_macro v0.13.4 [INFO] [stderr] Compiling darling v0.13.4 [INFO] [stderr] Compiling argopt-impl v0.3.0 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking argopt v0.3.0 [INFO] [stderr] Checking ropenttd v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/vehicle.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 64 | todo!("??"); [INFO] [stdout] | ----------- any code following this expression is unreachable [INFO] [stdout] 65 | [INFO] [stdout] 66 | / Ok(Self { [INFO] [stdout] 67 | | }) [INFO] [stdout] | |__________^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/string_reader.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct OpenString { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 16 | pub id: StringID, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chunk_reader.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 45 | let mut chunk = Bytes::copy_from_slice(&chunk); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | Ok(ChunkReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 58 | | raw: Mutex::new(chunk), [INFO] [stdout] 59 | | gamma, [INFO] [stdout] 60 | | tp, [INFO] [stdout] ... | [INFO] [stdout] 63 | | slice_idx [INFO] [stdout] 64 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chunk_reader.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn advance_slice(mut self) -> Result, Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Ok(Some(self)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ropenttd` (lib) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/vehicle.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 64 | todo!("??"); [INFO] [stdout] | ----------- any code following this expression is unreachable [INFO] [stdout] 65 | [INFO] [stdout] 66 | / Ok(Self { [INFO] [stdout] 67 | | }) [INFO] [stdout] | |__________^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `vehicle` [INFO] [stdout] --> src/vehicle.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | let vehicle = &vehicles.trains[0]; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_vehicle` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/string_reader.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct OpenString { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 16 | pub id: StringID, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chunk_reader.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 45 | let mut chunk = Bytes::copy_from_slice(&chunk); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | Ok(ChunkReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 58 | | raw: Mutex::new(chunk), [INFO] [stdout] 59 | | gamma, [INFO] [stdout] 60 | | tp, [INFO] [stdout] ... | [INFO] [stdout] 63 | | slice_idx [INFO] [stdout] 64 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chunk_reader.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn advance_slice(mut self) -> Result, Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Ok(Some(self)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ropenttd` (lib test) due to 3 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6294e9a03a651b4752e8c7ccc5ea412e649585839bb7174ae25c2da0e17cb7a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6294e9a03a651b4752e8c7ccc5ea412e649585839bb7174ae25c2da0e17cb7a7", kill_on_drop: false }` [INFO] [stdout] 6294e9a03a651b4752e8c7ccc5ea412e649585839bb7174ae25c2da0e17cb7a7