[INFO] fetching crate root1d 0.4.0... [INFO] checking root1d-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate root1d 0.4.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate root1d 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate root1d 0.4.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate root1d 0.4.0 [INFO] tweaked toml for crates.io crate root1d 0.4.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate root1d 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ab3c6e9bccfc321a49326a90ff6b37fcbaa372ea3fc0d34ac9906372ececcf04 [INFO] running `Command { std: "docker" "start" "-a" "ab3c6e9bccfc321a49326a90ff6b37fcbaa372ea3fc0d34ac9906372ececcf04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ab3c6e9bccfc321a49326a90ff6b37fcbaa372ea3fc0d34ac9906372ececcf04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ab3c6e9bccfc321a49326a90ff6b37fcbaa372ea3fc0d34ac9906372ececcf04", kill_on_drop: false }` [INFO] [stdout] ab3c6e9bccfc321a49326a90ff6b37fcbaa372ea3fc0d34ac9906372ececcf04 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 86dd87151d2a7d50aecb4f817b5d420966f46e59a54a7b3af46994a089a5e953 [INFO] running `Command { std: "docker" "start" "-a" "86dd87151d2a7d50aecb4f817b5d420966f46e59a54a7b3af46994a089a5e953", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking roots v0.0.7 [INFO] [stderr] Checking root1d v0.4.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 145 | fn eval_float_result(mut f: F, x: T) -> Result> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | f(x).to_result() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:184:5 [INFO] [stdout] | [INFO] [stdout] 177 | mut f: F, y: &mut T, x: &T [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | f(y, x).to_result() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:186:16 [INFO] [stdout] | [INFO] [stdout] 185 | .map_err(|err| Error::Fun { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | x: x.clone(), err }) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:383:25 [INFO] [stdout] | [INFO] [stdout] 379 | fn new(f: F, a: $(&$l)? T, b: $(&$l)? T) -> Self { [INFO] [stdout] | ---- ------------ ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 383 | t: T::DefaultTerminate::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 558 | / new_root_finding_method!( [INFO] [stdout] 559 | | bisect, [INFO] [stdout] 560 | | /// Bisection algorithm (for [`Copy`] types). [INFO] [stdout] 561 | | Bisect<...>,); [INFO] [stdout] | |_________________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `new_root_finding_method` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:383:25 [INFO] [stdout] | [INFO] [stdout] 379 | fn new(f: F, a: $(&$l)? T, b: $(&$l)? T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 383 | t: T::DefaultTerminate::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 748 | / new_root_finding_method! ( [INFO] [stdout] 749 | | bisect_mut, [INFO] [stdout] 750 | | /// Bisection algorithm (for non-[`Copy`] types). [INFO] [stdout] 751 | | BisectMut<'a,...>, [INFO] [stdout] 752 | | workspace, Option<&'a mut BisectMutWorkspace>, [INFO] [stdout] 753 | | owned_workspace, Option>); [INFO] [stdout] | |___________________________________________________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `new_root_finding_method` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:386:32 [INFO] [stdout] | [INFO] [stdout] 379 | fn new(f: F, a: $(&$l)? T, b: $(&$l)? T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 386 | $($field: None,)* // All extra fields are options [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 748 | / new_root_finding_method! ( [INFO] [stdout] 749 | | bisect_mut, [INFO] [stdout] 750 | | /// Bisection algorithm (for non-[`Copy`] types). [INFO] [stdout] 751 | | BisectMut<'a,...>, [INFO] [stdout] 752 | | workspace, Option<&'a mut BisectMutWorkspace>, [INFO] [stdout] 753 | | owned_workspace, Option>); [INFO] [stdout] | |___________________________________________________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `new_root_finding_method` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:919:9 [INFO] [stdout] | [INFO] [stdout] 918 | let mut root = self.a.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 919 | self.root_mut(&mut root).and(Ok(root)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:919:38 [INFO] [stdout] | [INFO] [stdout] 918 | let mut root = self.a.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 919 | self.root_mut(&mut root).and(Ok(root)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:383:25 [INFO] [stdout] | [INFO] [stdout] 379 | fn new(f: F, a: $(&$l)? T, b: $(&$l)? T) -> Self { [INFO] [stdout] | ---- ------------ ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 383 | t: T::DefaultTerminate::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1053 | / new_root_finding_method!( [INFO] [stdout] 1054 | | toms748, [INFO] [stdout] 1055 | | /// [`toms748`] algorithm (for [`Copy`] types). [INFO] [stdout] 1056 | | Toms748<...>, ); [INFO] [stdout] | |___________________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `new_root_finding_method` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:383:25 [INFO] [stdout] | [INFO] [stdout] 379 | fn new(f: F, a: $(&$l)? T, b: $(&$l)? T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 383 | t: T::DefaultTerminate::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1408 | / new_root_finding_method!( [INFO] [stdout] 1409 | | toms748_mut, [INFO] [stdout] 1410 | | /// [`toms748_mut`] algorithm (for non-[`Copy`] types). [INFO] [stdout] 1411 | | Toms748Mut<'a,...>, [INFO] [stdout] 1412 | | workspace, Option<&'a mut Toms748MutWorkspace>, [INFO] [stdout] 1413 | | owned_workspace, Option>); [INFO] [stdout] | |____________________________________________________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `new_root_finding_method` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:386:32 [INFO] [stdout] | [INFO] [stdout] 379 | fn new(f: F, a: $(&$l)? T, b: $(&$l)? T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 386 | $($field: None,)* // All extra fields are options [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 1408 | / new_root_finding_method!( [INFO] [stdout] 1409 | | toms748_mut, [INFO] [stdout] 1410 | | /// [`toms748_mut`] algorithm (for non-[`Copy`] types). [INFO] [stdout] 1411 | | Toms748Mut<'a,...>, [INFO] [stdout] 1412 | | workspace, Option<&'a mut Toms748MutWorkspace>, [INFO] [stdout] 1413 | | owned_workspace, Option>); [INFO] [stdout] | |____________________________________________________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `new_root_finding_method` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1469:9 [INFO] [stdout] | [INFO] [stdout] 1468 | let mut root = self.a.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1469 | self.root_mut(&mut root).and(Ok(root)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1469:38 [INFO] [stdout] | [INFO] [stdout] 1468 | let mut root = self.a.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1469 | self.root_mut(&mut root).and(Ok(root)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `root1d` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "86dd87151d2a7d50aecb4f817b5d420966f46e59a54a7b3af46994a089a5e953", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "86dd87151d2a7d50aecb4f817b5d420966f46e59a54a7b3af46994a089a5e953", kill_on_drop: false }` [INFO] [stdout] 86dd87151d2a7d50aecb4f817b5d420966f46e59a54a7b3af46994a089a5e953