[INFO] fetching crate ron-crdt 0.4.0... [INFO] checking ron-crdt-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ron-crdt 0.4.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate ron-crdt 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ron-crdt 0.4.0 [INFO] finished tweaking crates.io crate ron-crdt 0.4.0 [INFO] tweaked toml for crates.io crate ron-crdt 0.4.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 67 packages to latest compatible versions [INFO] [stderr] Adding autocfg v0.1.8 (latest: v1.3.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding env_logger v0.6.2 (latest: v0.11.5) [INFO] [stderr] Adding quickcheck v0.8.5 (latest: v1.0.3) [INFO] [stderr] Adding rand v0.6.5 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.1.0 (latest: v0.3.2) [INFO] [stderr] Adding rand_isaac v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rand_jitter v0.1.4 (latest: v0.4.0) [INFO] [stderr] Adding rand_os v0.1.3 (latest: v0.2.2) [INFO] [stderr] Adding rand_pcg v0.1.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_xorshift v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding simple_logger v0.5.0 (latest: v5.0.0) [INFO] [stderr] Adding smallvec v0.6.14 (latest: v1.13.2) [INFO] [stderr] Adding time v0.1.45 (latest: v0.3.36) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 920fa633f6b5eac6233c32d2f2afcbd799f07edf0c017178a4a447f6af42b08b [INFO] running `Command { std: "docker" "start" "-a" "920fa633f6b5eac6233c32d2f2afcbd799f07edf0c017178a4a447f6af42b08b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "920fa633f6b5eac6233c32d2f2afcbd799f07edf0c017178a4a447f6af42b08b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "920fa633f6b5eac6233c32d2f2afcbd799f07edf0c017178a4a447f6af42b08b", kill_on_drop: false }` [INFO] [stdout] 920fa633f6b5eac6233c32d2f2afcbd799f07edf0c017178a4a447f6af42b08b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1af92dcf39d795f65836a6777ccf7c6fd6c1c0f49d13e8931ce23ab70dd7712e [INFO] running `Command { std: "docker" "start" "-a" "1af92dcf39d795f65836a6777ccf7c6fd6c1c0f49d13e8931ce23ab70dd7712e", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking simple_logger v0.5.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.6.2 [INFO] [stderr] Checking quickcheck v0.8.5 [INFO] [stderr] Checking ron-uuid v0.4.0 [INFO] [stderr] Checking ron-crdt v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/batch.rs:127:10 [INFO] [stdout] | [INFO] [stdout] 127 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/batch.rs:50:57 [INFO] [stdout] | [INFO] [stdout] 50 | .or_insert_with(|| (ty.clone(), Default::default())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crdt/mod.rs:74:10 [INFO] [stdout] | [INFO] [stdout] 31 | fn merge<'a, F>(state: Frame<'a>, updates: Vec>) -> Option> [INFO] [stdout] | ---------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let mut heap = Heap::::new( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let mut out = vec![Op { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Some(Frame::compress(out)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crdt/lww.rs:60:33 [INFO] [stdout] | [INFO] [stdout] 56 | fn map<'a>(state: Frame<'a>) -> Option { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Some(HashMap::from_iter(state.filter_map(|mut op| { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 61 | | match op { [INFO] [stdout] 62 | | Op { term: Header, .. } | Op { term: Query, .. } => None, [INFO] [stdout] 63 | | Op { ref location, ref mut atoms, .. } [INFO] [stdout] ... | [INFO] [stdout] 69 | | } [INFO] [stdout] 70 | | }))) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crdt/set.rs:39:14 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn remove<'a>(state: Frame<'a>, value: &Atom) -> Option> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | Some(Frame::compress( [INFO] [stdout] | ______________^ [INFO] [stdout] 40 | | state [INFO] [stdout] 41 | | .filter_map(|op| { [INFO] [stdout] 42 | | let Op { ty, object, event, location, atoms, .. } = op; [INFO] [stdout] ... | [INFO] [stdout] 57 | | .collect::>(), [INFO] [stdout] 58 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crdt/set.rs:86:14 [INFO] [stdout] | [INFO] [stdout] 82 | fn map<'a>(state: Frame<'a>) -> Option { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Some(HashSet::from_iter(state.filter_map(|mut op| { [INFO] [stdout] | ______________^ [INFO] [stdout] 87 | | match op { [INFO] [stdout] 88 | | Op { term: Header, .. } | Op { term: Query, .. } => None, [INFO] [stdout] 89 | | Op { ref location, ref mut atoms, .. } [INFO] [stdout] ... | [INFO] [stdout] 95 | | } [INFO] [stdout] 96 | | }))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ron-crdt` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/batch.rs:127:10 [INFO] [stdout] | [INFO] [stdout] 127 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/batch.rs:50:57 [INFO] [stdout] | [INFO] [stdout] 50 | .or_insert_with(|| (ty.clone(), Default::default())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crdt/mod.rs:74:10 [INFO] [stdout] | [INFO] [stdout] 31 | fn merge<'a, F>(state: Frame<'a>, updates: Vec>) -> Option> [INFO] [stdout] | ---------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let mut heap = Heap::::new( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let mut out = vec![Op { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Some(Frame::compress(out)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crdt/lww.rs:60:33 [INFO] [stdout] | [INFO] [stdout] 56 | fn map<'a>(state: Frame<'a>) -> Option { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Some(HashMap::from_iter(state.filter_map(|mut op| { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 61 | | match op { [INFO] [stdout] 62 | | Op { term: Header, .. } | Op { term: Query, .. } => None, [INFO] [stdout] 63 | | Op { ref location, ref mut atoms, .. } [INFO] [stdout] ... | [INFO] [stdout] 69 | | } [INFO] [stdout] 70 | | }))) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crdt/set.rs:39:14 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn remove<'a>(state: Frame<'a>, value: &Atom) -> Option> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | Some(Frame::compress( [INFO] [stdout] | ______________^ [INFO] [stdout] 40 | | state [INFO] [stdout] 41 | | .filter_map(|op| { [INFO] [stdout] 42 | | let Op { ty, object, event, location, atoms, .. } = op; [INFO] [stdout] ... | [INFO] [stdout] 57 | | .collect::>(), [INFO] [stdout] 58 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crdt/set.rs:86:14 [INFO] [stdout] | [INFO] [stdout] 82 | fn map<'a>(state: Frame<'a>) -> Option { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Some(HashSet::from_iter(state.filter_map(|mut op| { [INFO] [stdout] | ______________^ [INFO] [stdout] 87 | | match op { [INFO] [stdout] 88 | | Op { term: Header, .. } | Op { term: Query, .. } => None, [INFO] [stdout] 89 | | Op { ref location, ref mut atoms, .. } [INFO] [stdout] ... | [INFO] [stdout] 95 | | } [INFO] [stdout] 96 | | }))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ron-crdt` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "1af92dcf39d795f65836a6777ccf7c6fd6c1c0f49d13e8931ce23ab70dd7712e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1af92dcf39d795f65836a6777ccf7c6fd6c1c0f49d13e8931ce23ab70dd7712e", kill_on_drop: false }` [INFO] [stdout] 1af92dcf39d795f65836a6777ccf7c6fd6c1c0f49d13e8931ce23ab70dd7712e