[INFO] fetching crate romulus 0.3.0... [INFO] checking romulus-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate romulus 0.3.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate romulus 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate romulus 0.3.0 [INFO] finished tweaking crates.io crate romulus 0.3.0 [INFO] tweaked toml for crates.io crate romulus 0.3.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate romulus 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eaebcb5e9a970aeb38785744321feb83d9c4ddb86e937eaaa87c0b713fd4f650 [INFO] running `Command { std: "docker" "start" "-a" "eaebcb5e9a970aeb38785744321feb83d9c4ddb86e937eaaa87c0b713fd4f650", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eaebcb5e9a970aeb38785744321feb83d9c4ddb86e937eaaa87c0b713fd4f650", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eaebcb5e9a970aeb38785744321feb83d9c4ddb86e937eaaa87c0b713fd4f650", kill_on_drop: false }` [INFO] [stdout] eaebcb5e9a970aeb38785744321feb83d9c4ddb86e937eaaa87c0b713fd4f650 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5567f359cd5b3cd32f19bca164f3957417b5ce3fdb7243262a9fcd058a81f410 [INFO] running `Command { std: "docker" "start" "-a" "5567f359cd5b3cd32f19bca164f3957417b5ce3fdb7243262a9fcd058a81f410", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling getrandom v0.1.11 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling serde v1.0.99 [INFO] [stderr] Compiling arrayvec v0.4.11 [INFO] [stderr] Checking ppv-lite86 v0.2.5 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling ryu v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.2 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Compiling rayon-core v1.6.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Compiling syn v1.0.5 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking either v1.5.2 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking c2-chacha v0.2.2 [INFO] [stderr] Checking regex-syntax v0.6.11 [INFO] [stderr] Checking ansi_term v0.9.0 [INFO] [stderr] Checking same-file v1.0.5 [INFO] [stderr] Checking cast v0.2.2 [INFO] [stderr] Checking itertools v0.8.0 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking walkdir v2.2.9 [INFO] [stderr] Checking regex-automata v0.1.8 [INFO] [stderr] Compiling memoffset v0.5.1 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking crossbeam-epoch v0.7.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking crossbeam-deque v0.7.1 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking csv-core v0.1.6 [INFO] [stderr] Checking criterion-plot v0.4.0 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand_os v0.2.2 [INFO] [stderr] Checking rand_xoshiro v0.3.1 [INFO] [stderr] Checking rand v0.7.0 [INFO] [stderr] Checking rayon v1.2.0 [INFO] [stderr] Checking regex v1.2.1 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking romulus v0.3.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling serde_derive v1.0.99 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter.rs:143:12 [INFO] [stdout] | [INFO] [stdout] 103 | let node = match (&self.filename, &self.expression) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let mut file = match File::open(file) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | Ok(f) => f, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | if let Err(err) = file.read_to_string(&mut buf) { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let sep = self [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | Ok(Interpreter { [INFO] [stdout] | ____________^ [INFO] [stdout] 144 | | node, [INFO] [stdout] 145 | | sep, [INFO] [stdout] 146 | | implicit_print, [INFO] [stdout] 147 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter.rs:139:32 [INFO] [stdout] | [INFO] [stdout] 139 | .unwrap_or_else(|| Regex::new(" +").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/parse/mod.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 44 | let mut subnodes = Vec::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | Ok((Seq { subnodes, toplevel }, pos)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/parse/mod.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 58 | let mut subnodes = Vec::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Ok((Seq { subnodes, toplevel }, pos)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/parse/mod.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 72 | let sel = match Selector::parse_mut(&tokens, &mut pos) { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Ok(sel) => sel, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | Err(_) => { [INFO] [stdout] 75 | let (node, next) = Statement::parse(&tokens, pos)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 89 | | Body::Guard( [INFO] [stdout] 90 | | sel, [INFO] [stdout] 91 | | Seq { [INFO] [stdout] ... | [INFO] [stdout] 96 | | pos, [INFO] [stdout] 97 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/parse/mod.rs:216:12 [INFO] [stdout] | [INFO] [stdout] 199 | let mut patterns = Vec::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | Ok((PatternMatch { patterns }, cur + 1)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/parse/mod.rs:284:12 [INFO] [stdout] | [INFO] [stdout] 271 | let start_match = Match::parse_mut(&tokens, &mut pos)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 282 | let end_match = Match::parse_mut(&tokens, &mut pos)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 283 | [INFO] [stdout] 284 | Ok((Range(start_match, end_match), pos)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/parse/mod.rs:400:12 [INFO] [stdout] | [INFO] [stdout] 300 | let (statement, end_pos) = match &id[..] { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | let regex = match tokens.get(param_pos) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 333 | let regex = match tokens.get(param_pos) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 400 | Ok((statement, if parens { end_pos + 1 } else { end_pos })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `romulus` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "5567f359cd5b3cd32f19bca164f3957417b5ce3fdb7243262a9fcd058a81f410", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5567f359cd5b3cd32f19bca164f3957417b5ce3fdb7243262a9fcd058a81f410", kill_on_drop: false }` [INFO] [stdout] 5567f359cd5b3cd32f19bca164f3957417b5ce3fdb7243262a9fcd058a81f410