[INFO] fetching crate romp 0.5.2... [INFO] checking romp-0.5.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate romp 0.5.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate romp 0.5.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate romp 0.5.2 [INFO] finished tweaking crates.io crate romp 0.5.2 [INFO] tweaked toml for crates.io crate romp 0.5.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate romp 0.5.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e6175804322f67b450d17aaa8d6b801163f81dad492222128e7ffac26724cec5 [INFO] running `Command { std: "docker" "start" "-a" "e6175804322f67b450d17aaa8d6b801163f81dad492222128e7ffac26724cec5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e6175804322f67b450d17aaa8d6b801163f81dad492222128e7ffac26724cec5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e6175804322f67b450d17aaa8d6b801163f81dad492222128e7ffac26724cec5", kill_on_drop: false }` [INFO] [stdout] e6175804322f67b450d17aaa8d6b801163f81dad492222128e7ffac26724cec5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aac2ff50456955de3f679fad879857b9ce66dbc8228837b6e2c03f3560d856cf [INFO] running `Command { std: "docker" "start" "-a" "aac2ff50456955de3f679fad879857b9ce66dbc8228837b6e2c03f3560d856cf", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking futures v0.1.29 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking smallvec v0.6.13 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking lock_api v0.3.3 [INFO] [stderr] Compiling typenum v1.11.2 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking num_cpus v1.12.0 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Compiling proc-macro2 v1.0.8 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Checking tokio-executor v0.1.9 [INFO] [stderr] Checking tokio-sync v0.1.7 [INFO] [stderr] Compiling syn v1.0.14 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Checking linked-hash-map v0.5.2 [INFO] [stderr] Checking traitobject v0.1.0 [INFO] [stderr] Checking arc-swap v0.4.4 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Checking yaml-rust v0.4.3 [INFO] [stderr] Checking generic-array v0.12.3 [INFO] [stderr] Checking block-padding v0.1.5 [INFO] [stderr] Checking signal-hook-registry v1.2.0 [INFO] [stderr] Checking miniz_oxide v0.3.5 [INFO] [stderr] Checking unsafe-any v0.4.2 [INFO] [stderr] Checking owning_ref v0.3.3 [INFO] [stderr] Checking ordered-float v1.0.2 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Checking dtoa v0.4.4 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking parking_lot v0.4.8 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking block-buffer v0.7.3 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Checking typemap v0.3.3 [INFO] [stderr] Checking signal-hook v0.1.13 [INFO] [stderr] Checking chrono v0.4.10 [INFO] [stderr] Checking flate2 v1.0.13 [INFO] [stderr] Checking tokio-timer v0.2.12 [INFO] [stderr] Checking tokio-current-thread v0.1.6 [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Checking opaque-debug v0.2.3 [INFO] [stderr] Checking arc-swap v0.3.11 [INFO] [stderr] Checking antidote v1.0.0 [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Checking sha2 v0.8.1 [INFO] [stderr] Checking chashmap v2.2.2 [INFO] [stderr] Checking base64 v0.11.0 [INFO] [stderr] Checking sha1 v0.6.0 [INFO] [stderr] Checking sanename v0.1.1 [INFO] [stderr] Checking totems v0.2.7 [INFO] [stderr] Checking base16 v0.2.1 [INFO] [stderr] Checking serde-value v0.5.3 [INFO] [stderr] Checking serde_json v1.0.45 [INFO] [stderr] Checking serde_yaml v0.8.11 [INFO] [stderr] Checking toml v0.5.6 [INFO] [stderr] Checking tokio-io v0.1.12 [INFO] [stderr] Checking mio v0.6.21 [INFO] [stderr] Checking tokio-threadpool v0.1.17 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.6 [INFO] [stderr] Checking tokio-reactor v0.1.11 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-udp v0.1.5 [INFO] [stderr] Checking tokio-signal v0.2.7 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking log4rs v0.8.3 [INFO] [stderr] Checking romp v0.5.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/workflow/filter/http.rs:45:29 [INFO] [stdout] | [INFO] [stdout] 45 | ... /// All HTTP errors are fatal [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 46 | ... fatal: true [INFO] [stdout] | ----------- rustdoc does not generate documentation for expression fields [INFO] [stdout] | [INFO] [stdout] = help: use `//` for a plain comment [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/workflow/filter/http.rs:45:29 [INFO] [stdout] | [INFO] [stdout] 45 | ... /// All HTTP errors are fatal [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 46 | ... fatal: true [INFO] [stdout] | ----------- rustdoc does not generate documentation for expression fields [INFO] [stdout] | [INFO] [stdout] = help: use `//` for a plain comment [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/session/reader.rs:183:13 [INFO] [stdout] | [INFO] [stdout] 183 | let mut message = self.parser.take_message(Ownership::Session); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/session/reader.rs:183:13 [INFO] [stdout] | [INFO] [stdout] 183 | let mut message = self.parser.take_message(Ownership::Session); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `session_id` is never read [INFO] [stdout] --> src/session/reader.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 32 | pub struct Reader { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 33 | session: Arc>, [INFO] [stdout] 34 | session_id: usize, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap.rs:66:21 [INFO] [stdout] | [INFO] [stdout] 55 | let dest_clone = destination.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | dest_clone.write().unwrap().timeout_messages() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap.rs:112:29 [INFO] [stdout] | [INFO] [stdout] 109 | let timeout_session = session.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | timeout_session.write().unwrap().timeout() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/downstream.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 86 | let timeout_session = session.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | timeout_session.write().unwrap().timeout() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `session_id` is never read [INFO] [stdout] --> src/session/reader.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 32 | pub struct Reader { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 33 | session: Arc>, [INFO] [stdout] 34 | session_id: usize, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap.rs:66:21 [INFO] [stdout] | [INFO] [stdout] 55 | let dest_clone = destination.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | dest_clone.write().unwrap().timeout_messages() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap.rs:112:29 [INFO] [stdout] | [INFO] [stdout] 109 | let timeout_session = session.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | timeout_session.write().unwrap().timeout() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/downstream.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 86 | let timeout_session = session.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | timeout_session.write().unwrap().timeout() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/message/serializer.rs:83:21 [INFO] [stdout] | [INFO] [stdout] 83 | drop(message); [INFO] [stdout] | ^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mq::SessionMessage` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 83 - drop(message); [INFO] [stdout] 83 + let _ = message; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/message/serializer.rs:83:21 [INFO] [stdout] | [INFO] [stdout] 83 | drop(message); [INFO] [stdout] | ^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&SessionMessage` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 83 - drop(message); [INFO] [stdout] 83 + let _ = message; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/interruptible_interval.rs:32:47 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(session: Arc>) -> InterruptibleInterval { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | [INFO] [stdout] 32 | InterruptibleInterval::new_with_delay(Delay::new(Instant::now()), session) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/reader.rs:61:18 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn new(session: Arc>, session_id: usize, read_half: ReadHalf) -> Reader { [INFO] [stdout] | ---------------------------------- ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | buf: vec![0 as u8; CONFIG.request_client_buffer].into_boxed_slice(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/reader.rs:67:28 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn new(session: Arc>, session_id: usize, read_half: ReadHalf) -> Reader { [INFO] [stdout] | ---------------------------------- ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | frame_lengths: Box::new(vec![]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/interruptible_interval.rs:32:47 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(session: Arc>) -> InterruptibleInterval { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | [INFO] [stdout] 32 | InterruptibleInterval::new_with_delay(Delay::new(Instant::now()), session) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/reader.rs:69:21 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn new(session: Arc>, session_id: usize, read_half: ReadHalf) -> Reader { [INFO] [stdout] | ---------------------------------- ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | parser: StompParser::new(session_id), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/reader.rs:61:18 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn new(session: Arc>, session_id: usize, read_half: ReadHalf) -> Reader { [INFO] [stdout] | ---------------------------------- ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | buf: vec![0 as u8; CONFIG.request_client_buffer].into_boxed_slice(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/reader.rs:67:28 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn new(session: Arc>, session_id: usize, read_half: ReadHalf) -> Reader { [INFO] [stdout] | ---------------------------------- ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | frame_lengths: Box::new(vec![]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/stomp_session.rs:141:13 [INFO] [stdout] | [INFO] [stdout] 122 | pub(crate) fn split(&mut self, sock: TcpStream, session: Arc>) -> (Reader, Writer) { [INFO] [stdout] | --------------- ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let (read_half, write_half) = sock.split(); [INFO] [stdout] | --------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | [INFO] [stdout] 136 | let write_half_lock = Arc::new(RwLock::new(write_half)); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | Reader::new(session.clone(), self.id(), read_half), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/reader.rs:69:21 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn new(session: Arc>, session_id: usize, read_half: ReadHalf) -> Reader { [INFO] [stdout] | ---------------------------------- ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | parser: StompParser::new(session_id), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/stomp_session.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 122 | pub(crate) fn split(&mut self, sock: TcpStream, session: Arc>) -> (Reader, Writer) { [INFO] [stdout] | --------------- ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let (read_half, write_half) = sock.split(); [INFO] [stdout] | --------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | [INFO] [stdout] 136 | let write_half_lock = Arc::new(RwLock::new(write_half)); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | Writer::new(session.clone(), self.id(), write_half_lock) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/stomp_session.rs:141:13 [INFO] [stdout] | [INFO] [stdout] 122 | pub(crate) fn split(&mut self, sock: TcpStream, session: Arc>) -> (Reader, Writer) { [INFO] [stdout] | --------------- ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let (read_half, write_half) = sock.split(); [INFO] [stdout] | --------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | [INFO] [stdout] 136 | let write_half_lock = Arc::new(RwLock::new(write_half)); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | Reader::new(session.clone(), self.id(), read_half), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/stomp_session.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 122 | pub(crate) fn split(&mut self, sock: TcpStream, session: Arc>) -> (Reader, Writer) { [INFO] [stdout] | --------------- ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let (read_half, write_half) = sock.split(); [INFO] [stdout] | --------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | [INFO] [stdout] 136 | let write_half_lock = Arc::new(RwLock::new(write_half)); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | Writer::new(session.clone(), self.id(), write_half_lock) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/writer.rs:42:18 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(session: Arc>, session_id: usize, write_half: Arc>>) -> Writer { [INFO] [stdout] | ---------------------------------- --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | out: vec![0 as u8; CONFIG.response_client_buffer].into_boxed_slice(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/writer.rs:44:25 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(session: Arc>, session_id: usize, write_half: Arc>>) -> Writer { [INFO] [stdout] | ---------------------------------- --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | serializer: MessageSerializer::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/writer.rs:60:15 [INFO] [stdout] | [INFO] [stdout] 59 | let session = self.session.read().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | match session.pop() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/writer.rs:42:18 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(session: Arc>, session_id: usize, write_half: Arc>>) -> Writer { [INFO] [stdout] | ---------------------------------- --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | out: vec![0 as u8; CONFIG.response_client_buffer].into_boxed_slice(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/writer.rs:44:25 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(session: Arc>, session_id: usize, write_half: Arc>>) -> Writer { [INFO] [stdout] | ---------------------------------- --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | serializer: MessageSerializer::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/writer.rs:60:15 [INFO] [stdout] | [INFO] [stdout] 59 | let session = self.session.read().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | match session.pop() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workflow/filter/persist.rs:44:23 [INFO] [stdout] | [INFO] [stdout] 38 | let session = context.session.read().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | match self.mlog.store(user_str, message) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workflow/filter/persist.rs:44:23 [INFO] [stdout] | [INFO] [stdout] 38 | let session = context.session.read().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | match self.mlog.store(user_str, message) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::string::String::split_off` that must be used [INFO] [stdout] --> src/workflow/filter/echo.rs:41:29 [INFO] [stdout] | [INFO] [stdout] 41 | ... reply_destination.split_off(destination_name.len() - 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: use `.truncate()` if you don't need the other half [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 41 | let _ = reply_destination.split_off(destination_name.len() - 3); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::string::String::split_off` that must be used [INFO] [stdout] --> src/workflow/filter/resend.rs:40:29 [INFO] [stdout] | [INFO] [stdout] 40 | ... reply_destination.split_off(destination_name.len() - 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: use `.truncate()` if you don't need the other half [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 40 | let _ = reply_destination.split_off(destination_name.len() - 3); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::string::String::split_off` that must be used [INFO] [stdout] --> src/workflow/filter/echo.rs:41:29 [INFO] [stdout] | [INFO] [stdout] 41 | ... reply_destination.split_off(destination_name.len() - 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: use `.truncate()` if you don't need the other half [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 41 | let _ = reply_destination.split_off(destination_name.len() - 3); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::string::String::split_off` that must be used [INFO] [stdout] --> src/workflow/filter/resend.rs:40:29 [INFO] [stdout] | [INFO] [stdout] 40 | ... reply_destination.split_off(destination_name.len() - 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: use `.truncate()` if you don't need the other half [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 40 | let _ = reply_destination.split_off(destination_name.len() - 3); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `romp` (lib) due to 14 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `romp` (lib test) due to 14 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "aac2ff50456955de3f679fad879857b9ce66dbc8228837b6e2c03f3560d856cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aac2ff50456955de3f679fad879857b9ce66dbc8228837b6e2c03f3560d856cf", kill_on_drop: false }` [INFO] [stdout] aac2ff50456955de3f679fad879857b9ce66dbc8228837b6e2c03f3560d856cf