[INFO] fetching crate roma 0.1.0... [INFO] checking roma-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate roma 0.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate roma 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate roma 0.1.0 [INFO] finished tweaking crates.io crate roma 0.1.0 [INFO] tweaked toml for crates.io crate roma 0.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate roma 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3acb5b640b5a98fae759c7f7db6cef368da717d3234aec73ff534a855b0bf7e5 [INFO] running `Command { std: "docker" "start" "-a" "3acb5b640b5a98fae759c7f7db6cef368da717d3234aec73ff534a855b0bf7e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3acb5b640b5a98fae759c7f7db6cef368da717d3234aec73ff534a855b0bf7e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3acb5b640b5a98fae759c7f7db6cef368da717d3234aec73ff534a855b0bf7e5", kill_on_drop: false }` [INFO] [stdout] 3acb5b640b5a98fae759c7f7db6cef368da717d3234aec73ff534a855b0bf7e5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3b3e9931b6bfd483924316eb3304d5071c119e1ca1a3ed7dac58a1d47164de61 [INFO] running `Command { std: "docker" "start" "-a" "3b3e9931b6bfd483924316eb3304d5071c119e1ca1a3ed7dac58a1d47164de61", kill_on_drop: false }` [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking bstr v0.2.12 [INFO] [stderr] Checking roma v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `B` [INFO] [stdout] --> src/lib.rs:3:38 [INFO] [stdout] | [INFO] [stdout] 3 | use bstr::{BStr, BString, ByteSlice, B}; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `B` [INFO] [stdout] --> src/lib.rs:3:38 [INFO] [stdout] | [INFO] [stdout] 3 | use bstr::{BStr, BString, ByteSlice, B}; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `path` [INFO] [stdout] --> src/lib.rs:280:38 [INFO] [stdout] | [INFO] [stdout] 280 | Self::UnmatchedBrace(ref path) => write!(f, ""), [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_path` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:298:13 [INFO] [stdout] | [INFO] [stdout] 298 | let mut full = path; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:300:13 [INFO] [stdout] | [INFO] [stdout] 300 | let mut node = match self.inner.as_mut() { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:317:25 [INFO] [stdout] | [INFO] [stdout] 317 | let mut prefix = &path[..bs]; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Node` is never used [INFO] [stdout] --> src/lib.rs:151:6 [INFO] [stdout] | [INFO] [stdout] 151 | enum Node { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:103:42 [INFO] [stdout] | [INFO] [stdout] 101 | fn from_path>(path: U) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let path = path.as_ref().replace("{{", "{").replace("}}", "}"); [INFO] [stdout] 103 | Self { path: path.into(), nodes: Nodes::default(), data: None, params: None } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:103:66 [INFO] [stdout] | [INFO] [stdout] 101 | fn from_path>(path: U) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let path = path.as_ref().replace("{{", "{").replace("}}", "}"); [INFO] [stdout] 103 | Self { path: path.into(), nodes: Nodes::default(), data: None, params: None } [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `path` [INFO] [stdout] --> src/lib.rs:280:38 [INFO] [stdout] | [INFO] [stdout] 280 | Self::UnmatchedBrace(ref path) => write!(f, ""), [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_path` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:298:13 [INFO] [stdout] | [INFO] [stdout] 298 | let mut full = path; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `roma` (lib test) due to 3 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:300:13 [INFO] [stdout] | [INFO] [stdout] 300 | let mut node = match self.inner.as_mut() { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:317:25 [INFO] [stdout] | [INFO] [stdout] 317 | let mut prefix = &path[..bs]; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Node` is never used [INFO] [stdout] --> src/lib.rs:151:6 [INFO] [stdout] | [INFO] [stdout] 151 | enum Node { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:103:42 [INFO] [stdout] | [INFO] [stdout] 101 | fn from_path>(path: U) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let path = path.as_ref().replace("{{", "{").replace("}}", "}"); [INFO] [stdout] 103 | Self { path: path.into(), nodes: Nodes::default(), data: None, params: None } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:103:66 [INFO] [stdout] | [INFO] [stdout] 101 | fn from_path>(path: U) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let path = path.as_ref().replace("{{", "{").replace("}}", "}"); [INFO] [stdout] 103 | Self { path: path.into(), nodes: Nodes::default(), data: None, params: None } [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `roma` (lib) due to 3 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3b3e9931b6bfd483924316eb3304d5071c119e1ca1a3ed7dac58a1d47164de61", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b3e9931b6bfd483924316eb3304d5071c119e1ca1a3ed7dac58a1d47164de61", kill_on_drop: false }` [INFO] [stdout] 3b3e9931b6bfd483924316eb3304d5071c119e1ca1a3ed7dac58a1d47164de61