[INFO] fetching crate roles_logic_sv2 1.2.1... [INFO] checking roles_logic_sv2-1.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate roles_logic_sv2 1.2.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate roles_logic_sv2 1.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate roles_logic_sv2 1.2.1 [INFO] finished tweaking crates.io crate roles_logic_sv2 1.2.1 [INFO] tweaked toml for crates.io crate roles_logic_sv2 1.2.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 81 packages to latest compatible versions [INFO] [stderr] Adding bech32 v0.9.1 (latest: v0.11.0) [INFO] [stderr] Adding bitcoin v0.29.2 (latest: v0.32.2) [INFO] [stderr] Adding bitcoin-internals v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding bitcoin_hashes v0.11.0 (latest: v0.14.0) [INFO] [stderr] Adding bitcoin_hashes v0.13.0 (latest: v0.14.0) [INFO] [stderr] Adding const_sv2 v1.0.0 (latest: v2.0.0) [INFO] [stderr] Adding env_logger v0.8.4 (latest: v0.11.5) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hex-conservative v0.1.2 (latest: v0.2.1) [INFO] [stderr] Adding secp256k1 v0.24.3 (latest: v0.29.0) [INFO] [stderr] Adding secp256k1 v0.28.2 (latest: v0.29.0) [INFO] [stderr] Adding secp256k1-sys v0.6.1 (latest: v0.10.0) [INFO] [stderr] Adding secp256k1-sys v0.9.2 (latest: v0.10.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b6ecaf5015e5fdbe9980b7ff00b5c44d934e7321580a8eb6766666c4f4a2e034 [INFO] running `Command { std: "docker" "start" "-a" "b6ecaf5015e5fdbe9980b7ff00b5c44d934e7321580a8eb6766666c4f4a2e034", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b6ecaf5015e5fdbe9980b7ff00b5c44d934e7321580a8eb6766666c4f4a2e034", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b6ecaf5015e5fdbe9980b7ff00b5c44d934e7321580a8eb6766666c4f4a2e034", kill_on_drop: false }` [INFO] [stdout] b6ecaf5015e5fdbe9980b7ff00b5c44d934e7321580a8eb6766666c4f4a2e034 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5231d4e43b46e1cfcd186531921e19c864207bb539d1bcdfdb94ea8be5642d14 [INFO] running `Command { std: "docker" "start" "-a" "5231d4e43b46e1cfcd186531921e19c864207bb539d1bcdfdb94ea8be5642d14", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling bitcoin-internals v0.2.0 [INFO] [stderr] Checking hex-conservative v0.1.2 [INFO] [stderr] Compiling binary_codec_sv2 v1.2.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking bitcoin_hashes v0.11.0 [INFO] [stderr] Compiling secp256k1-sys v0.9.2 [INFO] [stderr] Compiling secp256k1-sys v0.6.1 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking siphasher v1.0.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Checking bitcoin_hashes v0.13.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling derive_codec_sv2 v1.1.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking binary_sv2 v1.2.0 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Compiling quickcheck_macros v1.0.0 [INFO] [stderr] Checking secp256k1 v0.28.2 [INFO] [stderr] Checking secp256k1 v0.24.3 [INFO] [stderr] Checking bitcoin v0.29.2 [INFO] [stderr] Checking const_sv2 v2.0.0 [INFO] [stderr] Checking const_sv2 v1.0.0 [INFO] [stderr] Checking job_declaration_sv2 v1.0.0 [INFO] [stderr] Checking mining_sv2 v1.0.0 [INFO] [stderr] Checking common_messages_sv2 v2.0.0 [INFO] [stderr] Checking framing_sv2 v2.0.0 [INFO] [stderr] Checking template_distribution_sv2 v1.0.2 [INFO] [stderr] Checking stratum-common v1.0.0 [INFO] [stderr] Checking roles_logic_sv2 v1.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/utils.rs:662:12 [INFO] [stdout] | [INFO] [stdout] 662 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::too_many_arguments))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `disable_nopanic`, `prop_test`, `serde`, and `with_serde` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/job_dispatcher.rs:500:13 [INFO] [stdout] | [INFO] [stdout] 500 | /// Channel identification. [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 501 | channel_id: standard_channel_id, [INFO] [stdout] | ------------------------------- rustdoc does not generate documentation for expression fields [INFO] [stdout] | [INFO] [stdout] = help: use `//` for a plain comment [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/job_dispatcher.rs:502:13 [INFO] [stdout] | [INFO] [stdout] 502 | /// Unique sequential identifier of the submit within the channel. [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 503 | sequence_number: 0, [INFO] [stdout] | ------------------ rustdoc does not generate documentation for expression fields [INFO] [stdout] | [INFO] [stdout] = help: use `//` for a plain comment [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/job_dispatcher.rs:504:13 [INFO] [stdout] | [INFO] [stdout] 504 | / /// Identifier of the job as provided by *NewMiningJob* or [INFO] [stdout] 505 | | /// *NewExtendedMiningJob* message. [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] 506 | job_id, [INFO] [stdout] | ------ rustdoc does not generate documentation for expression fields [INFO] [stdout] | [INFO] [stdout] = help: use `//` for a plain comment [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/job_dispatcher.rs:507:13 [INFO] [stdout] | [INFO] [stdout] 507 | /// Nonce leading to the hash being submitted. [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 508 | nonce: 1, [INFO] [stdout] | -------- rustdoc does not generate documentation for expression fields [INFO] [stdout] | [INFO] [stdout] = help: use `//` for a plain comment [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/job_dispatcher.rs:509:13 [INFO] [stdout] | [INFO] [stdout] 509 | / /// The nTime field in the block header. This MUST be greater than or equal [INFO] [stdout] 510 | | /// to the header_timestamp field in the latest SetNewPrevHash message [INFO] [stdout] 511 | | /// and lower than or equal to that value plus the number of seconds since [INFO] [stdout] 512 | | /// the receipt of that message. [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] 513 | ntime: 1, [INFO] [stdout] | -------- rustdoc does not generate documentation for expression fields [INFO] [stdout] | [INFO] [stdout] = help: use `//` for a plain comment [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/job_dispatcher.rs:514:13 [INFO] [stdout] | [INFO] [stdout] 514 | /// Full nVersion field. [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 515 | version: 1, [INFO] [stdout] | ---------- rustdoc does not generate documentation for expression fields [INFO] [stdout] | [INFO] [stdout] = help: use `//` for a plain comment [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/utils.rs:662:12 [INFO] [stdout] | [INFO] [stdout] 662 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::too_many_arguments))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `disable_nopanic`, `prop_test`, `serde`, and `with_serde` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ExtendedJobs` is never constructed [INFO] [stdout] --> src/job_dispatcher.rs:95:8 [INFO] [stdout] | [INFO] [stdout] 95 | struct ExtendedJobs { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/common.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 34 | self_: Arc>, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | (message_type, payload).try_into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/common.rs:145:13 [INFO] [stdout] | [INFO] [stdout] 138 | self_: Arc>, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | (message_type, payload).try_into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/common.rs:173:73 [INFO] [stdout] | [INFO] [stdout] 169 | let result = r_logic [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | .safe_lock(|x| x.handle_setup_connection(m, Some(result))) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/common.rs:177:69 [INFO] [stdout] | [INFO] [stdout] 177 | .safe_lock(|x| x.handle_setup_connection(m, None)) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/job_declaration.rs:21:66 [INFO] [stdout] | [INFO] [stdout] 17 | self_: Arc>, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | Self::handle_message_job_declaration_deserialized(self_, (message_type, payload).try_into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/job_declaration.rs:127:66 [INFO] [stdout] | [INFO] [stdout] 123 | self_: Arc>, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | Self::handle_message_job_declaration_deserialized(self_, (message_type, payload).try_into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/mining.rs:56:15 [INFO] [stdout] | [INFO] [stdout] 48 | self_mutex: Arc>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | match Self::handle_message_mining_deserialized( [INFO] [stdout] | _______________^ [INFO] [stdout] 57 | | self_mutex, [INFO] [stdout] 58 | | (message_type, payload).try_into(), [INFO] [stdout] 59 | | routing_logic, [INFO] [stdout] 60 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/mining.rs:326:15 [INFO] [stdout] | [INFO] [stdout] 321 | self_mutex: Arc>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 326 | match Self::handle_message_mining_deserialized( [INFO] [stdout] | _______________^ [INFO] [stdout] 327 | | self_mutex, [INFO] [stdout] 328 | | (message_type, payload).try_into(), [INFO] [stdout] 329 | | routing_logic, [INFO] [stdout] 330 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/template_distribution.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 19 | self_: Arc>, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | (message_type, payload).try_into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/template_distribution.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 100 | self_: Arc>, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | (message_type, payload).try_into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/job_creator.rs:351:17 [INFO] [stdout] | [INFO] [stdout] 341 | let tx_in = TxIn { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 351 | output: coinbase_outputs.to_vec(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers.rs:1010:15 [INFO] [stdout] | [INFO] [stdout] 1008 | let is_common: Result = v.0.try_into(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1009 | let is_mining: Result = v.0.try_into(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1010 | match (is_common, is_mining) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers.rs:1110:15 [INFO] [stdout] | [INFO] [stdout] 1106 | let is_common: Result = v.0.try_into(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1107 | let is_mining: Result = v.0.try_into(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1108 | let is_job_declaration: Result = v.0.try_into(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1109 | let is_template_distribution: Result = v.0.try_into(); [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1110 | match ( [INFO] [stdout] | _______________^ [INFO] [stdout] 1111 | | is_common, [INFO] [stdout] 1112 | | is_mining, [INFO] [stdout] 1113 | | is_job_declaration, [INFO] [stdout] 1114 | | is_template_distribution, [INFO] [stdout] 1115 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routing_logic.rs:300:30 [INFO] [stdout] | [INFO] [stdout] 300 | |up_mutex| match up_mutex.safe_lock(|up| !up.is_header_only()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/selectors.rs:287:13 [INFO] [stdout] | [INFO] [stdout] 270 | let mut supported_upstreams = vec![]; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 287 | Err(Error::NoPairableUpstream((2, 2, 0))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:115:15 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn new(v: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | Mutex(Mutex_::new(v)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `roles_logic_sv2` (lib) due to 17 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `ExtendedJobs` is never constructed [INFO] [stdout] --> src/job_dispatcher.rs:95:8 [INFO] [stdout] | [INFO] [stdout] 95 | struct ExtendedJobs { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/common.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 34 | self_: Arc>, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | (message_type, payload).try_into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/common.rs:145:13 [INFO] [stdout] | [INFO] [stdout] 138 | self_: Arc>, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | (message_type, payload).try_into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/common.rs:173:73 [INFO] [stdout] | [INFO] [stdout] 169 | let result = r_logic [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | .safe_lock(|x| x.handle_setup_connection(m, Some(result))) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/common.rs:177:69 [INFO] [stdout] | [INFO] [stdout] 177 | .safe_lock(|x| x.handle_setup_connection(m, None)) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/job_declaration.rs:21:66 [INFO] [stdout] | [INFO] [stdout] 17 | self_: Arc>, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | Self::handle_message_job_declaration_deserialized(self_, (message_type, payload).try_into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/job_declaration.rs:127:66 [INFO] [stdout] | [INFO] [stdout] 123 | self_: Arc>, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | Self::handle_message_job_declaration_deserialized(self_, (message_type, payload).try_into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/mining.rs:56:15 [INFO] [stdout] | [INFO] [stdout] 48 | self_mutex: Arc>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | match Self::handle_message_mining_deserialized( [INFO] [stdout] | _______________^ [INFO] [stdout] 57 | | self_mutex, [INFO] [stdout] 58 | | (message_type, payload).try_into(), [INFO] [stdout] 59 | | routing_logic, [INFO] [stdout] 60 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/mining.rs:326:15 [INFO] [stdout] | [INFO] [stdout] 321 | self_mutex: Arc>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 326 | match Self::handle_message_mining_deserialized( [INFO] [stdout] | _______________^ [INFO] [stdout] 327 | | self_mutex, [INFO] [stdout] 328 | | (message_type, payload).try_into(), [INFO] [stdout] 329 | | routing_logic, [INFO] [stdout] 330 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/template_distribution.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 19 | self_: Arc>, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | (message_type, payload).try_into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/template_distribution.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 100 | self_: Arc>, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | (message_type, payload).try_into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/job_creator.rs:351:17 [INFO] [stdout] | [INFO] [stdout] 341 | let tx_in = TxIn { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 351 | output: coinbase_outputs.to_vec(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers.rs:1010:15 [INFO] [stdout] | [INFO] [stdout] 1008 | let is_common: Result = v.0.try_into(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1009 | let is_mining: Result = v.0.try_into(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1010 | match (is_common, is_mining) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers.rs:1110:15 [INFO] [stdout] | [INFO] [stdout] 1106 | let is_common: Result = v.0.try_into(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1107 | let is_mining: Result = v.0.try_into(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1108 | let is_job_declaration: Result = v.0.try_into(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1109 | let is_template_distribution: Result = v.0.try_into(); [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1110 | match ( [INFO] [stdout] | _______________^ [INFO] [stdout] 1111 | | is_common, [INFO] [stdout] 1112 | | is_mining, [INFO] [stdout] 1113 | | is_job_declaration, [INFO] [stdout] 1114 | | is_template_distribution, [INFO] [stdout] 1115 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routing_logic.rs:300:30 [INFO] [stdout] | [INFO] [stdout] 300 | |up_mutex| match up_mutex.safe_lock(|up| !up.is_header_only()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/selectors.rs:287:13 [INFO] [stdout] | [INFO] [stdout] 270 | let mut supported_upstreams = vec![]; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 287 | Err(Error::NoPairableUpstream((2, 2, 0))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:115:15 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn new(v: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | Mutex(Mutex_::new(v)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `roles_logic_sv2` (lib test) due to 17 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5231d4e43b46e1cfcd186531921e19c864207bb539d1bcdfdb94ea8be5642d14", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5231d4e43b46e1cfcd186531921e19c864207bb539d1bcdfdb94ea8be5642d14", kill_on_drop: false }` [INFO] [stdout] 5231d4e43b46e1cfcd186531921e19c864207bb539d1bcdfdb94ea8be5642d14