[INFO] fetching crate rokit 0.2.5... [INFO] checking rokit-0.2.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rokit 0.2.5 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate rokit 0.2.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-6-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate rokit 0.2.5 [INFO] finished tweaking crates.io crate rokit 0.2.5 [INFO] tweaked toml for crates.io crate rokit 0.2.5 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate rokit 0.2.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cef69cddd363efdd5513479840781d891beba42e312aad98cc4c73f86be35e8d [INFO] running `Command { std: "docker" "start" "-a" "cef69cddd363efdd5513479840781d891beba42e312aad98cc4c73f86be35e8d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cef69cddd363efdd5513479840781d891beba42e312aad98cc4c73f86be35e8d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cef69cddd363efdd5513479840781d891beba42e312aad98cc4c73f86be35e8d", kill_on_drop: false }` [INFO] [stdout] cef69cddd363efdd5513479840781d891beba42e312aad98cc4c73f86be35e8d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e20f2070be9711af1c48fd82084136fe90db1a6a8fa41c9fc2e6b80d9e0c0f82 [INFO] running `Command { std: "docker" "start" "-a" "e20f2070be9711af1c48fd82084136fe90db1a6a8fa41c9fc2e6b80d9e0c0f82", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.76 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking indexmap v2.4.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Compiling powerfmt v0.2.0 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Compiling deranged v0.3.11 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling adler2 v2.0.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling miniz_oxide v0.8.0 [INFO] [stderr] Compiling quick-xml v0.32.0 [INFO] [stderr] Compiling time v0.3.36 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling onig_sys v69.8.1 [INFO] [stderr] Compiling crc32fast v1.4.2 [INFO] [stderr] Checking brotli v6.0.0 [INFO] [stderr] Checking webpki-roots v0.26.3 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Compiling plist v1.7.0 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling bincode v1.3.3 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling flate2 v1.0.33 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Compiling heapless v0.7.17 [INFO] [stderr] Checking rustls-webpki v0.102.7 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Compiling pulldown-cmark v0.9.6 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking tokio v1.39.3 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling syntect v5.2.0 [INFO] [stderr] Compiling portable-atomic v1.7.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking async-compression v0.4.12 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking onig v6.4.0 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking polling v3.7.3 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Compiling scroll_derive v0.12.0 [INFO] [stderr] Compiling pulldown-cmark-mdcat v2.3.1 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling zip v2.2.0 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking lockfree-object-pool v0.1.6 [INFO] [stderr] Checking bumpalo v3.16.0 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking zopfli v0.8.1 [INFO] [stderr] Checking async-io v2.3.4 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking scroll v0.12.0 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking lzma-rs v0.3.0 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Compiling serde_with_macros v3.9.0 [INFO] [stderr] Checking retry-policies v0.4.0 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking gethostname v0.5.0 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking deflate64 v0.1.9 [INFO] [stderr] Checking cobs v0.2.3 [INFO] [stderr] Checking plain v0.2.3 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking matchit v0.8.4 [INFO] [stderr] Checking hyper-rustls v0.27.2 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking postcard v1.0.10 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking serde_with v3.9.0 [INFO] [stderr] Checking goblin v0.8.2 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking tar v0.4.41 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking which v6.0.3 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking async-signal v0.2.10 [INFO] [stderr] Checking dashmap v6.0.1 [INFO] [stderr] Checking reqwest-middleware v0.3.3 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking dunce v1.0.5 [INFO] [stderr] Checking unindent v0.2.3 [INFO] [stderr] Checking async-once-cell v0.5.3 [INFO] [stderr] Checking filepath v0.1.2 [INFO] [stderr] Checking reqwest-retry v0.6.1 [INFO] [stderr] Checking reqwest-tracing v0.5.3 [INFO] [stderr] Checking rokit v0.2.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/discovery/mod.rs:130:18 [INFO] [stdout] | [INFO] [stdout] 125 | let tools = match kind { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | Some(DiscoveredManifest { [INFO] [stdout] | __________________^ [INFO] [stdout] 131 | | _kind: kind, [INFO] [stdout] 132 | | path, [INFO] [stdout] 133 | | tools, [INFO] [stdout] 134 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/discovery/aftman.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 38 | fn into_tools(self) -> HashMap { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | / self.tools [INFO] [stdout] 40 | | .into_iter() [INFO] [stdout] 41 | | .map(|(alias, tool)| (alias.0, tool.0)) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/discovery/foreman.rs:48:71 [INFO] [stdout] | [INFO] [stdout] 48 | .and_then(|map| parse_foreman_tool_definition(SpecType::InlineTable(map))) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/discovery/foreman.rs:53:71 [INFO] [stdout] | [INFO] [stdout] 53 | .and_then(|map| parse_foreman_tool_definition(SpecType::Table(map))) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/discovery/foreman.rs:82:24 [INFO] [stdout] | [INFO] [stdout] 65 | fn parse_foreman_tool_definition(map: SpecType) -> Option { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let map = match map { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | SpecType::InlineTable(table) => table, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | SpecType::Table(table) => table.into_inline_table(), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | let version = map.get("version").and_then(|t| t.as_str()).and_then(|v| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | github_tool_id.map(|id| (id, version).into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/discovery/foreman.rs:82:29 [INFO] [stdout] | [INFO] [stdout] 71 | let version = map.get("version").and_then(|t| t.as_str()).and_then(|v| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | github_tool_id.map(|id| (id, version).into()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/discovery/rokit.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 26 | fn into_tools(self) -> HashMap { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | self.tool_specs().into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/manifests/auth.rs:187:12 [INFO] [stdout] | [INFO] [stdout] 161 | let document = s.parse::()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | Ok(Self { document }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/manifests/rokit.rs:171:22 [INFO] [stdout] | [INFO] [stdout] 170 | let spec = value.as_str()?.parse::().ok()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | Some((alias, spec)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/manifests/rokit.rs:245:12 [INFO] [stdout] | [INFO] [stdout] 180 | let mut document = s.parse::()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | Ok(Self { document }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/result.rs:45:29 [INFO] [stdout] | [INFO] [stdout] 44 | fn from(err: ExtractError) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | RokitError::Extract(err.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/result.rs:51:35 [INFO] [stdout] | [INFO] [stdout] 50 | fn from(err: JoinError) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | RokitError::TaskJoinError(err.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/result.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 62 | fn from(err: IoError) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | RokitError::Io(err.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/result.rs:69:26 [INFO] [stdout] | [INFO] [stdout] 68 | fn from(err: JsonError) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | RokitError::Json(Box::new(err)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/result.rs:81:25 [INFO] [stdout] | [INFO] [stdout] 80 | fn from(err: ZipError) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | RokitError::Zip(err.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/result.rs:87:28 [INFO] [stdout] | [INFO] [stdout] 86 | fn from(err: GithubError) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | RokitError::GitHub(err.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/sources/artifact/mod.rs:93:21 [INFO] [stdout] | [INFO] [stdout] 92 | let file_opt = file_res.map_err(|err| ExtractError::Generic { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | source: err.into(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/sources/artifact/mod.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 148 | pub fn find_partially_compatible_fallback(artifacts: impl AsRef<[Self]>) -> Option { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | / Self::sort_by_system_compatibility_inner(artifacts, true) [INFO] [stdout] 150 | | .into_iter() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/sources/artifact/sorting.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 70 | fn word_is_not_arch_or_os_or_version_or_numeric(word: impl AsRef) -> bool { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | && word.trim_start_matches('v').parse::().is_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/sources/client.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 18 | fn add_client_middleware(client: Client) -> ClientWithMiddleware { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | / ClientBuilder::new(client) [INFO] [stdout] 20 | | .with(RetryTransientMiddleware::new_with_policy( [INFO] [stdout] 21 | | ExponentialBackoff::builder().build_with_max_retries(3), [INFO] [stdout] 22 | | )) [INFO] [stdout] 23 | | .with(TracingMiddleware::default()) [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/sources/client.rs:55:8 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn create_client(mut default_headers: HeaderMap) -> Result { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let client = Client::builder() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | Ok(add_client_middleware(client)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/sources/source.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 32 | let github = GithubProvider::new()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | Ok(Self { github }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/sources/source.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 46 | let github = match auth.get(&ArtifactProvider::GitHub) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | Ok(Self { github }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/sources/github/mod.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 33 | let headers = { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let mut headers = HeaderMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let client = create_client(headers)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | [INFO] [stdout] 48 | Ok(Self { client, has_auth }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/sources/github/result.rs:36:40 [INFO] [stdout] | [INFO] [stdout] 35 | fn from(err: reqwest_middleware::Error) -> Self { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | GithubError::ReqwestMiddleware(err.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/sources/github/result.rs:42:30 [INFO] [stdout] | [INFO] [stdout] 41 | fn from(err: ReqwestError) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | GithubError::Reqwest(err.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/storage/tool_cache.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 151 | let sorted_set = self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | sorted_set.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/tool/id.rs:64:24 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn into_spec(self, version: Version) -> ToolSpec { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | ToolSpec::from((self, version)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/tool/spec.rs:112:12 [INFO] [stdout] | [INFO] [stdout] 100 | let version = match after.parse::() { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | Ok(version) => version, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | Ok(ToolSpec { id, version }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 29 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rokit` (lib) due to 30 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/discovery/mod.rs:130:18 [INFO] [stdout] | [INFO] [stdout] 125 | let tools = match kind { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | Some(DiscoveredManifest { [INFO] [stdout] | __________________^ [INFO] [stdout] 131 | | _kind: kind, [INFO] [stdout] 132 | | path, [INFO] [stdout] 133 | | tools, [INFO] [stdout] 134 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/discovery/aftman.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 38 | fn into_tools(self) -> HashMap { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | / self.tools [INFO] [stdout] 40 | | .into_iter() [INFO] [stdout] 41 | | .map(|(alias, tool)| (alias.0, tool.0)) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/discovery/foreman.rs:48:71 [INFO] [stdout] | [INFO] [stdout] 48 | .and_then(|map| parse_foreman_tool_definition(SpecType::InlineTable(map))) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/discovery/foreman.rs:53:71 [INFO] [stdout] | [INFO] [stdout] 53 | .and_then(|map| parse_foreman_tool_definition(SpecType::Table(map))) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/discovery/foreman.rs:82:24 [INFO] [stdout] | [INFO] [stdout] 65 | fn parse_foreman_tool_definition(map: SpecType) -> Option { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let map = match map { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | SpecType::InlineTable(table) => table, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | SpecType::Table(table) => table.into_inline_table(), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | let version = map.get("version").and_then(|t| t.as_str()).and_then(|v| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | github_tool_id.map(|id| (id, version).into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/discovery/foreman.rs:82:29 [INFO] [stdout] | [INFO] [stdout] 71 | let version = map.get("version").and_then(|t| t.as_str()).and_then(|v| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | github_tool_id.map(|id| (id, version).into()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/discovery/rokit.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 26 | fn into_tools(self) -> HashMap { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | self.tool_specs().into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/manifests/auth.rs:187:12 [INFO] [stdout] | [INFO] [stdout] 161 | let document = s.parse::()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | Ok(Self { document }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/manifests/rokit.rs:171:22 [INFO] [stdout] | [INFO] [stdout] 170 | let spec = value.as_str()?.parse::().ok()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | Some((alias, spec)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/manifests/rokit.rs:245:12 [INFO] [stdout] | [INFO] [stdout] 180 | let mut document = s.parse::()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | Ok(Self { document }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/result.rs:45:29 [INFO] [stdout] | [INFO] [stdout] 44 | fn from(err: ExtractError) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | RokitError::Extract(err.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/result.rs:51:35 [INFO] [stdout] | [INFO] [stdout] 50 | fn from(err: JoinError) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | RokitError::TaskJoinError(err.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/result.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 62 | fn from(err: IoError) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | RokitError::Io(err.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/result.rs:69:26 [INFO] [stdout] | [INFO] [stdout] 68 | fn from(err: JsonError) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | RokitError::Json(Box::new(err)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/result.rs:81:25 [INFO] [stdout] | [INFO] [stdout] 80 | fn from(err: ZipError) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | RokitError::Zip(err.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/result.rs:87:28 [INFO] [stdout] | [INFO] [stdout] 86 | fn from(err: GithubError) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | RokitError::GitHub(err.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/sources/artifact/mod.rs:93:21 [INFO] [stdout] | [INFO] [stdout] 92 | let file_opt = file_res.map_err(|err| ExtractError::Generic { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | source: err.into(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/sources/artifact/mod.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 148 | pub fn find_partially_compatible_fallback(artifacts: impl AsRef<[Self]>) -> Option { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | / Self::sort_by_system_compatibility_inner(artifacts, true) [INFO] [stdout] 150 | | .into_iter() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/sources/artifact/sorting.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 70 | fn word_is_not_arch_or_os_or_version_or_numeric(word: impl AsRef) -> bool { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | && word.trim_start_matches('v').parse::().is_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/sources/client.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 18 | fn add_client_middleware(client: Client) -> ClientWithMiddleware { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | / ClientBuilder::new(client) [INFO] [stdout] 20 | | .with(RetryTransientMiddleware::new_with_policy( [INFO] [stdout] 21 | | ExponentialBackoff::builder().build_with_max_retries(3), [INFO] [stdout] 22 | | )) [INFO] [stdout] 23 | | .with(TracingMiddleware::default()) [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/sources/client.rs:55:8 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn create_client(mut default_headers: HeaderMap) -> Result { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let client = Client::builder() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | Ok(add_client_middleware(client)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/sources/source.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 32 | let github = GithubProvider::new()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | Ok(Self { github }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/sources/source.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 46 | let github = match auth.get(&ArtifactProvider::GitHub) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | Ok(Self { github }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/sources/github/mod.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 33 | let headers = { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let mut headers = HeaderMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let client = create_client(headers)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | [INFO] [stdout] 48 | Ok(Self { client, has_auth }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/sources/github/result.rs:36:40 [INFO] [stdout] | [INFO] [stdout] 35 | fn from(err: reqwest_middleware::Error) -> Self { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | GithubError::ReqwestMiddleware(err.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/sources/github/result.rs:42:30 [INFO] [stdout] | [INFO] [stdout] 41 | fn from(err: ReqwestError) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | GithubError::Reqwest(err.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/storage/tool_cache.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 151 | let sorted_set = self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | sorted_set.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/tool/id.rs:64:24 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn into_spec(self, version: Version) -> ToolSpec { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | ToolSpec::from((self, version)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/tool/spec.rs:112:12 [INFO] [stdout] | [INFO] [stdout] 100 | let version = match after.parse::() { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | Ok(version) => version, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | Ok(ToolSpec { id, version }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 29 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rokit` (lib test) due to 30 previous errors [INFO] running `Command { std: "docker" "inspect" "e20f2070be9711af1c48fd82084136fe90db1a6a8fa41c9fc2e6b80d9e0c0f82", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e20f2070be9711af1c48fd82084136fe90db1a6a8fa41c9fc2e6b80d9e0c0f82", kill_on_drop: false }` [INFO] [stdout] e20f2070be9711af1c48fd82084136fe90db1a6a8fa41c9fc2e6b80d9e0c0f82