[INFO] fetching crate rocket_sync_db_pools_codegen 0.1.0... [INFO] checking rocket_sync_db_pools_codegen-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rocket_sync_db_pools_codegen 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate rocket_sync_db_pools_codegen 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rocket_sync_db_pools_codegen 0.1.0 [INFO] finished tweaking crates.io crate rocket_sync_db_pools_codegen 0.1.0 [INFO] tweaked toml for crates.io crate rocket_sync_db_pools_codegen 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 40 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 01d85f63fe3310480c5b6bb8b72ce13ba76be8c6ef41d3f72e21456358ebaaf8 [INFO] running `Command { std: "docker" "start" "-a" "01d85f63fe3310480c5b6bb8b72ce13ba76be8c6ef41d3f72e21456358ebaaf8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "01d85f63fe3310480c5b6bb8b72ce13ba76be8c6ef41d3f72e21456358ebaaf8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "01d85f63fe3310480c5b6bb8b72ce13ba76be8c6ef41d3f72e21456358ebaaf8", kill_on_drop: false }` [INFO] [stdout] 01d85f63fe3310480c5b6bb8b72ce13ba76be8c6ef41d3f72e21456358ebaaf8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f2811450e4a57b799c4c7076482d291fb4a42a4f15ce73c50605e80ff642d92b [INFO] running `Command { std: "docker" "start" "-a" "f2811450e4a57b799c4c7076482d291fb4a42a4f15ce73c50605e80ff642d92b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling yansi v1.0.1 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling proc-macro2-diagnostics v0.10.1 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Compiling trybuild v1.0.99 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking version_check v0.9.5 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking devise_core v0.4.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Compiling devise_codegen v0.4.2 [INFO] [stderr] Checking devise v0.4.2 [INFO] [stderr] Compiling rocket_sync_db_pools_codegen v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn database(attr: TokenStream, input: TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | crate::database::database_attr(attr, input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:55:32 [INFO] [stdout] | [INFO] [stdout] 55 | .unwrap_or_else(|diag| diag.emit_as_item_tokens().into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 27 | fn parse_invocation(attr: TokenStream, input: TokenStream) -> Result { [INFO] [stdout] | ----------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let attr_stream2 = crate::proc_macro2::TokenStream::from(attr); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let string_lit = crate::syn::parse2::(attr_stream2)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | let input = crate::syn::parse::(input).unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let structure = match input.data { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | syn::Data::Struct(s) => s, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let inner_type = match structure.fields { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | Ok(DatabaseInvocation { [INFO] [stdout] | ________^ [INFO] [stdout] 50 | | attrs: input.attrs, [INFO] [stdout] 51 | | type_name: input.ident, [INFO] [stdout] 52 | | visibility: input.vis, [INFO] [stdout] 53 | | db_name: string_lit.value(), [INFO] [stdout] 54 | | connection_type: inner_type, [INFO] [stdout] 55 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:82:8 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn database_attr(attr: TokenStream, input: TokenStream) -> Result { [INFO] [stdout] | ----------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let invocation = parse_invocation(attr, input)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | let root = quote_spanned!(span => ::rocket_sync_db_pools); [INFO] [stdout] | ---- ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let rocket = quote!(#root::rocket); [INFO] [stdout] | ------ --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | [INFO] [stdout] 75 | let request_guard_type = quote_spanned! { span => [INFO] [stdout] | _________------------------___- [INFO] [stdout] | |_________|____________________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | | #(#attrs)* #vis struct #guard_type(#root::Connection); [INFO] [stdout] 77 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | [INFO] [stdout] 79 | | let pool = quote_spanned!(span => #root::ConnectionPool); [INFO] [stdout] | | ---- --------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | | let conn = quote_spanned!(span => #root::Connection); [INFO] [stdout] | | ---- ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | | [INFO] [stdout] 82 | Ok(quote! { [INFO] [stdout] | ________^ [INFO] [stdout] | |________| [INFO] [stdout] 83 | | #request_guard_type [INFO] [stdout] 84 | | [INFO] [stdout] 85 | | impl #guard_type { [INFO] [stdout] ... | [INFO] [stdout] 127 | | } [INFO] [stdout] 128 | | }.into()) [INFO] [stdout] | |____________^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn database(attr: TokenStream, input: TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | crate::database::database_attr(attr, input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:55:32 [INFO] [stdout] | [INFO] [stdout] 55 | .unwrap_or_else(|diag| diag.emit_as_item_tokens().into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rocket_sync_db_pools_codegen` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 27 | fn parse_invocation(attr: TokenStream, input: TokenStream) -> Result { [INFO] [stdout] | ----------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let attr_stream2 = crate::proc_macro2::TokenStream::from(attr); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let string_lit = crate::syn::parse2::(attr_stream2)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | let input = crate::syn::parse::(input).unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let structure = match input.data { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | syn::Data::Struct(s) => s, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let inner_type = match structure.fields { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | Ok(DatabaseInvocation { [INFO] [stdout] | ________^ [INFO] [stdout] 50 | | attrs: input.attrs, [INFO] [stdout] 51 | | type_name: input.ident, [INFO] [stdout] 52 | | visibility: input.vis, [INFO] [stdout] 53 | | db_name: string_lit.value(), [INFO] [stdout] 54 | | connection_type: inner_type, [INFO] [stdout] 55 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:82:8 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn database_attr(attr: TokenStream, input: TokenStream) -> Result { [INFO] [stdout] | ----------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let invocation = parse_invocation(attr, input)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | let root = quote_spanned!(span => ::rocket_sync_db_pools); [INFO] [stdout] | ---- ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let rocket = quote!(#root::rocket); [INFO] [stdout] | ------ --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | [INFO] [stdout] 75 | let request_guard_type = quote_spanned! { span => [INFO] [stdout] | _________------------------___- [INFO] [stdout] | |_________|____________________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | | #(#attrs)* #vis struct #guard_type(#root::Connection); [INFO] [stdout] 77 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | [INFO] [stdout] 79 | | let pool = quote_spanned!(span => #root::ConnectionPool); [INFO] [stdout] | | ---- --------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | | let conn = quote_spanned!(span => #root::Connection); [INFO] [stdout] | | ---- ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | | [INFO] [stdout] 82 | Ok(quote! { [INFO] [stdout] | ________^ [INFO] [stdout] | |________| [INFO] [stdout] 83 | | #request_guard_type [INFO] [stdout] 84 | | [INFO] [stdout] 85 | | impl #guard_type { [INFO] [stdout] ... | [INFO] [stdout] 127 | | } [INFO] [stdout] 128 | | }.into()) [INFO] [stdout] | |____________^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rocket_sync_db_pools_codegen` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "f2811450e4a57b799c4c7076482d291fb4a42a4f15ce73c50605e80ff642d92b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f2811450e4a57b799c4c7076482d291fb4a42a4f15ce73c50605e80ff642d92b", kill_on_drop: false }` [INFO] [stdout] f2811450e4a57b799c4c7076482d291fb4a42a4f15ce73c50605e80ff642d92b