[INFO] fetching crate rnix-lsp 0.2.5... [INFO] checking rnix-lsp-0.2.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rnix-lsp 0.2.5 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate rnix-lsp 0.2.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rnix-lsp 0.2.5 [INFO] finished tweaking crates.io crate rnix-lsp 0.2.5 [INFO] tweaked toml for crates.io crate rnix-lsp 0.2.5 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate rnix-lsp 0.2.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a4465154f8450161c9ed767d60215ff025077f17f7a600fc19c99aeb069e4c8f [INFO] running `Command { std: "docker" "start" "-a" "a4465154f8450161c9ed767d60215ff025077f17f7a600fc19c99aeb069e4c8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a4465154f8450161c9ed767d60215ff025077f17f7a600fc19c99aeb069e4c8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a4465154f8450161c9ed767d60215ff025077f17f7a600fc19c99aeb069e4c8f", kill_on_drop: false }` [INFO] [stdout] a4465154f8450161c9ed767d60215ff025077f17f7a600fc19c99aeb069e4c8f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 14f344f72f4fc02a84545beb136ca5616bd3c53578874fafa8a3380cccb15341 [INFO] running `Command { std: "docker" "start" "-a" "14f344f72f4fc02a84545beb136ca5616bd3c53578874fafa8a3380cccb15341", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.75 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling libc v0.2.101 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling serde_json v1.0.67 [INFO] [stderr] Checking tinyvec v1.3.1 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking unicode-bidi v0.3.6 [INFO] [stderr] Checking once_cell v1.9.0 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking countme v2.0.4 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking thread_local v1.1.3 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking cbitset v0.2.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking smol_str v0.1.18 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking dirs-sys v0.3.6 [INFO] [stderr] Checking crossbeam-channel v0.3.9 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking dirs v3.0.2 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking globset v0.4.8 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling serde_repr v0.1.7 [INFO] [stderr] Checking ignore v0.4.18 [INFO] [stderr] Checking text-size v1.1.0 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking rowan v0.12.6 [INFO] [stderr] Checking rnix v0.10.2 [INFO] [stderr] Checking lsp-server v0.5.2 [INFO] [stderr] Checking lsp-types v0.89.2 [INFO] [stderr] Checking nixpkgs-fmt-rnix v1.2.0 [INFO] [stderr] Checking rnix-lsp v0.2.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lookup.rs:66:18 [INFO] [stdout] | [INFO] [stdout] 63 | fn from_scope(datatype: Datatype, var: Var) -> LSPDetails { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | var: Some(var), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lookup.rs:111:14 [INFO] [stdout] | [INFO] [stdout] 90 | let info = utils::ident_at(&root, offset)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let ident = info.ident; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let mut entries = utils::scope_for(&file, ident.node().clone())? [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | Some(( [INFO] [stdout] | ______________^ [INFO] [stdout] 112 | | Ident::cast(ident.node().clone()).unwrap(), [INFO] [stdout] 113 | | entries, [INFO] [stdout] 114 | | info.name, [INFO] [stdout] 115 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lookup.rs:94:44 [INFO] [stdout] | [INFO] [stdout] 94 | .map(|(x, var)| (x.to_owned(), LSPDetails::from_scope(var.datatype, var))) [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lookup.rs:106:56 [INFO] [stdout] | [INFO] [stdout] 106 | .map(|(x, var)| (x.to_owned(), LSPDetails::from_scope(var.datatype, var))) [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lookup.rs:170:38 [INFO] [stdout] | [INFO] [stdout] 170 | list.into_iter().map(|x| (x, LSPDetails::builtin_fallback())).collect::>() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:109:80 [INFO] [stdout] | [INFO] [stdout] 109 | let result = Ident::cast(left.parent()).or_else(|| Ident::cast(right.parent())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rnix-lsp` (bin "rnix-lsp") due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lookup.rs:66:18 [INFO] [stdout] | [INFO] [stdout] 63 | fn from_scope(datatype: Datatype, var: Var) -> LSPDetails { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | var: Some(var), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lookup.rs:111:14 [INFO] [stdout] | [INFO] [stdout] 90 | let info = utils::ident_at(&root, offset)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let ident = info.ident; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let mut entries = utils::scope_for(&file, ident.node().clone())? [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | Some(( [INFO] [stdout] | ______________^ [INFO] [stdout] 112 | | Ident::cast(ident.node().clone()).unwrap(), [INFO] [stdout] 113 | | entries, [INFO] [stdout] 114 | | info.name, [INFO] [stdout] 115 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lookup.rs:94:44 [INFO] [stdout] | [INFO] [stdout] 94 | .map(|(x, var)| (x.to_owned(), LSPDetails::from_scope(var.datatype, var))) [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lookup.rs:106:56 [INFO] [stdout] | [INFO] [stdout] 106 | .map(|(x, var)| (x.to_owned(), LSPDetails::from_scope(var.datatype, var))) [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lookup.rs:170:38 [INFO] [stdout] | [INFO] [stdout] 170 | list.into_iter().map(|x| (x, LSPDetails::builtin_fallback())).collect::>() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:109:80 [INFO] [stdout] | [INFO] [stdout] 109 | let result = Ident::cast(left.parent()).or_else(|| Ident::cast(right.parent())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rnix-lsp` (bin "rnix-lsp" test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "14f344f72f4fc02a84545beb136ca5616bd3c53578874fafa8a3380cccb15341", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "14f344f72f4fc02a84545beb136ca5616bd3c53578874fafa8a3380cccb15341", kill_on_drop: false }` [INFO] [stdout] 14f344f72f4fc02a84545beb136ca5616bd3c53578874fafa8a3380cccb15341