[INFO] fetching crate rlt 0.2.0... [INFO] checking rlt-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rlt 0.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate rlt 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-0-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate rlt 0.2.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate rlt 0.2.0 [INFO] tweaked toml for crates.io crate rlt 0.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate rlt 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8e63ae675f8df825ffe86d532d6294950832094e4cbb66efdb85674db5f0509d [INFO] running `Command { std: "docker" "start" "-a" "8e63ae675f8df825ffe86d532d6294950832094e4cbb66efdb85674db5f0509d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8e63ae675f8df825ffe86d532d6294950832094e4cbb66efdb85674db5f0509d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e63ae675f8df825ffe86d532d6294950832094e4cbb66efdb85674db5f0509d", kill_on_drop: false }` [INFO] [stdout] 8e63ae675f8df825ffe86d532d6294950832094e4cbb66efdb85674db5f0509d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a1c0b23fec4c39b2801df0539d4fdf0bfe240026ba66811abea6dd8b57071ff2 [INFO] running `Command { std: "docker" "start" "-a" "a1c0b23fec4c39b2801df0539d4fdf0bfe240026ba66811abea6dd8b57071ff2", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling syn v2.0.74 [INFO] [stderr] Compiling cc v1.1.10 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling serde v1.0.206 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling rust_decimal v1.35.0 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling portable-atomic v1.7.0 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking unicode-properties v0.1.1 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking stringprep v0.1.5 [INFO] [stderr] Checking compact_str v0.7.1 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Checking raw-cpuid v11.1.0 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking siphasher v0.3.11 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking bytecount v0.6.8 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Compiling serde_json v1.0.124 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking papergrid v0.11.0 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Checking flate2 v1.0.31 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking spinning_top v0.3.0 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking nonzero_ext v0.3.0 [INFO] [stderr] Checking no-std-compat v0.4.1 [INFO] [stderr] Checking utf8-width v0.1.7 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking byte-unit v5.1.4 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Checking quanta v0.12.3 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking whoami v1.5.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking hdrhistogram v7.5.4 [INFO] [stderr] Compiling tabled_derive v0.7.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking tabled v0.15.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.206 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling stability v0.2.1 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking clap v4.5.15 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Checking lru v0.12.4 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking postgres-protocol v0.6.7 [INFO] [stderr] Checking ratatui v0.27.0 [INFO] [stderr] Checking postgres-types v0.2.7 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking governor v0.6.3 [INFO] [stderr] Checking tui-logger v0.11.2 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking tokio-postgres v0.7.11 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking rlt v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:72:85 [INFO] [stdout] | [INFO] [stdout] 72 | async fn teardown(self, state: Self::WorkerState, info: IterInfo) -> Result<()> { [INFO] [stdout] | _______________________----__------------------------________________________________^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | | Ok(()) [INFO] [stdout] 74 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:147:57 [INFO] [stdout] | [INFO] [stdout] 141 | suite: BS, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | opts: BenchOpts, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | res_tx: mpsc::UnboundedSender>, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | pause: watch::Receiver, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | cancel: CancellationToken, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | ) -> Self { [INFO] [stdout] 147 | Self { suite, opts, res_tx, pause, cancel, seq: Arc::default() } [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:224:60 [INFO] [stdout] | [INFO] [stdout] 212 | let mut collector: Box = match cli.collector() { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | let report = tokio::spawn(async move { collector.run().await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collector/tui.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 67 | bench_opts: BenchOpts, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | fps: NonZeroU8, [INFO] [stdout] 69 | res_rx: mpsc::UnboundedReceiver>, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | pause: watch::Sender, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | cancel: CancellationToken, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let state = TuiCollectorState { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | Ok(Self { bench_opts, fps, res_rx, pause, cancel, auto_quit, state }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collector/tui.rs:574:5 [INFO] [stdout] | [INFO] [stdout] 572 | fn gen_tips<'a>(tips: impl IntoIterator) -> Line<'a> { [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 573 | #[allow(unstable_name_collisions)] [INFO] [stdout] 574 | / tips.into_iter() [INFO] [stdout] 575 | | .map(|(key, tip)| vec![key.bold().yellow().italic(), ": ".into(), tip.italic()]) [INFO] [stdout] 576 | | .intersperse(vec![", ".into()]) [INFO] [stdout] 577 | | .flatten() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collector/tui.rs:667:16 [INFO] [stdout] | [INFO] [stdout] 666 | let state = TuiWidgetState::new().set_default_display_level(LevelFilter::Info); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 667 | Ok(Self { inner: state, display: false }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rlt` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "a1c0b23fec4c39b2801df0539d4fdf0bfe240026ba66811abea6dd8b57071ff2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a1c0b23fec4c39b2801df0539d4fdf0bfe240026ba66811abea6dd8b57071ff2", kill_on_drop: false }` [INFO] [stdout] a1c0b23fec4c39b2801df0539d4fdf0bfe240026ba66811abea6dd8b57071ff2