[INFO] fetching crate rls-analysis 0.18.3... [INFO] checking rls-analysis-0.18.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rls-analysis 0.18.3 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate rls-analysis 0.18.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rls-analysis 0.18.3 [INFO] finished tweaking crates.io crate rls-analysis 0.18.3 [INFO] tweaked toml for crates.io crate rls-analysis 0.18.3 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate rls-analysis 0.18.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8dbd085e744766ba4e0d8e964999d06cb688048e67c612f15a011cbc15a8d9c6 [INFO] running `Command { std: "docker" "start" "-a" "8dbd085e744766ba4e0d8e964999d06cb688048e67c612f15a011cbc15a8d9c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8dbd085e744766ba4e0d8e964999d06cb688048e67c612f15a011cbc15a8d9c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8dbd085e744766ba4e0d8e964999d06cb688048e67c612f15a011cbc15a8d9c6", kill_on_drop: false }` [INFO] [stdout] 8dbd085e744766ba4e0d8e964999d06cb688048e67c612f15a011cbc15a8d9c6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 530785e666c6cd17c712a128441c3c0a2ad287c1a1c25412cd7f9e282e8b4d00 [INFO] running `Command { std: "docker" "start" "-a" "530785e666c6cd17c712a128441c3c0a2ad287c1a1c25412cd7f9e282e8b4d00", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.10 [INFO] [stderr] Compiling serde v1.0.106 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling libc v0.2.69 [INFO] [stderr] Compiling syn v1.0.18 [INFO] [stderr] Compiling ryu v1.0.4 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling fst v0.4.7 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking json v0.12.4 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking regex v1.3.7 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Checking rls-span v0.5.2 [INFO] [stderr] Checking serde_json v1.0.51 [INFO] [stderr] Compiling derive-new v0.5.8 [INFO] [stderr] Checking rls-data v0.19.0 [INFO] [stderr] Checking rls-analysis v0.18.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `SigElement` and `Signature` [INFO] [stdout] --> src/raw.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | SigElement, Signature, SpanData, [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `SigElement` and `Signature` [INFO] [stdout] --> src/raw.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | SigElement, Signature, SpanData, [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `idents` is never read [INFO] [stdout] --> src/analysis.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 34 | pub struct PerCrateAnalysis { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 51 | pub idents: HashMap, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `column_end`, `id`, and `kind` are never read [INFO] [stdout] --> src/analysis.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 116 | pub struct IdentBound { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 117 | pub column_end: Column, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 118 | pub id: Id, [INFO] [stdout] | ^^ [INFO] [stdout] 119 | pub kind: IdentKind, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `IdentBound` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Signature` is never constructed [INFO] [stdout] --> src/analysis.rs:140:12 [INFO] [stdout] | [INFO] [stdout] 140 | pub struct Signature { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Signature` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SigElement` is never constructed [INFO] [stdout] --> src/analysis.rs:150:12 [INFO] [stdout] | [INFO] [stdout] 150 | pub struct SigElement { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SigElement` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> src/listings/mod.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct DirectoryListing { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 7 | pub path: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DirectoryListing` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:116:23 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn new_with_loader(loader: L) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | Self { [INFO] [stdout] 116 | analysis: Mutex::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:118:21 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn new_with_loader(loader: L) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | loader: Mutex::new(loader), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:245:28 [INFO] [stdout] | [INFO] [stdout] 241 | pub fn for_each_child_def(&self, id: Id, f: F) -> AResult> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | self.with_analysis(|a| a.for_each_child(id, f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analysis.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 264 | pub fn for_each_crate(&self, f: F) -> Option [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 268 | let mut result = vec![]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | result.into_iter().nth(0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:64:43 [INFO] [stdout] | [INFO] [stdout] 64 | self.path_prefix.as_ref().map(|s| Path::new(s).canonicalize().unwrap().to_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raw.rs:57:27 [INFO] [stdout] | [INFO] [stdout] 57 | .filter_map(|dir| DirectoryListing::from_path(&dir.path).ok().map(|list| (dir, list))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rls-analysis` (lib) due to 7 previous errors; 6 warnings emitted [INFO] [stdout] error: aborting due to 6 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `idents` is never read [INFO] [stdout] --> src/analysis.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 34 | pub struct PerCrateAnalysis { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 51 | pub idents: HashMap, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `column_end`, `id`, and `kind` are never read [INFO] [stdout] --> src/analysis.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 116 | pub struct IdentBound { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 117 | pub column_end: Column, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 118 | pub id: Id, [INFO] [stdout] | ^^ [INFO] [stdout] 119 | pub kind: IdentKind, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `IdentBound` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Signature` is never constructed [INFO] [stdout] --> src/analysis.rs:140:12 [INFO] [stdout] | [INFO] [stdout] 140 | pub struct Signature { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Signature` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SigElement` is never constructed [INFO] [stdout] --> src/analysis.rs:150:12 [INFO] [stdout] | [INFO] [stdout] 150 | pub struct SigElement { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SigElement` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> src/listings/mod.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct DirectoryListing { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 7 | pub path: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DirectoryListing` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:116:23 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn new_with_loader(loader: L) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | Self { [INFO] [stdout] 116 | analysis: Mutex::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:118:21 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn new_with_loader(loader: L) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | loader: Mutex::new(loader), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:245:28 [INFO] [stdout] | [INFO] [stdout] 241 | pub fn for_each_child_def(&self, id: Id, f: F) -> AResult> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | self.with_analysis(|a| a.for_each_child(id, f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analysis.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 264 | pub fn for_each_crate(&self, f: F) -> Option [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 268 | let mut result = vec![]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | result.into_iter().nth(0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:64:43 [INFO] [stdout] | [INFO] [stdout] 64 | self.path_prefix.as_ref().map(|s| Path::new(s).canonicalize().unwrap().to_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raw.rs:57:27 [INFO] [stdout] | [INFO] [stdout] 57 | .filter_map(|dir| DirectoryListing::from_path(&dir.path).ok().map(|list| (dir, list))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rls-analysis` (lib test) due to 7 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "530785e666c6cd17c712a128441c3c0a2ad287c1a1c25412cd7f9e282e8b4d00", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "530785e666c6cd17c712a128441c3c0a2ad287c1a1c25412cd7f9e282e8b4d00", kill_on_drop: false }` [INFO] [stdout] 530785e666c6cd17c712a128441c3c0a2ad287c1a1c25412cd7f9e282e8b4d00