[INFO] fetching crate rlfsc 0.2.2... [INFO] checking rlfsc-0.2.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rlfsc 0.2.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate rlfsc 0.2.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rlfsc 0.2.2 [INFO] finished tweaking crates.io crate rlfsc 0.2.2 [INFO] tweaked toml for crates.io crate rlfsc 0.2.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate rlfsc 0.2.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 80f9793e7207b4806a3f0a8df42567119daeacc8e674a7312d36c2ec9500d1a5 [INFO] running `Command { std: "docker" "start" "-a" "80f9793e7207b4806a3f0a8df42567119daeacc8e674a7312d36c2ec9500d1a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "80f9793e7207b4806a3f0a8df42567119daeacc8e674a7312d36c2ec9500d1a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "80f9793e7207b4806a3f0a8df42567119daeacc8e674a7312d36c2ec9500d1a5", kill_on_drop: false }` [INFO] [stdout] 80f9793e7207b4806a3f0a8df42567119daeacc8e674a7312d36c2ec9500d1a5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3271234fb593c37dc8d94d640ace06f97e18c8ac81a0f705aa71455c21955770 [INFO] running `Command { std: "docker" "start" "-a" "3271234fb593c37dc8d94d640ace06f97e18c8ac81a0f705aa71455c21955770", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.60 [INFO] [stderr] Compiling libc v0.2.86 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling gmp-mpfr-sys v1.4.3 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Compiling rug v1.11.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Compiling utf8-ranges v1.0.4 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Compiling regex-syntax v0.6.22 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling beef v0.4.4 [INFO] [stderr] Checking az v1.1.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking yansi v0.5.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rlimit v0.4.0 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Compiling thiserror-impl v1.0.24 [INFO] [stderr] Compiling logos-derive v0.11.5 [INFO] [stderr] Checking thiserror v1.0.24 [INFO] [stderr] Checking structopt v0.3.21 [INFO] [stderr] Checking logos v0.11.4 [INFO] [stderr] Checking rlfsc v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `Level` is never constructed [INFO] [stdout] --> src/token.rs:278:8 [INFO] [stdout] | [INFO] [stdout] 278 | struct Level<'a> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/code.rs:411:68 [INFO] [stdout] | [INFO] [stdout] 411 | ... .map(|((ref_, _), a)| ref_.val.replace(Some(a.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_check.rs:64:8 [INFO] [stdout] | [INFO] [stdout] 59 | let (val, ty) = check_create(ts, e, cs, None)?; [INFO] [stdout] | --- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let old_binding = e.bind(name, val, ty); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let (v, t) = check(ts, e, cs, None, create)?; [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Ok((v, t)) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Level` is never constructed [INFO] [stdout] --> src/token.rs:278:8 [INFO] [stdout] | [INFO] [stdout] 278 | struct Level<'a> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_check.rs:76:8 [INFO] [stdout] | [INFO] [stdout] 73 | let ty = check_create(ts, e, cs, Some(&cs.type_))?.0; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let t = check(ts, e, cs, Some(&ty), create)?.0; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | ts.consume_tok(Token::Close)?; [INFO] [stdout] 76 | Ok((t, ty)) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_check.rs:92:8 [INFO] [stdout] | [INFO] [stdout] 86 | let ty = check_create(ts, e, cs, Some(&cs.type_))?.0; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let sym = Rc::new(e.new_symbol(var.clone())); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | let old_binding = e.bind(var, sym, ty); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | let (v, t) = check(ts, e, cs, None, create)?; [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | Ok((v, t)) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_check.rs:146:8 [INFO] [stdout] | [INFO] [stdout] 125 | let mut old_binds = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let mut args = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | Ok((args, old_binds)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_check.rs:176:37 [INFO] [stdout] | [INFO] [stdout] 174 | .fold(ret.unwrap(), |rng, (var, dom)| { [INFO] [stdout] | --- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | let dependent = Rc::strong_count(&var) > 1; [INFO] [stdout] 176 | Rc::new(Expr::Pi { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 177 | | dom, [INFO] [stdout] 178 | | rng, [INFO] [stdout] 179 | | var, [INFO] [stdout] 180 | | dependent, [INFO] [stdout] 181 | | }) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_check.rs:199:8 [INFO] [stdout] | [INFO] [stdout] 195 | args: Vec<(Rc, Rc)>, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | ret: Option>, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | ret_kind: Rc, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | ) -> Result<(Option>, Rc), LfscError> { [INFO] [stdout] 199 | Ok(args [INFO] [stdout] | ________^ [INFO] [stdout] 200 | | .into_iter() [INFO] [stdout] 201 | | .rev() [INFO] [stdout] 202 | | .fold((ret, ret_kind), |(retm, ret_kind), (var, dom)| { [INFO] [stdout] ... | [INFO] [stdout] 221 | | ) [INFO] [stdout] 222 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_check.rs:205:17 [INFO] [stdout] | [INFO] [stdout] 202 | .fold((ret, ret_kind), |(retm, ret_kind), (var, dom)| { [INFO] [stdout] | ---------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | / if let Some(ret) = retm { [INFO] [stdout] 206 | | Some(Rc::new(Expr::Pi { [INFO] [stdout] 207 | | var: var.clone(), [INFO] [stdout] 208 | | dom: dom.clone(), [INFO] [stdout] ... | [INFO] [stdout] 213 | | None [INFO] [stdout] 214 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_check.rs:215:17 [INFO] [stdout] | [INFO] [stdout] 202 | .fold((ret, ret_kind), |(retm, ret_kind), (var, dom)| { [INFO] [stdout] | ---------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | / Rc::new(Expr::Pi { [INFO] [stdout] 216 | | var, [INFO] [stdout] 217 | | dom, [INFO] [stdout] 218 | | rng: ret_kind, [INFO] [stdout] 219 | | dependent: false, [INFO] [stdout] 220 | | }), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_check.rs:281:8 [INFO] [stdout] | [INFO] [stdout] 229 | head_val: Rc, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | head_ty: Rc, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | let fun = head_val.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | let mut ty = head_ty; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | let mut args = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 282 | | if create { [INFO] [stdout] 283 | | Some(Rc::new(Expr::App(fun, args))) [INFO] [stdout] 284 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 287 | | ty, [INFO] [stdout] 288 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_check.rs:297:49 [INFO] [stdout] | [INFO] [stdout] 297 | check(ts, e, cs, ex_ty, true).map(|(a, b)| (a.unwrap(), b)) [INFO] [stdout] | ------ ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_check.rs:444:17 [INFO] [stdout] | [INFO] [stdout] 442 | let pgm_ty = args.iter().rev().fold(ret_ty.clone(), |x, (n, t)| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 443 | let dependent = x.free_vars().contains(&n.name); [INFO] [stdout] 444 | Rc::new(Expr::Pi { [INFO] [stdout] | _________________^ [INFO] [stdout] 445 | | var: n.clone(), [INFO] [stdout] 446 | | rng: x, [INFO] [stdout] 447 | | dom: t.clone(), [INFO] [stdout] 448 | | dependent, [INFO] [stdout] 449 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_check.rs:481:8 [INFO] [stdout] | [INFO] [stdout] 478 | let name = consume_new_ref(ts)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 479 | let ty = check_create(ts, e, cs, Some(&cs.type_))?.0; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 480 | ts.consume_tok(Token::Close)?; [INFO] [stdout] 481 | Ok((name, ty)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/code.rs:411:68 [INFO] [stdout] | [INFO] [stdout] 411 | ... .map(|((ref_, _), a)| ref_.val.replace(Some(a.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_check.rs:64:8 [INFO] [stdout] | [INFO] [stdout] 59 | let (val, ty) = check_create(ts, e, cs, None)?; [INFO] [stdout] | --- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let old_binding = e.bind(name, val, ty); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let (v, t) = check(ts, e, cs, None, create)?; [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Ok((v, t)) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_check.rs:76:8 [INFO] [stdout] | [INFO] [stdout] 73 | let ty = check_create(ts, e, cs, Some(&cs.type_))?.0; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let t = check(ts, e, cs, Some(&ty), create)?.0; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | ts.consume_tok(Token::Close)?; [INFO] [stdout] 76 | Ok((t, ty)) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_check.rs:92:8 [INFO] [stdout] | [INFO] [stdout] 86 | let ty = check_create(ts, e, cs, Some(&cs.type_))?.0; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let sym = Rc::new(e.new_symbol(var.clone())); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | let old_binding = e.bind(var, sym, ty); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | let (v, t) = check(ts, e, cs, None, create)?; [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | Ok((v, t)) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_check.rs:146:8 [INFO] [stdout] | [INFO] [stdout] 125 | let mut old_binds = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let mut args = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | Ok((args, old_binds)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_check.rs:176:37 [INFO] [stdout] | [INFO] [stdout] 174 | .fold(ret.unwrap(), |rng, (var, dom)| { [INFO] [stdout] | --- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | let dependent = Rc::strong_count(&var) > 1; [INFO] [stdout] 176 | Rc::new(Expr::Pi { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 177 | | dom, [INFO] [stdout] 178 | | rng, [INFO] [stdout] 179 | | var, [INFO] [stdout] 180 | | dependent, [INFO] [stdout] 181 | | }) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_check.rs:199:8 [INFO] [stdout] | [INFO] [stdout] 195 | args: Vec<(Rc, Rc)>, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | ret: Option>, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | ret_kind: Rc, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | ) -> Result<(Option>, Rc), LfscError> { [INFO] [stdout] 199 | Ok(args [INFO] [stdout] | ________^ [INFO] [stdout] 200 | | .into_iter() [INFO] [stdout] 201 | | .rev() [INFO] [stdout] 202 | | .fold((ret, ret_kind), |(retm, ret_kind), (var, dom)| { [INFO] [stdout] ... | [INFO] [stdout] 221 | | ) [INFO] [stdout] 222 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_check.rs:205:17 [INFO] [stdout] | [INFO] [stdout] 202 | .fold((ret, ret_kind), |(retm, ret_kind), (var, dom)| { [INFO] [stdout] | ---------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | / if let Some(ret) = retm { [INFO] [stdout] 206 | | Some(Rc::new(Expr::Pi { [INFO] [stdout] 207 | | var: var.clone(), [INFO] [stdout] 208 | | dom: dom.clone(), [INFO] [stdout] ... | [INFO] [stdout] 213 | | None [INFO] [stdout] 214 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_check.rs:215:17 [INFO] [stdout] | [INFO] [stdout] 202 | .fold((ret, ret_kind), |(retm, ret_kind), (var, dom)| { [INFO] [stdout] | ---------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | / Rc::new(Expr::Pi { [INFO] [stdout] 216 | | var, [INFO] [stdout] 217 | | dom, [INFO] [stdout] 218 | | rng: ret_kind, [INFO] [stdout] 219 | | dependent: false, [INFO] [stdout] 220 | | }), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_check.rs:281:8 [INFO] [stdout] | [INFO] [stdout] 229 | head_val: Rc, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | head_ty: Rc, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | let fun = head_val.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | let mut ty = head_ty; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | let mut args = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 282 | | if create { [INFO] [stdout] 283 | | Some(Rc::new(Expr::App(fun, args))) [INFO] [stdout] 284 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 287 | | ty, [INFO] [stdout] 288 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_check.rs:297:49 [INFO] [stdout] | [INFO] [stdout] 297 | check(ts, e, cs, ex_ty, true).map(|(a, b)| (a.unwrap(), b)) [INFO] [stdout] | ------ ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_check.rs:444:17 [INFO] [stdout] | [INFO] [stdout] 442 | let pgm_ty = args.iter().rev().fold(ret_ty.clone(), |x, (n, t)| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 443 | let dependent = x.free_vars().contains(&n.name); [INFO] [stdout] 444 | Rc::new(Expr::Pi { [INFO] [stdout] | _________________^ [INFO] [stdout] 445 | | var: n.clone(), [INFO] [stdout] 446 | | rng: x, [INFO] [stdout] 447 | | dom: t.clone(), [INFO] [stdout] 448 | | dependent, [INFO] [stdout] 449 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_check.rs:481:8 [INFO] [stdout] | [INFO] [stdout] 478 | let name = consume_new_ref(ts)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 479 | let ty = check_create(ts, e, cs, Some(&cs.type_))?.0; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 480 | ts.consume_tok(Token::Close)?; [INFO] [stdout] 481 | Ok((name, ty)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rlfsc` (bin "rlfsc" test) due to 14 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rlfsc` (bin "rlfsc") due to 14 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "3271234fb593c37dc8d94d640ace06f97e18c8ac81a0f705aa71455c21955770", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3271234fb593c37dc8d94d640ace06f97e18c8ac81a0f705aa71455c21955770", kill_on_drop: false }` [INFO] [stdout] 3271234fb593c37dc8d94d640ace06f97e18c8ac81a0f705aa71455c21955770