[INFO] fetching crate riwaq 0.1.0... [INFO] checking riwaq-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate riwaq 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate riwaq 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate riwaq 0.1.0 [INFO] finished tweaking crates.io crate riwaq 0.1.0 [INFO] tweaked toml for crates.io crate riwaq 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 34 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding heck v0.3.3 (latest: v0.5.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding proc-macro2 v0.4.30 (latest: v1.0.86) [INFO] [stderr] Adding quote v0.6.13 (latest: v1.0.37) [INFO] [stderr] Adding syn v0.15.44 (latest: v2.0.77) [INFO] [stderr] Adding unicode-xid v0.1.0 (latest: v0.2.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 130307490c0e7c548c93c7df71cbc8ef014c0f0f6b2b881b093fe74057492fb8 [INFO] running `Command { std: "docker" "start" "-a" "130307490c0e7c548c93c7df71cbc8ef014c0f0f6b2b881b093fe74057492fb8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "130307490c0e7c548c93c7df71cbc8ef014c0f0f6b2b881b093fe74057492fb8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "130307490c0e7c548c93c7df71cbc8ef014c0f0f6b2b881b093fe74057492fb8", kill_on_drop: false }` [INFO] [stdout] 130307490c0e7c548c93c7df71cbc8ef014c0f0f6b2b881b093fe74057492fb8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bd55378e4c01fd7a9617fab3b50ab4e9203997ae403386cbf712d940569820d3 [INFO] running `Command { std: "docker" "start" "-a" "bd55378e4c01fd7a9617fab3b50ab4e9203997ae403386cbf712d940569820d3", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling convert_case v0.6.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling field_types v1.1.0 [INFO] [stderr] Compiling riwaq-types v0.1.0 [INFO] [stderr] Compiling riwaq-macro v0.1.0 [INFO] [stderr] Checking riwaq v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sql.rs:396:21 [INFO] [stdout] | [INFO] [stdout] 394 | pub fn and(self, filter: T) -> Self { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 395 | Self { [INFO] [stdout] 396 | filter: Some(match self.filter { [INFO] [stdout] | _____________________^ [INFO] [stdout] 397 | | Some(ex_filter) => ex_filter.and(filter), [INFO] [stdout] 398 | | _ => FilterStmt::Filter(filter), [INFO] [stdout] 399 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sql.rs:408:21 [INFO] [stdout] | [INFO] [stdout] 403 | pub fn and_all(self, filter: VEC) -> Self [INFO] [stdout] | ---- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 408 | filter: Some(match self.filter { [INFO] [stdout] | _____________________^ [INFO] [stdout] 409 | | Some(ex_filter) => ex_filter.and_all::(filter), [INFO] [stdout] 410 | | _ => FilterStmt::And( [INFO] [stdout] 411 | | filter [INFO] [stdout] ... | [INFO] [stdout] 415 | | ), [INFO] [stdout] 416 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sql.rs:425:21 [INFO] [stdout] | [INFO] [stdout] 423 | pub fn or(self, filter: T) -> Self { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 424 | Self { [INFO] [stdout] 425 | filter: Some(match self.filter { [INFO] [stdout] | _____________________^ [INFO] [stdout] 426 | | Some(ex_filter) => ex_filter.or(filter), [INFO] [stdout] 427 | | _ => FilterStmt::Filter(filter), [INFO] [stdout] 428 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sql.rs:437:21 [INFO] [stdout] | [INFO] [stdout] 432 | pub fn or_any(self, filter: VEC) -> Self [INFO] [stdout] | ---- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 437 | filter: Some(match self.filter { [INFO] [stdout] | _____________________^ [INFO] [stdout] 438 | | Some(ex_filter) => ex_filter.or_any::(filter), [INFO] [stdout] 439 | | _ => FilterStmt::Or( [INFO] [stdout] 440 | | filter [INFO] [stdout] ... | [INFO] [stdout] 444 | | ), [INFO] [stdout] 445 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `riwaq` (lib test) due to 5 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sql.rs:396:21 [INFO] [stdout] | [INFO] [stdout] 394 | pub fn and(self, filter: T) -> Self { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 395 | Self { [INFO] [stdout] 396 | filter: Some(match self.filter { [INFO] [stdout] | _____________________^ [INFO] [stdout] 397 | | Some(ex_filter) => ex_filter.and(filter), [INFO] [stdout] 398 | | _ => FilterStmt::Filter(filter), [INFO] [stdout] 399 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sql.rs:408:21 [INFO] [stdout] | [INFO] [stdout] 403 | pub fn and_all(self, filter: VEC) -> Self [INFO] [stdout] | ---- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 408 | filter: Some(match self.filter { [INFO] [stdout] | _____________________^ [INFO] [stdout] 409 | | Some(ex_filter) => ex_filter.and_all::(filter), [INFO] [stdout] 410 | | _ => FilterStmt::And( [INFO] [stdout] 411 | | filter [INFO] [stdout] ... | [INFO] [stdout] 415 | | ), [INFO] [stdout] 416 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sql.rs:425:21 [INFO] [stdout] | [INFO] [stdout] 423 | pub fn or(self, filter: T) -> Self { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 424 | Self { [INFO] [stdout] 425 | filter: Some(match self.filter { [INFO] [stdout] | _____________________^ [INFO] [stdout] 426 | | Some(ex_filter) => ex_filter.or(filter), [INFO] [stdout] 427 | | _ => FilterStmt::Filter(filter), [INFO] [stdout] 428 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sql.rs:437:21 [INFO] [stdout] | [INFO] [stdout] 432 | pub fn or_any(self, filter: VEC) -> Self [INFO] [stdout] | ---- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 437 | filter: Some(match self.filter { [INFO] [stdout] | _____________________^ [INFO] [stdout] 438 | | Some(ex_filter) => ex_filter.or_any::(filter), [INFO] [stdout] 439 | | _ => FilterStmt::Or( [INFO] [stdout] 440 | | filter [INFO] [stdout] ... | [INFO] [stdout] 444 | | ), [INFO] [stdout] 445 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `riwaq` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "bd55378e4c01fd7a9617fab3b50ab4e9203997ae403386cbf712d940569820d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bd55378e4c01fd7a9617fab3b50ab4e9203997ae403386cbf712d940569820d3", kill_on_drop: false }` [INFO] [stdout] bd55378e4c01fd7a9617fab3b50ab4e9203997ae403386cbf712d940569820d3