[INFO] fetching crate rivet 0.0.1... [INFO] checking rivet-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rivet 0.0.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate rivet 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rivet 0.0.1 [INFO] finished tweaking crates.io crate rivet 0.0.1 [INFO] tweaked toml for crates.io crate rivet 0.0.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 27 packages to latest compatible versions [INFO] [stderr] Adding aho-corasick v0.6.10 (latest: v1.1.3) [INFO] [stderr] Adding bitflags v0.4.0 (latest: v2.6.0) [INFO] [stderr] Adding encode_unicode v0.1.3 (latest: v1.0.0) [INFO] [stderr] Adding memchr v1.0.2 (latest: v2.7.4) [INFO] [stderr] Adding nix v0.5.1 (latest: v0.29.0) [INFO] [stderr] Adding nom v3.2.1 (latest: v7.1.3) [INFO] [stderr] Adding regex v0.2.11 (latest: v1.10.6) [INFO] [stderr] Adding regex-syntax v0.5.6 (latest: v0.8.4) [INFO] [stderr] Adding rustyline v1.0.0 (latest: v14.0.0) [INFO] [stderr] Adding string-interner v0.6.4 (latest: v0.17.0) [INFO] [stderr] Adding thread_local v0.3.6 (latest: v1.1.8) [INFO] [stderr] Adding ucd-util v0.1.10 (latest: v0.2.1) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a8536778004cbb63f79a9aa1836611930c9dd95ad403b7902ef6d09941921636 [INFO] running `Command { std: "docker" "start" "-a" "a8536778004cbb63f79a9aa1836611930c9dd95ad403b7902ef6d09941921636", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a8536778004cbb63f79a9aa1836611930c9dd95ad403b7902ef6d09941921636", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a8536778004cbb63f79a9aa1836611930c9dd95ad403b7902ef6d09941921636", kill_on_drop: false }` [INFO] [stdout] a8536778004cbb63f79a9aa1836611930c9dd95ad403b7902ef6d09941921636 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8d65ff6ab03c4a886af20b76470310ba904afa3b4ba4ccdf0fd3a38b5fc1d07f [INFO] running `Command { std: "docker" "start" "-a" "8d65ff6ab03c4a886af20b76470310ba904afa3b4ba4ccdf0fd3a38b5fc1d07f", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking ucd-util v0.1.10 [INFO] [stderr] Checking utf8-ranges v1.0.5 [INFO] [stderr] Checking bitflags v0.4.0 [INFO] [stderr] Checking encode_unicode v0.1.3 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Checking aho-corasick v0.6.10 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking rustyline v1.0.0 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking string-interner v0.6.4 [INFO] [stderr] Checking rivet v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/lib.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/builtins.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/lexer.rs:67:1 [INFO] [stdout] | [INFO] [stdout] 67 | / /// This is kind of hacky; doesn't do special characters, escaped quotes, etc [INFO] [stdout] 68 | | /// but fine for now. [INFO] [stdout] | |_--------------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/lexer.rs:74:1 [INFO] [stdout] | [INFO] [stdout] 74 | / /// This is also hacky 'cause it doesn't actually recognize any special [INFO] [stdout] 75 | | /// THINGS like backslashes, numbers, etc; basically if something doesn't [INFO] [stdout] 76 | | /// match any other token type then it's a valid word. [INFO] [stdout] | |_-----------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom::*` [INFO] [stdout] --> src/lexer.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 95 | use nom::*; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp` [INFO] [stdout] --> src/vm.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::cmp; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/lib.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/builtins.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/lexer.rs:67:1 [INFO] [stdout] | [INFO] [stdout] 67 | / /// This is kind of hacky; doesn't do special characters, escaped quotes, etc [INFO] [stdout] 68 | | /// but fine for now. [INFO] [stdout] | |_--------------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/lexer.rs:74:1 [INFO] [stdout] | [INFO] [stdout] 74 | / /// This is also hacky 'cause it doesn't actually recognize any special [INFO] [stdout] 75 | | /// THINGS like backslashes, numbers, etc; basically if something doesn't [INFO] [stdout] 76 | | /// match any other token type then it's a valid word. [INFO] [stdout] | |_-----------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom::*` [INFO] [stdout] --> src/lexer.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 95 | use nom::*; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp` [INFO] [stdout] --> src/vm.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::cmp; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `vm::Value::*` [INFO] [stdout] --> src/vm.rs:304:9 [INFO] [stdout] | [INFO] [stdout] 304 | use vm::Value::*; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `builtins` [INFO] [stdout] --> src/vm.rs:305:9 [INFO] [stdout] | [INFO] [stdout] 305 | use builtins; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_id` is never used [INFO] [stdout] --> src/lexer.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 25 | impl Token { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] 26 | fn is_id(&self) -> bool { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_int`, `get_block`, `get_symbol`, and `quote` are never used [INFO] [stdout] --> src/vm.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 52 | impl Ast { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] 53 | fn get_int(&self) -> Option { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 60 | fn get_block(&self) -> Option<&[Ast]> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 67 | fn get_symbol(&self) -> Option<&str> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 74 | fn quote(&self) -> Ast { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lexer.rs:223:48 [INFO] [stdout] | [INFO] [stdout] 223 | self.tok.iter().position(|b| predicate(b.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rivet` (lib) due to 2 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `is_id` is never used [INFO] [stdout] --> src/lexer.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 25 | impl Token { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] 26 | fn is_id(&self) -> bool { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_int`, `get_block`, `get_symbol`, and `quote` are never used [INFO] [stdout] --> src/vm.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 52 | impl Ast { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] 53 | fn get_int(&self) -> Option { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 60 | fn get_block(&self) -> Option<&[Ast]> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 67 | fn get_symbol(&self) -> Option<&str> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 74 | fn quote(&self) -> Ast { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lexer.rs:223:48 [INFO] [stdout] | [INFO] [stdout] 223 | self.tok.iter().position(|b| predicate(b.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rivet` (lib test) due to 2 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8d65ff6ab03c4a886af20b76470310ba904afa3b4ba4ccdf0fd3a38b5fc1d07f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d65ff6ab03c4a886af20b76470310ba904afa3b4ba4ccdf0fd3a38b5fc1d07f", kill_on_drop: false }` [INFO] [stdout] 8d65ff6ab03c4a886af20b76470310ba904afa3b4ba4ccdf0fd3a38b5fc1d07f