[INFO] fetching crate ritual_common 0.4.0... [INFO] checking ritual_common-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ritual_common 0.4.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate ritual_common 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ritual_common 0.4.0 [INFO] finished tweaking crates.io crate ritual_common 0.4.0 [INFO] tweaked toml for crates.io crate ritual_common 0.4.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 49 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.8.2 (latest: v0.13.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding pathdiff v0.1.0 (latest: v0.2.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding shell-words v0.1.0 (latest: v1.1.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding term v0.4.6 (latest: v1.0.0) [INFO] [stderr] Adding term-painter v0.2.4 (latest: v0.4.0) [INFO] [stderr] Adding toml v0.4.10 (latest: v0.8.19) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d07864424a392fafb7c940b3d18b5b9ceca19ed30aa0ae1d5172b0cb25cbeb02 [INFO] running `Command { std: "docker" "start" "-a" "d07864424a392fafb7c940b3d18b5b9ceca19ed30aa0ae1d5172b0cb25cbeb02", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d07864424a392fafb7c940b3d18b5b9ceca19ed30aa0ae1d5172b0cb25cbeb02", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d07864424a392fafb7c940b3d18b5b9ceca19ed30aa0ae1d5172b0cb25cbeb02", kill_on_drop: false }` [INFO] [stdout] d07864424a392fafb7c940b3d18b5b9ceca19ed30aa0ae1d5172b0cb25cbeb02 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1ea685159e38244c6d8bc9b3d021a2acacce5562d38cc65f66575b5fd40146da [INFO] running `Command { std: "docker" "start" "-a" "1ea685159e38244c6d8bc9b3d021a2acacce5562d38cc65f66575b5fd40146da", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking semver-parser v0.7.0 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking term v0.4.6 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking pathdiff v0.1.0 [INFO] [stderr] Checking shell-words v0.1.0 [INFO] [stderr] Checking dunce v1.0.5 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking semver v0.9.0 [INFO] [stderr] Checking term-painter v0.2.4 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking ritual_common v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `bitrig` [INFO] [stdout] --> src/target.rs:186:7 [INFO] [stdout] | [INFO] [stdout] 186 | #[cfg(target_os = "bitrig")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `target_os` are: `aix`, `android`, `cuda`, `dragonfly`, `emscripten`, `espidf`, `freebsd`, `fuchsia`, `haiku`, `hermit`, `horizon`, `hurd`, `illumos`, `ios`, `l4re`, `linux`, `macos`, `netbsd`, `none`, `nto`, `nuttx`, `openbsd`, `psp`, `redox`, `solaris`, `solid_asp3`, `teeos`, `trusty`, `tvos`, `uefi`, `unknown`, `visionos`, `vita`, `vxworks`, and `wasi` and 4 more [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `bitrig` [INFO] [stdout] --> src/target.rs:186:7 [INFO] [stdout] | [INFO] [stdout] 186 | #[cfg(target_os = "bitrig")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `target_os` are: `aix`, `android`, `cuda`, `dragonfly`, `emscripten`, `espidf`, `freebsd`, `fuchsia`, `haiku`, `hermit`, `horizon`, `hurd`, `illumos`, `ios`, `l4re`, `linux`, `macos`, `netbsd`, `none`, `nto`, `nuttx`, `openbsd`, `psp`, `redox`, `solaris`, `solid_asp3`, `teeos`, `trusty`, `tvos`, `uefi`, `unknown`, `visionos`, `vita`, `vxworks`, and `wasi` and 4 more [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpp_lib_builder.rs:64:32 [INFO] [stdout] | [INFO] [stdout] 64 | .map_if_ok(|x| path_to_str(x.as_ref()).map(ToString::to_string))?, [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_utils.rs:113:8 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn open_file>(path: P) -> Result>> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let file = fs::File::open(path.as_ref()) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | .with_context(|_| format!("Failed to open file for reading: {:?}", path.as_ref()))?; [INFO] [stdout] 113 | Ok(File { [INFO] [stdout] | ________^ [INFO] [stdout] 114 | | file: BufReader::new(file), [INFO] [stdout] 115 | | path: path.as_ref().to_path_buf(), [INFO] [stdout] 116 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_utils.rs:129:8 [INFO] [stdout] | [INFO] [stdout] 126 | pub fn create_file>(path: P) -> Result>> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let file = fs::File::create(path.as_ref()) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | .with_context(|_| format!("Failed to create file: {:?}", path.as_ref()))?; [INFO] [stdout] 129 | Ok(File { [INFO] [stdout] | ________^ [INFO] [stdout] 130 | | file: BufWriter::new(file), [INFO] [stdout] 131 | | path: path.as_ref().to_path_buf(), [INFO] [stdout] 132 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_utils.rs:140:8 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn create_file_for_append>(path: P) -> Result>> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | let file = fs::OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | Ok(File { [INFO] [stdout] | ________^ [INFO] [stdout] 141 | | file: BufWriter::new(file), [INFO] [stdout] 142 | | path: path.as_ref().to_path_buf(), [INFO] [stdout] 143 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_utils.rs:200:8 [INFO] [stdout] | [INFO] [stdout] 198 | pub fn load_json, T: serde::de::DeserializeOwned>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | let file = open_file(path.as_ref())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | Ok(::serde_json::from_reader(file.into_inner()) [INFO] [stdout] | ________^ [INFO] [stdout] 201 | | .with_context(|_| format!("failed to parse file as JSON: {}", path.as_ref().display()))?) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_utils.rs:239:8 [INFO] [stdout] | [INFO] [stdout] 237 | pub fn load_bincode, T: serde::de::DeserializeOwned>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | let mut file = open_file(path.as_ref())?.into_inner(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | Ok(bincode::deserialize_from(&mut file) [INFO] [stdout] | ________^ [INFO] [stdout] 240 | | .with_context(|_| format!("load_bincode failed: {}", path.as_ref().display()))?) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_utils.rs:363:8 [INFO] [stdout] | [INFO] [stdout] 362 | pub fn read_dir>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 363 | Ok(ReadDir { [INFO] [stdout] | ________^ [INFO] [stdout] 364 | | read_dir: fs::read_dir(path.as_ref()) [INFO] [stdout] 365 | | .with_context(|_| format!("Failed to read dir: {:?}", path.as_ref()))?, [INFO] [stdout] 366 | | path: path.as_ref().to_path_buf(), [INFO] [stdout] 367 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_utils.rs:374:16 [INFO] [stdout] | [INFO] [stdout] 373 | self.read_dir.next().map(|value| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 374 | Ok(value.with_context(|_| format!("Failed to read dir (in item): {:?}", self.path))?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/string_utils.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 63 | fn iterator_to_class_case, T: Iterator>(it: T) -> String { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | / it.map(|x| { [INFO] [stdout] 65 | | if char_at(x.as_ref(), 0).is_digit(10) { [INFO] [stdout] 66 | | x.as_ref().to_uppercase() [INFO] [stdout] 67 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 73 | | } [INFO] [stdout] 74 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/string_utils.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 113 | fn iterator_to_upper_case_words, T: Iterator>(it: T) -> String { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | it.map(|x| x.as_ref().to_uppercase()).join("_") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:38:11 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn add_to_multihash(hash: &mut HashMap, key: K, value: T) [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | match hash.entry(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 127 | fn map_if_ok(self, f: F) -> std::result::Result, E> [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | self.into_iter().map(f).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:178:21 [INFO] [stdout] | [INFO] [stdout] 170 | pub fn new(count: u64, message: impl Into) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | ProgressBar(Arc::new(Mutex::new(progress_bar))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ritual_common` (lib test) due to 14 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpp_lib_builder.rs:64:32 [INFO] [stdout] | [INFO] [stdout] 64 | .map_if_ok(|x| path_to_str(x.as_ref()).map(ToString::to_string))?, [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_utils.rs:113:8 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn open_file>(path: P) -> Result>> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let file = fs::File::open(path.as_ref()) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | .with_context(|_| format!("Failed to open file for reading: {:?}", path.as_ref()))?; [INFO] [stdout] 113 | Ok(File { [INFO] [stdout] | ________^ [INFO] [stdout] 114 | | file: BufReader::new(file), [INFO] [stdout] 115 | | path: path.as_ref().to_path_buf(), [INFO] [stdout] 116 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_utils.rs:129:8 [INFO] [stdout] | [INFO] [stdout] 126 | pub fn create_file>(path: P) -> Result>> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let file = fs::File::create(path.as_ref()) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | .with_context(|_| format!("Failed to create file: {:?}", path.as_ref()))?; [INFO] [stdout] 129 | Ok(File { [INFO] [stdout] | ________^ [INFO] [stdout] 130 | | file: BufWriter::new(file), [INFO] [stdout] 131 | | path: path.as_ref().to_path_buf(), [INFO] [stdout] 132 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_utils.rs:140:8 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn create_file_for_append>(path: P) -> Result>> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | let file = fs::OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | Ok(File { [INFO] [stdout] | ________^ [INFO] [stdout] 141 | | file: BufWriter::new(file), [INFO] [stdout] 142 | | path: path.as_ref().to_path_buf(), [INFO] [stdout] 143 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_utils.rs:200:8 [INFO] [stdout] | [INFO] [stdout] 198 | pub fn load_json, T: serde::de::DeserializeOwned>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | let file = open_file(path.as_ref())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | Ok(::serde_json::from_reader(file.into_inner()) [INFO] [stdout] | ________^ [INFO] [stdout] 201 | | .with_context(|_| format!("failed to parse file as JSON: {}", path.as_ref().display()))?) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_utils.rs:239:8 [INFO] [stdout] | [INFO] [stdout] 237 | pub fn load_bincode, T: serde::de::DeserializeOwned>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | let mut file = open_file(path.as_ref())?.into_inner(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | Ok(bincode::deserialize_from(&mut file) [INFO] [stdout] | ________^ [INFO] [stdout] 240 | | .with_context(|_| format!("load_bincode failed: {}", path.as_ref().display()))?) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_utils.rs:363:8 [INFO] [stdout] | [INFO] [stdout] 362 | pub fn read_dir>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 363 | Ok(ReadDir { [INFO] [stdout] | ________^ [INFO] [stdout] 364 | | read_dir: fs::read_dir(path.as_ref()) [INFO] [stdout] 365 | | .with_context(|_| format!("Failed to read dir: {:?}", path.as_ref()))?, [INFO] [stdout] 366 | | path: path.as_ref().to_path_buf(), [INFO] [stdout] 367 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_utils.rs:374:16 [INFO] [stdout] | [INFO] [stdout] 373 | self.read_dir.next().map(|value| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 374 | Ok(value.with_context(|_| format!("Failed to read dir (in item): {:?}", self.path))?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/string_utils.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 63 | fn iterator_to_class_case, T: Iterator>(it: T) -> String { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | / it.map(|x| { [INFO] [stdout] 65 | | if char_at(x.as_ref(), 0).is_digit(10) { [INFO] [stdout] 66 | | x.as_ref().to_uppercase() [INFO] [stdout] 67 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 73 | | } [INFO] [stdout] 74 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/string_utils.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 113 | fn iterator_to_upper_case_words, T: Iterator>(it: T) -> String { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | it.map(|x| x.as_ref().to_uppercase()).join("_") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:38:11 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn add_to_multihash(hash: &mut HashMap, key: K, value: T) [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | match hash.entry(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 127 | fn map_if_ok(self, f: F) -> std::result::Result, E> [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | self.into_iter().map(f).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:178:21 [INFO] [stdout] | [INFO] [stdout] 170 | pub fn new(count: u64, message: impl Into) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | ProgressBar(Arc::new(Mutex::new(progress_bar))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ritual_common` (lib) due to 14 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "1ea685159e38244c6d8bc9b3d021a2acacce5562d38cc65f66575b5fd40146da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ea685159e38244c6d8bc9b3d021a2acacce5562d38cc65f66575b5fd40146da", kill_on_drop: false }` [INFO] [stdout] 1ea685159e38244c6d8bc9b3d021a2acacce5562d38cc65f66575b5fd40146da