[INFO] fetching crate ritelinked 0.3.2... [INFO] checking ritelinked-0.3.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ritelinked 0.3.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate ritelinked 0.3.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ritelinked 0.3.2 [INFO] finished tweaking crates.io crate ritelinked 0.3.2 [INFO] tweaked toml for crates.io crate ritelinked 0.3.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 85 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hashbrown v0.11.2 (latest: v0.14.5) [INFO] [stderr] Adding hashlink v0.7.0 (latest: v0.9.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7b68f0092b954a10a28b0edfa18de176e205bba51e6ff6d91dc81476d8bbe964 [INFO] running `Command { std: "docker" "start" "-a" "7b68f0092b954a10a28b0edfa18de176e205bba51e6ff6d91dc81476d8bbe964", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7b68f0092b954a10a28b0edfa18de176e205bba51e6ff6d91dc81476d8bbe964", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7b68f0092b954a10a28b0edfa18de176e205bba51e6ff6d91dc81476d8bbe964", kill_on_drop: false }` [INFO] [stdout] 7b68f0092b954a10a28b0edfa18de176e205bba51e6ff6d91dc81476d8bbe964 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1c8bb053029225c3ee4793640c8efa927e8b904f7353a2eb440c39c86c6f6abe [INFO] running `Command { std: "docker" "start" "-a" "1c8bb053029225c3ee4793640c8efa927e8b904f7353a2eb440c39c86c6f6abe", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking griddle v0.5.2 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking hashlink v0.7.0 [INFO] [stderr] Checking ritelinked v0.3.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map.rs:70:18 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn with_hasher(hash_builder: S) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | map: HashMap::with_hasher(NullHasher), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map.rs:80:18 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn with_capacity_and_hasher(capacity: usize, hash_builder: S) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | map: HashMap::with_capacity_and_hasher(capacity, NullHasher), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/map.rs:638:17 [INFO] [stdout] | [INFO] [stdout] 638 | Box::from_raw(values.as_ptr()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 638 | let _ = Box::from_raw(values.as_ptr()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map.rs:678:46 [INFO] [stdout] | [INFO] [stdout] 678 | map.extend(self.iter().map(|(k, v)| (k.clone(), v.clone()))); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map.rs:678:57 [INFO] [stdout] | [INFO] [stdout] 678 | map.extend(self.iter().map(|(k, v)| (k.clone(), v.clone()))); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/map.rs:1698:17 [INFO] [stdout] | [INFO] [stdout] 1698 | Box::from_raw(tail); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1698 | let _ = Box::from_raw(tail); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/map.rs:1890:17 [INFO] [stdout] | [INFO] [stdout] 1890 | Box::from_raw(self.values.as_ptr()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1890 | let _ = Box::from_raw(self.values.as_ptr()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/map.rs:2107:9 [INFO] [stdout] | [INFO] [stdout] 2107 | Box::from_raw(cur.as_ptr()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 2107 | let _ = Box::from_raw(cur.as_ptr()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/map.rs:2118:9 [INFO] [stdout] | [INFO] [stdout] 2118 | Box::from_raw(some_free.as_ptr()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 2118 | let _ = Box::from_raw(some_free.as_ptr()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/set.rs:79:18 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn with_hasher(hasher: S) -> LinkedHashSet { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | LinkedHashSet { [INFO] [stdout] 79 | map: LinkedHashMap::with_hasher(hasher), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/set.rs:86:18 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn with_capacity_and_hasher(capacity: usize, hasher: S) -> LinkedHashSet { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | LinkedHashSet { [INFO] [stdout] 86 | map: LinkedHashMap::with_capacity_and_hasher(capacity, hasher), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/set.rs:180:29 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn get_or_insert_with(&mut self, value: &Q, f: F) -> &T [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | .or_insert_with(|| (f(value), ())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/set.rs:180:33 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn get_or_insert_with(&mut self, value: &Q, f: F) -> &T [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | .or_insert_with(|| (f(value), ())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/set.rs:215:15 [INFO] [stdout] | [INFO] [stdout] 214 | pub fn replace(&mut self, value: T) -> Option { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | match self.map.entry(value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/set.rs:501:19 [INFO] [stdout] | [INFO] [stdout] 499 | fn into_iter(self) -> IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 500 | IntoIter { [INFO] [stdout] 501 | iter: self.map.into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ritelinked` (lib) due to 11 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "1c8bb053029225c3ee4793640c8efa927e8b904f7353a2eb440c39c86c6f6abe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c8bb053029225c3ee4793640c8efa927e8b904f7353a2eb440c39c86c6f6abe", kill_on_drop: false }` [INFO] [stdout] 1c8bb053029225c3ee4793640c8efa927e8b904f7353a2eb440c39c86c6f6abe