[INFO] fetching crate ripgrep 14.1.0... [INFO] checking ripgrep-14.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ripgrep 14.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate ripgrep 14.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-7-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate ripgrep 14.1.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate ripgrep 14.1.0 [INFO] tweaked toml for crates.io crate ripgrep 14.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate ripgrep 14.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 28956ac6cda35bd2185e694ca381fa8be922084d23f7316aafa4604ddb1c1450 [INFO] running `Command { std: "docker" "start" "-a" "28956ac6cda35bd2185e694ca381fa8be922084d23f7316aafa4604ddb1c1450", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "28956ac6cda35bd2185e694ca381fa8be922084d23f7316aafa4604ddb1c1450", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28956ac6cda35bd2185e694ca381fa8be922084d23f7316aafa4604ddb1c1450", kill_on_drop: false }` [INFO] [stdout] 28956ac6cda35bd2185e694ca381fa8be922084d23f7316aafa4604ddb1c1450 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c88573e0f409cc498c88d2591b97bb61311ce797a11129b5d23f1667bce8cb30 [INFO] running `Command { std: "docker" "start" "-a" "c88573e0f409cc498c88d2591b97bb61311ce797a11129b5d23f1667bce8cb30", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Compiling crossbeam-utils v0.8.18 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking termcolor v1.4.0 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Compiling ripgrep v14.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking textwrap v0.16.0 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking grep-matcher v0.1.7 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking crossbeam-epoch v0.9.17 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking crossbeam-deque v0.8.4 [INFO] [stderr] Checking memmap2 v0.9.3 [INFO] [stderr] Checking encoding_rs_io v0.1.7 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Checking bstr v1.9.0 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking grep-searcher v0.1.13 [INFO] [stderr] Checking grep-regex v0.1.12 [INFO] [stderr] Checking grep-printer v0.2.1 [INFO] [stderr] Checking grep-cli v0.1.10 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Checking grep v0.3.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/main.rs:183:18 [INFO] [stdout] | [INFO] [stdout] 181 | let mut searcher = searcher.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | [INFO] [stdout] 183 | Box::new(move |result| { [INFO] [stdout] | __________________^ [INFO] [stdout] 184 | | let haystack = match haystack_builder.build_from_result(result) { [INFO] [stdout] 185 | | Some(haystack) => haystack, [INFO] [stdout] 186 | | None => return WalkState::Continue, [INFO] [stdout] ... | [INFO] [stdout] 216 | | } [INFO] [stdout] 217 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/main.rs:300:18 [INFO] [stdout] | [INFO] [stdout] 298 | let tx = tx.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | [INFO] [stdout] 300 | Box::new(move |result| { [INFO] [stdout] | __________________^ [INFO] [stdout] 301 | | let haystack = match haystack_builder.build_from_result(result) { [INFO] [stdout] 302 | | Some(haystack) => haystack, [INFO] [stdout] 303 | | None => return WalkState::Continue, [INFO] [stdout] ... | [INFO] [stdout] 313 | | } [INFO] [stdout] 314 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/flags/config.rs:61:11 [INFO] [stdout] | [INFO] [stdout] 58 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | match std::fs::File::open(&path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/flags/config.rs:101:8 [INFO] [stdout] | [INFO] [stdout] 79 | rdr: R, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | ) -> anyhow::Result<(Vec, Vec)> { [INFO] [stdout] 81 | let mut bufrdr = std::io::BufReader::new(rdr); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let (mut args, mut errs) = (vec![], vec![]); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Ok((args, errs)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/flags/hiargs.rs:250:12 [INFO] [stdout] | [INFO] [stdout] 147 | let hyperlink_config = take_hyperlink_config(&mut state, &mut low)?; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | let stats = stats(&low); [INFO] [stdout] 149 | let types = types(&low)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | let globs = globs(&state, &low)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | let pre_globs = preprocessor_globs(&state, &low)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | Ok(HiArgs { [INFO] [stdout] | ____________^ [INFO] [stdout] 251 | | mode: low.mode, [INFO] [stdout] 252 | | patterns, [INFO] [stdout] 253 | | paths, [INFO] [stdout] ... | [INFO] [stdout] 318 | | with_filename, [INFO] [stdout] 319 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/flags/hiargs.rs:511:12 [INFO] [stdout] | [INFO] [stdout] 505 | let m = match builder.build_many(&self.patterns.patterns) { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 506 | Ok(m) => m, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 507 | Err(err) => { [INFO] [stdout] 508 | anyhow::bail!(suggest_text(suggest_multiline(err.to_string()))) [INFO] [stdout] | --------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 511 | Ok(PatternMatcher::RustRegex(m)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/flags/hiargs.rs:580:26 [INFO] [stdout] | [INFO] [stdout] 562 | wtr: W, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 580 | Printer::Summary(self.printer_summary(wtr, summary_kind)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/flags/hiargs.rs:645:9 [INFO] [stdout] | [INFO] [stdout] 642 | wtr: W, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 645 | grep::printer::SummaryBuilder::new() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/flags/hiargs.rs:648:24 [INFO] [stdout] | [INFO] [stdout] 642 | wtr: W, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 648 | .hyperlink(self.hyperlink_config.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/flags/hiargs.rs:698:12 [INFO] [stdout] | [INFO] [stdout] 687 | matcher: PatternMatcher, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 688 | searcher: grep::searcher::Searcher, [INFO] [stdout] 689 | printer: Printer, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 690 | ) -> anyhow::Result> { [INFO] [stdout] 691 | let mut builder = SearchWorkerBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 698 | Ok(builder.build(matcher, searcher, printer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/flags/hiargs.rs:808:18 [INFO] [stdout] | [INFO] [stdout] 754 | haystacks: I, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 772 | let mut with_timestamps: Vec<_> = match sort.kind { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 775 | let mut haystacks = haystacks.collect::>(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 808 | Box::new(with_timestamps.into_iter().map(|(s, _)| s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/flags/hiargs.rs:765:27 [INFO] [stdout] | [INFO] [stdout] 762 | haystacks: impl Iterator, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 763 | get: impl Fn(&Metadata) -> io::Result, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 764 | ) -> impl Iterator)> { [INFO] [stdout] 765 | haystacks.map(move |s| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 766 | | let time = s.path().metadata().and_then(|m| get(&m)).ok(); [INFO] [stdout] 767 | | (s, time) [INFO] [stdout] 768 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/flags/parse.rs:50:38 [INFO] [stdout] | [INFO] [stdout] 50 | parse_low().and_then(|low| match HiArgs::from_low_args(low) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/search.rs:63:21 [INFO] [stdout] | [INFO] [stdout] 59 | let mut decomp_builder = grep::cli::DecompressionReaderBuilder::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | config: Config::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ripgrep` (bin "rg") due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> tests/util.rs:290:13 [INFO] [stdout] | [INFO] [stdout] 290 | Err(err) => { [INFO] [stdout] | ^^^^^^^^ matches no values because `Infallible` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> tests/util.rs:319:13 [INFO] [stdout] | [INFO] [stdout] 319 | Err(err) => { [INFO] [stdout] | ^^^^^^^^ matches no values because `Infallible` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/main.rs:183:18 [INFO] [stdout] | [INFO] [stdout] 181 | let mut searcher = searcher.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | [INFO] [stdout] 183 | Box::new(move |result| { [INFO] [stdout] | __________________^ [INFO] [stdout] 184 | | let haystack = match haystack_builder.build_from_result(result) { [INFO] [stdout] 185 | | Some(haystack) => haystack, [INFO] [stdout] 186 | | None => return WalkState::Continue, [INFO] [stdout] ... | [INFO] [stdout] 216 | | } [INFO] [stdout] 217 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/main.rs:300:18 [INFO] [stdout] | [INFO] [stdout] 298 | let tx = tx.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | [INFO] [stdout] 300 | Box::new(move |result| { [INFO] [stdout] | __________________^ [INFO] [stdout] 301 | | let haystack = match haystack_builder.build_from_result(result) { [INFO] [stdout] 302 | | Some(haystack) => haystack, [INFO] [stdout] 303 | | None => return WalkState::Continue, [INFO] [stdout] ... | [INFO] [stdout] 313 | | } [INFO] [stdout] 314 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/flags/config.rs:61:11 [INFO] [stdout] | [INFO] [stdout] 58 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | match std::fs::File::open(&path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/flags/config.rs:101:8 [INFO] [stdout] | [INFO] [stdout] 79 | rdr: R, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | ) -> anyhow::Result<(Vec, Vec)> { [INFO] [stdout] 81 | let mut bufrdr = std::io::BufReader::new(rdr); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let (mut args, mut errs) = (vec![], vec![]); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Ok((args, errs)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/flags/hiargs.rs:250:12 [INFO] [stdout] | [INFO] [stdout] 147 | let hyperlink_config = take_hyperlink_config(&mut state, &mut low)?; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | let stats = stats(&low); [INFO] [stdout] 149 | let types = types(&low)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | let globs = globs(&state, &low)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | let pre_globs = preprocessor_globs(&state, &low)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | Ok(HiArgs { [INFO] [stdout] | ____________^ [INFO] [stdout] 251 | | mode: low.mode, [INFO] [stdout] 252 | | patterns, [INFO] [stdout] 253 | | paths, [INFO] [stdout] ... | [INFO] [stdout] 318 | | with_filename, [INFO] [stdout] 319 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/flags/hiargs.rs:511:12 [INFO] [stdout] | [INFO] [stdout] 505 | let m = match builder.build_many(&self.patterns.patterns) { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 506 | Ok(m) => m, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 507 | Err(err) => { [INFO] [stdout] 508 | anyhow::bail!(suggest_text(suggest_multiline(err.to_string()))) [INFO] [stdout] | --------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 511 | Ok(PatternMatcher::RustRegex(m)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/flags/hiargs.rs:580:26 [INFO] [stdout] | [INFO] [stdout] 562 | wtr: W, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 580 | Printer::Summary(self.printer_summary(wtr, summary_kind)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/flags/hiargs.rs:645:9 [INFO] [stdout] | [INFO] [stdout] 642 | wtr: W, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 645 | grep::printer::SummaryBuilder::new() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/flags/hiargs.rs:648:24 [INFO] [stdout] | [INFO] [stdout] 642 | wtr: W, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 648 | .hyperlink(self.hyperlink_config.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/flags/hiargs.rs:698:12 [INFO] [stdout] | [INFO] [stdout] 687 | matcher: PatternMatcher, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 688 | searcher: grep::searcher::Searcher, [INFO] [stdout] 689 | printer: Printer, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 690 | ) -> anyhow::Result> { [INFO] [stdout] 691 | let mut builder = SearchWorkerBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 698 | Ok(builder.build(matcher, searcher, printer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/flags/hiargs.rs:808:18 [INFO] [stdout] | [INFO] [stdout] 754 | haystacks: I, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 772 | let mut with_timestamps: Vec<_> = match sort.kind { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 775 | let mut haystacks = haystacks.collect::>(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 808 | Box::new(with_timestamps.into_iter().map(|(s, _)| s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/flags/hiargs.rs:765:27 [INFO] [stdout] | [INFO] [stdout] 762 | haystacks: impl Iterator, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 763 | get: impl Fn(&Metadata) -> io::Result, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 764 | ) -> impl Iterator)> { [INFO] [stdout] 765 | haystacks.map(move |s| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 766 | | let time = s.path().metadata().and_then(|m| get(&m)).ok(); [INFO] [stdout] 767 | | (s, time) [INFO] [stdout] 768 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/flags/parse.rs:50:38 [INFO] [stdout] | [INFO] [stdout] 50 | parse_low().and_then(|low| match HiArgs::from_low_args(low) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/search.rs:63:21 [INFO] [stdout] | [INFO] [stdout] 59 | let mut decomp_builder = grep::cli::DecompressionReaderBuilder::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | config: Config::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ripgrep` (bin "rg" test) due to 15 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/util.rs:457:9 [INFO] [stdout] | [INFO] [stdout] 447 | fn repeat io::Result<()>>(mut f: F) -> io::Result<()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 448 | let mut last_err = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 457 | Err(last_err.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/util.rs:464:5 [INFO] [stdout] | [INFO] [stdout] 463 | fn dir_list>(dir: P) -> Vec { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 464 | / walkdir::WalkDir::new(dir) [INFO] [stdout] 465 | | .follow_links(true) [INFO] [stdout] 466 | | .into_iter() [INFO] [stdout] 467 | | .map(|result| result.unwrap().path().to_string_lossy().into_owned()) [INFO] [stdout] | |____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ripgrep` (test "integration") due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c88573e0f409cc498c88d2591b97bb61311ce797a11129b5d23f1667bce8cb30", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c88573e0f409cc498c88d2591b97bb61311ce797a11129b5d23f1667bce8cb30", kill_on_drop: false }` [INFO] [stdout] c88573e0f409cc498c88d2591b97bb61311ce797a11129b5d23f1667bce8cb30