[INFO] fetching crate ring-algorithm 0.7.0... [INFO] checking ring-algorithm-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ring-algorithm 0.7.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate ring-algorithm 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ring-algorithm 0.7.0 [INFO] finished tweaking crates.io crate ring-algorithm 0.7.0 [INFO] tweaked toml for crates.io crate ring-algorithm 0.7.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 102 packages to latest compatible versions [INFO] [stderr] Adding auto-impl-ops v0.1.2 (latest: v0.2.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding derive-syn-parse v0.1.5 (latest: v0.2.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding ring-algorithm v0.6.1 (latest: v0.7.0) [INFO] [stderr] Adding strum v0.24.1 (latest: v0.26.3) [INFO] [stderr] Adding strum_macros v0.24.3 (latest: v0.26.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e14f0d926be690ecb16683d00f7f827c000eb9dd1026b227212f27ff8424c464 [INFO] running `Command { std: "docker" "start" "-a" "e14f0d926be690ecb16683d00f7f827c000eb9dd1026b227212f27ff8424c464", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e14f0d926be690ecb16683d00f7f827c000eb9dd1026b227212f27ff8424c464", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e14f0d926be690ecb16683d00f7f827c000eb9dd1026b227212f27ff8424c464", kill_on_drop: false }` [INFO] [stdout] e14f0d926be690ecb16683d00f7f827c000eb9dd1026b227212f27ff8424c464 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ed99b98df4ab714b0ccfba15af77a82a0c304d57ab2ff6c7950c0703b2d5e355 [INFO] running `Command { std: "docker" "start" "-a" "ed99b98df4ab714b0ccfba15af77a82a0c304d57ab2ff6c7950c0703b2d5e355", kill_on_drop: false }` [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling take_mut v0.2.2 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling derive-syn-parse v0.1.5 [INFO] [stderr] Checking ring-algorithm v0.6.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling strum v0.24.1 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking is-prime-for-primitive-int v0.5.1 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking ring-algorithm v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait `SizedExt` is never used [INFO] [stdout] --> src/lib.rs:5:15 [INFO] [stdout] | [INFO] [stdout] 5 | pub trait SizedExt: std::marker::Sized + std::fmt::Debug + std::fmt::Display {} [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn is_coprime(x: T, y: T) -> bool [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | gcd::(x, y).into_normalize().is_one() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:273:21 [INFO] [stdout] | [INFO] [stdout] 271 | .fold(p, |(t, n), (m_j, v_j)| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 272 | ( [INFO] [stdout] 273 | T::from(&T::from(v_j + &T::from(m_j * &t)) % m_i), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:274:21 [INFO] [stdout] | [INFO] [stdout] 271 | .fold(p, |(t, n), (m_j, v_j)| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | T::from(&T::from(&n * m_j) % m_i), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:435:5 [INFO] [stdout] | [INFO] [stdout] 434 | let m2 = m.iter().map(|m| T::from(m * m)).collect::>(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 435 | / modular_reduction::(big_m, &m2) [INFO] [stdout] 436 | | .into_iter() [INFO] [stdout] 437 | | .zip(m.iter()) [INFO] [stdout] 438 | | .map(|(v, m)| modulo_inverse::(T::from(&v / m), m.clone()).unwrap()) [INFO] [stdout] | |_______________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:434:39 [INFO] [stdout] | [INFO] [stdout] 434 | let m2 = m.iter().map(|m| T::from(m * m)).collect::>(); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:438:23 [INFO] [stdout] | [INFO] [stdout] 438 | .map(|(v, m)| modulo_inverse::(T::from(&v / m), m.clone()).unwrap()) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:487:31 [INFO] [stdout] | [INFO] [stdout] 487 | .map(|(s, u)| T::from(s * u)) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ring-algorithm` (lib) due to 8 previous errors; 1 warning emitted [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "ed99b98df4ab714b0ccfba15af77a82a0c304d57ab2ff6c7950c0703b2d5e355", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed99b98df4ab714b0ccfba15af77a82a0c304d57ab2ff6c7950c0703b2d5e355", kill_on_drop: false }` [INFO] [stdout] ed99b98df4ab714b0ccfba15af77a82a0c304d57ab2ff6c7950c0703b2d5e355