[INFO] fetching crate riffu 4.0.1... [INFO] checking riffu-4.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate riffu 4.0.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate riffu 4.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate riffu 4.0.1 [INFO] finished tweaking crates.io crate riffu 4.0.1 [INFO] tweaked toml for crates.io crate riffu 4.0.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 72 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 60de100f48cf05b56f78a1e9d90bd0600c9863d28619f706afb9fb82a6b4d472 [INFO] running `Command { std: "docker" "start" "-a" "60de100f48cf05b56f78a1e9d90bd0600c9863d28619f706afb9fb82a6b4d472", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "60de100f48cf05b56f78a1e9d90bd0600c9863d28619f706afb9fb82a6b4d472", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "60de100f48cf05b56f78a1e9d90bd0600c9863d28619f706afb9fb82a6b4d472", kill_on_drop: false }` [INFO] [stdout] 60de100f48cf05b56f78a1e9d90bd0600c9863d28619f706afb9fb82a6b4d472 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 212770d56c6c16ee8658d1d05d0796b6e5c9732ad40f192334758cab9dfeb339 [INFO] running `Command { std: "docker" "start" "-a" "212770d56c6c16ee8658d1d05d0796b6e5c9732ad40f192334758cab9dfeb339", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking riffu v4.0.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/riff.rs:105:33 [INFO] [stdout] | [INFO] [stdout] 105 | Chunk::Raw(data) => (data), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 105 - Chunk::Raw(data) => (data), [INFO] [stdout] 105 + Chunk::Raw(data) => data, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/riff.rs:106:34 [INFO] [stdout] | [INFO] [stdout] 106 | Chunk::List(data) => (data), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 106 - Chunk::List(data) => (data), [INFO] [stdout] 106 + Chunk::List(data) => data, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/riff.rs:107:34 [INFO] [stdout] | [INFO] [stdout] 107 | Chunk::Seqt(data) => (data), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 107 - Chunk::Seqt(data) => (data), [INFO] [stdout] 107 + Chunk::Seqt(data) => data, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:12:34 [INFO] [stdout] | [INFO] [stdout] 11 | fn from(v: $error) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | RiffError::Other(Box::new(v)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 19 | impl_error!(std::io::Error); [INFO] [stdout] | --------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `impl_error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/riff.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn from_path

(path: P) -> RiffResult [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | let inner = unsafe { Mmap::map(&File::open(&path)?)? }; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Ok(Riff { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `riffu` (lib) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "212770d56c6c16ee8658d1d05d0796b6e5c9732ad40f192334758cab9dfeb339", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "212770d56c6c16ee8658d1d05d0796b6e5c9732ad40f192334758cab9dfeb339", kill_on_drop: false }` [INFO] [stdout] 212770d56c6c16ee8658d1d05d0796b6e5c9732ad40f192334758cab9dfeb339