[INFO] fetching crate riffol 0.3.0... [INFO] checking riffol-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate riffol 0.3.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate riffol 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate riffol 0.3.0 [INFO] finished tweaking crates.io crate riffol 0.3.0 [INFO] tweaked toml for crates.io crate riffol 0.3.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 131 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding arrayvec v0.4.12 (latest: v0.7.6) [INFO] [stderr] Adding atty v0.2.11 (latest: v0.2.14) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding crossbeam-channel v0.2.6 (latest: v0.5.13) [INFO] [stderr] Adding crossbeam-epoch v0.6.1 (latest: v0.9.18) [INFO] [stderr] Adding crossbeam-utils v0.5.0 (latest: v0.8.20) [INFO] [stderr] Adding crossbeam-utils v0.6.6 (latest: v0.8.20) [INFO] [stderr] Adding error-chain v0.11.0 (latest: v0.12.4) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding lazy_static v0.2.11 (latest: v1.5.0) [INFO] [stderr] Adding lock_api v0.1.5 (latest: v0.4.12) [INFO] [stderr] Adding memoffset v0.2.1 (latest: v0.9.1) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding nereon v0.4.4 (latest: v0.6.0) [INFO] [stderr] Adding nereon_derive v0.4.3 (latest: v0.6.0) [INFO] [stderr] Adding nix v0.11.1 (latest: v0.29.0) [INFO] [stderr] Adding numtoa v0.1.0 (latest: v0.2.4) [INFO] [stderr] Adding parking_lot v0.6.4 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.3.1 (latest: v0.9.10) [INFO] [stderr] Adding proc-macro2 v0.4.30 (latest: v1.0.86) [INFO] [stderr] Adding quote v0.6.13 (latest: v1.0.37) [INFO] [stderr] Adding rand v0.5.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding scopeguard v0.3.3 (latest: v1.2.0) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding signal-hook v0.1.17 (latest: v0.3.17) [INFO] [stderr] Adding smallvec v0.6.14 (latest: v1.13.2) [INFO] [stderr] Adding stderrlog v0.4.3 (latest: v0.6.0) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v0.15.44 (latest: v2.0.77) [INFO] [stderr] Adding syslog v4.0.1 (latest: v7.0.0) [INFO] [stderr] Adding termion v1.5.6 (latest: v4.0.2) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding thread_local v0.3.4 (latest: v1.1.8) [INFO] [stderr] Adding time v0.1.45 (latest: v0.3.36) [INFO] [stderr] Adding unicode-xid v0.1.0 (latest: v0.2.5) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8ae008dd7ed4d6841f0e8e71630bcd89e5193b48a7cf5912207d910c24fd8b2b [INFO] running `Command { std: "docker" "start" "-a" "8ae008dd7ed4d6841f0e8e71630bcd89e5193b48a7cf5912207d910c24fd8b2b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8ae008dd7ed4d6841f0e8e71630bcd89e5193b48a7cf5912207d910c24fd8b2b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ae008dd7ed4d6841f0e8e71630bcd89e5193b48a7cf5912207d910c24fd8b2b", kill_on_drop: false }` [INFO] [stdout] 8ae008dd7ed4d6841f0e8e71630bcd89e5193b48a7cf5912207d910c24fd8b2b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f79995712969b7721f2e3615d739039788519401873031c244dbc2cf5d2b5d1c [INFO] running `Command { std: "docker" "start" "-a" "f79995712969b7721f2e3615d739039788519401873031c244dbc2cf5d2b5d1c", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking owning_ref v0.4.1 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking lock_api v0.1.5 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Compiling parking_lot_core v0.3.1 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Compiling nix v0.11.1 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking thread_local v0.3.4 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Checking crossbeam-utils v0.5.0 [INFO] [stderr] Checking signal-hook v0.1.17 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking stderrlog v0.4.3 [INFO] [stderr] Compiling nereon_derive v0.4.3 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking syslog v4.0.1 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling pest v2.7.11 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking nereon v0.4.4 [INFO] [stderr] Checking riffol v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `statvfs64` [INFO] [stdout] --> src/health.rs:132:15 [INFO] [stdout] | [INFO] [stdout] 132 | #[cfg(statvfs64)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(statvfs64)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(statvfs64)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `statvfs64` [INFO] [stdout] --> src/health.rs:145:19 [INFO] [stdout] | [INFO] [stdout] 145 | #[cfg(not(statvfs64))] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(statvfs64)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(statvfs64)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `statvfs64` [INFO] [stdout] --> src/health.rs:132:15 [INFO] [stdout] | [INFO] [stdout] 132 | #[cfg(statvfs64)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(statvfs64)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(statvfs64)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/health.rs:149:50 [INFO] [stdout] | [INFO] [stdout] 149 | let mut stats: statvfs = ::std::mem::uninitialized(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `statvfs64` [INFO] [stdout] --> src/health.rs:145:19 [INFO] [stdout] | [INFO] [stdout] 145 | #[cfg(not(statvfs64))] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(statvfs64)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(statvfs64)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/health.rs:149:50 [INFO] [stdout] | [INFO] [stdout] 149 | let mut stats: statvfs = ::std::mem::uninitialized(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::os::unix::process::CommandExt::before_exec`: should be unsafe, use `pre_exec` instead [INFO] [stdout] --> src/application.rs:289:14 [INFO] [stdout] | [INFO] [stdout] 289 | .before_exec(move || { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::os::unix::process::CommandExt::before_exec`: should be unsafe, use `pre_exec` instead [INFO] [stdout] --> src/application.rs:289:14 [INFO] [stdout] | [INFO] [stdout] 289 | .before_exec(move || { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/stream.rs:176:21 [INFO] [stdout] | [INFO] [stdout] 176 | let mut connection = connections.get_mut(handle).unwrap(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/stream.rs:195:21 [INFO] [stdout] | [INFO] [stdout] 195 | let mut connection = connections.remove(handle); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/stream.rs:243:17 [INFO] [stdout] | [INFO] [stdout] 243 | let mut logger: syslog::Result< [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:262:21 [INFO] [stdout] | [INFO] [stdout] 261 | check.checks.iter().try_fold(checks, |mut checks, params| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | mk_interval_healthcheck(group, check.interval, check.timeout, params).map( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:263:25 [INFO] [stdout] | [INFO] [stdout] 261 | check.checks.iter().try_fold(checks, |mut checks, params| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | mk_interval_healthcheck(group, check.interval, check.timeout, params).map( [INFO] [stdout] 263 | / |check| { [INFO] [stdout] 264 | | checks.push(check); [INFO] [stdout] 265 | | checks [INFO] [stdout] 266 | | }, [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `libc::statvfs` does not permit being left uninitialized [INFO] [stdout] --> src/health.rs:149:38 [INFO] [stdout] | [INFO] [stdout] 149 | let mut stats: statvfs = ::std::mem::uninitialized(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/health.rs:193:17 [INFO] [stdout] | [INFO] [stdout] 192 | .and_then(|mut it| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | / it.find(|ref result| { [INFO] [stdout] 194 | | result [INFO] [stdout] 195 | | .as_ref() [INFO] [stdout] 196 | | .ok() [INFO] [stdout] ... | [INFO] [stdout] 210 | | }).unwrap_or(false) [INFO] [stdout] 211 | | }).ok_or_else(|| "No such process".to_owned()) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/stream.rs:176:21 [INFO] [stdout] | [INFO] [stdout] 176 | let mut connection = connections.get_mut(handle).unwrap(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/stream.rs:195:21 [INFO] [stdout] | [INFO] [stdout] 195 | let mut connection = connections.remove(handle); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/health.rs:209:60 [INFO] [stdout] | [INFO] [stdout] 209 | ... .map_or_else(|| false, |f| f.bytes().next().is_some()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Option::::map_or` that must be used [INFO] [stdout] --> src/init.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 142 | stop_idx.map_or((), |idx| self.schedule_stop(idx)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the returned value, use `if let` instead [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 142 | let _ = stop_idx.map_or((), |idx| self.schedule_stop(idx)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:108:21 [INFO] [stdout] | [INFO] [stdout] 105 | let (tx, rx) = cc::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | thread: Some(thread::spawn(move || { [INFO] [stdout] | _____________________^ [INFO] [stdout] 109 | | handler(&rx); [INFO] [stdout] 110 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/stream.rs:243:17 [INFO] [stdout] | [INFO] [stdout] 243 | let mut logger: syslog::Result< [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:262:21 [INFO] [stdout] | [INFO] [stdout] 261 | check.checks.iter().try_fold(checks, |mut checks, params| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | mk_interval_healthcheck(group, check.interval, check.timeout, params).map( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:263:25 [INFO] [stdout] | [INFO] [stdout] 261 | check.checks.iter().try_fold(checks, |mut checks, params| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | mk_interval_healthcheck(group, check.interval, check.timeout, params).map( [INFO] [stdout] 263 | / |check| { [INFO] [stdout] 264 | | checks.push(check); [INFO] [stdout] 265 | | checks [INFO] [stdout] 266 | | }, [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `libc::statvfs` does not permit being left uninitialized [INFO] [stdout] --> src/health.rs:149:38 [INFO] [stdout] | [INFO] [stdout] 149 | let mut stats: statvfs = ::std::mem::uninitialized(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/health.rs:193:17 [INFO] [stdout] | [INFO] [stdout] 192 | .and_then(|mut it| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | / it.find(|ref result| { [INFO] [stdout] 194 | | result [INFO] [stdout] 195 | | .as_ref() [INFO] [stdout] 196 | | .ok() [INFO] [stdout] ... | [INFO] [stdout] 210 | | }).unwrap_or(false) [INFO] [stdout] 211 | | }).ok_or_else(|| "No such process".to_owned()) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `riffol` (lib test) due to 6 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/health.rs:209:60 [INFO] [stdout] | [INFO] [stdout] 209 | ... .map_or_else(|| false, |f| f.bytes().next().is_some()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Option::::map_or` that must be used [INFO] [stdout] --> src/init.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 142 | stop_idx.map_or((), |idx| self.schedule_stop(idx)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the returned value, use `if let` instead [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 142 | let _ = stop_idx.map_or((), |idx| self.schedule_stop(idx)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:108:21 [INFO] [stdout] | [INFO] [stdout] 105 | let (tx, rx) = cc::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | thread: Some(thread::spawn(move || { [INFO] [stdout] | _____________________^ [INFO] [stdout] 109 | | handler(&rx); [INFO] [stdout] 110 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `riffol` (lib) due to 6 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f79995712969b7721f2e3615d739039788519401873031c244dbc2cf5d2b5d1c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f79995712969b7721f2e3615d739039788519401873031c244dbc2cf5d2b5d1c", kill_on_drop: false }` [INFO] [stdout] f79995712969b7721f2e3615d739039788519401873031c244dbc2cf5d2b5d1c