[INFO] fetching crate ri2p 1.0.0... [INFO] checking ri2p-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ri2p 1.0.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate ri2p 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ri2p 1.0.0 [INFO] finished tweaking crates.io crate ri2p 1.0.0 [INFO] tweaked toml for crates.io crate ri2p 1.0.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate ri2p 1.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 62e2481ac805684d638a0709773849868100872ad81b13b865a0d07fcfbc10f1 [INFO] running `Command { std: "docker" "start" "-a" "62e2481ac805684d638a0709773849868100872ad81b13b865a0d07fcfbc10f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "62e2481ac805684d638a0709773849868100872ad81b13b865a0d07fcfbc10f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "62e2481ac805684d638a0709773849868100872ad81b13b865a0d07fcfbc10f1", kill_on_drop: false }` [INFO] [stdout] 62e2481ac805684d638a0709773849868100872ad81b13b865a0d07fcfbc10f1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dc12373282a832f263c067b71a3d6c6996b8710a942b52e7004b2080e4683822 [INFO] running `Command { std: "docker" "start" "-a" "dc12373282a832f263c067b71a3d6c6996b8710a942b52e7004b2080e4683822", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Compiling radium v0.5.3 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling nom v6.1.2 [INFO] [stderr] Checking bitvec v0.19.5 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking nom-unicode v0.2.0 [INFO] [stderr] Checking ri2p v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proto/stream.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 12 | let session = match I2pSession::stream() { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | let socket = match I2pStreamSocket::connected() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | Ok(I2pStream { [INFO] [stdout] | ________^ [INFO] [stdout] 27 | | session: session, [INFO] [stdout] 28 | | socket: socket, [INFO] [stdout] 29 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proto/datagram.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 20 | let session = match I2pSession::datagram(SessionType::AnonymousDatagram, port) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | let socket = match I2pDatagramSocket::new(port) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | Ok(I2pRawSocket { [INFO] [stdout] | ____________^ [INFO] [stdout] 35 | | session: session, [INFO] [stdout] 36 | | socket: socket, [INFO] [stdout] 37 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proto/datagram.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 68 | let session = match I2pSession::datagram(SessionType::RepliableDatagram, port) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let socket = match I2pDatagramSocket::new(port) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | Ok(I2pRepliableSocket { [INFO] [stdout] | ____________^ [INFO] [stdout] 83 | | session: session, [INFO] [stdout] 84 | | socket: socket, [INFO] [stdout] 85 | | buffer: vec![0; 65536], [INFO] [stdout] 86 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 25 | let mut socket = match I2pStreamSocket::connected() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | Ok(I2pSession { [INFO] [stdout] | ____________^ [INFO] [stdout] 58 | | socket: socket, [INFO] [stdout] 59 | | nick: nick.to_string(), [INFO] [stdout] 60 | | local: dest.to_string(), [INFO] [stdout] 61 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 67 | let mut socket = match I2pStreamSocket::connected() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Ok(I2pSession { [INFO] [stdout] | ____________^ [INFO] [stdout] 100 | | socket: socket, [INFO] [stdout] 101 | | nick: nick.to_string(), [INFO] [stdout] 102 | | local: dest.to_string(), [INFO] [stdout] 103 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ri2p` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proto/stream.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 12 | let session = match I2pSession::stream() { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | let socket = match I2pStreamSocket::connected() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | Ok(I2pStream { [INFO] [stdout] | ________^ [INFO] [stdout] 27 | | session: session, [INFO] [stdout] 28 | | socket: socket, [INFO] [stdout] 29 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proto/datagram.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 20 | let session = match I2pSession::datagram(SessionType::AnonymousDatagram, port) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | let socket = match I2pDatagramSocket::new(port) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | Ok(I2pRawSocket { [INFO] [stdout] | ____________^ [INFO] [stdout] 35 | | session: session, [INFO] [stdout] 36 | | socket: socket, [INFO] [stdout] 37 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proto/datagram.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 68 | let session = match I2pSession::datagram(SessionType::RepliableDatagram, port) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let socket = match I2pDatagramSocket::new(port) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | Ok(I2pRepliableSocket { [INFO] [stdout] | ____________^ [INFO] [stdout] 83 | | session: session, [INFO] [stdout] 84 | | socket: socket, [INFO] [stdout] 85 | | buffer: vec![0; 65536], [INFO] [stdout] 86 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 25 | let mut socket = match I2pStreamSocket::connected() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | Ok(I2pSession { [INFO] [stdout] | ____________^ [INFO] [stdout] 58 | | socket: socket, [INFO] [stdout] 59 | | nick: nick.to_string(), [INFO] [stdout] 60 | | local: dest.to_string(), [INFO] [stdout] 61 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 67 | let mut socket = match I2pStreamSocket::connected() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Ok(I2pSession { [INFO] [stdout] | ____________^ [INFO] [stdout] 100 | | socket: socket, [INFO] [stdout] 101 | | nick: nick.to_string(), [INFO] [stdout] 102 | | local: dest.to_string(), [INFO] [stdout] 103 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ri2p` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "dc12373282a832f263c067b71a3d6c6996b8710a942b52e7004b2080e4683822", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc12373282a832f263c067b71a3d6c6996b8710a942b52e7004b2080e4683822", kill_on_drop: false }` [INFO] [stdout] dc12373282a832f263c067b71a3d6c6996b8710a942b52e7004b2080e4683822