[INFO] fetching crate rhyper 0.14.33... [INFO] checking rhyper-0.14.33 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rhyper 0.14.33 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate rhyper 0.14.33 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rhyper 0.14.33 [INFO] finished tweaking crates.io crate rhyper 0.14.33 [INFO] tweaked toml for crates.io crate rhyper 0.14.33 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate rhyper 0.14.33 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d87677d69db0b757fa58d1b9d083fed8639c8fdeb955bfd8b34b3eddba9d79e2 [INFO] running `Command { std: "docker" "start" "-a" "d87677d69db0b757fa58d1b9d083fed8639c8fdeb955bfd8b34b3eddba9d79e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d87677d69db0b757fa58d1b9d083fed8639c8fdeb955bfd8b34b3eddba9d79e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d87677d69db0b757fa58d1b9d083fed8639c8fdeb955bfd8b34b3eddba9d79e2", kill_on_drop: false }` [INFO] [stdout] d87677d69db0b757fa58d1b9d083fed8639c8fdeb955bfd8b34b3eddba9d79e2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c9cf2f683268274070f257a590f8e647bc84a15a6dc5d10cbb4d6ca3cbbfd29d [INFO] running `Command { std: "docker" "start" "-a" "c9cf2f683268274070f257a590f8e647bc84a15a6dc5d10cbb4d6ca3cbbfd29d", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.206 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling serde_json v1.0.124 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Compiling syn v2.0.74 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking pnet_sys v0.27.2 [INFO] [stderr] Checking pnet_base v0.27.2 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Checking spmc v0.3.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling serde_derive v1.0.206 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking rhyper v0.14.33 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/body/body.rs:277:13 [INFO] [stdout] | [INFO] [stdout] 277 | Some(delay_eof) => match delay_eof {}, [INFO] [stdout] | ^^^^^^^^^^^^^^^ matches no values because `DelayEof` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/body/body.rs:454:25 [INFO] [stdout] | [INFO] [stdout] 454 | struct Full<'a>(&'a Bytes); [INFO] [stdout] | ---- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `Full` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `AssertSendSync` is never used [INFO] [stdout] --> src/error.rs:617:7 [INFO] [stdout] | [INFO] [stdout] 617 | trait AssertSendSync: Send + Sync + 'static {} [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `HeaderCaseMap` is never constructed [INFO] [stdout] --> src/ext.rs:98:19 [INFO] [stdout] | [INFO] [stdout] 98 | pub(crate) struct HeaderCaseMap(HeaderMap); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `poll_ready` and `call` are never used [INFO] [stdout] --> src/service/http.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub trait HttpService: sealed::Sealed { [INFO] [stdout] | ----------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 24 | fn poll_ready(&mut self, cx: &mut Context<'_>) -> Poll>; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 27 | fn call(&mut self, req: Request) -> Self::Future; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `poll_ready` and `make_connection` are never used [INFO] [stdout] --> src/service/make.rs:18:8 [INFO] [stdout] | [INFO] [stdout] 13 | pub trait MakeConnection: self::sealed::Sealed<(Target,)> { [INFO] [stdout] | -------------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 18 | fn poll_ready(&mut self, cx: &mut Context<'_>) -> Poll>; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 19 | fn make_connection(&mut self, target: Target) -> Self::Future; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `poll_ready_ref` and `make_service_ref` are never used [INFO] [stdout] --> src/service/make.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 44 | pub trait MakeServiceRef: self::sealed::Sealed<(Target, ReqBody)> { [INFO] [stdout] | -------------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 62 | fn poll_ready_ref(&mut self, cx: &mut Context<'_>) -> Poll>; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 63 | [INFO] [stdout] 64 | fn make_service_ref(&mut self, target: &Target) -> Self::Future; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `CantImpl` is never used [INFO] [stdout] --> src/service/make.rs:182:15 [INFO] [stdout] | [INFO] [stdout] 182 | pub trait CantImpl {} [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/io/rewind.rs:27:18 [INFO] [stdout] | [INFO] [stdout] 25 | pub(crate) fn new_buffered(io: T, buf: Bytes) -> Self { [INFO] [stdout] | ----- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Rewind { [INFO] [stdout] 27 | pre: Some(buf), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/io/rewind.rs:39:22 [INFO] [stdout] | [INFO] [stdout] 38 | pub(crate) fn into_inner(self) -> (T, Bytes) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | (self.inner, self.pre.unwrap_or_else(Bytes::new)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/watch.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 24 | let shared = Arc::new(Shared { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | / Sender { [INFO] [stdout] 31 | | shared: shared.clone(), [INFO] [stdout] 32 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/watch.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 24 | let shared = Arc::new(Shared { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Receiver { shared }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/body/body.rs:203:29 [INFO] [stdout] | [INFO] [stdout] 202 | fn new(kind: Kind) -> Body { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | Body { kind, extra: None } [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/body/body.rs:606:9 [INFO] [stdout] | [INFO] [stdout] 605 | pub fn try_send_data(&mut self, chunk: Bytes) -> Result<(), Bytes> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 606 | / self.data_tx [INFO] [stdout] 607 | | .try_send(Ok(chunk)) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/body/body.rs:608:28 [INFO] [stdout] | [INFO] [stdout] 608 | .map_err(|err| err.into_inner().expect("just sent Ok")) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upgrade.rs:140:15 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn downcast(self) -> Result, Self> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | let (io, buf) = self.io.into_inner(); [INFO] [stdout] | -- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | match io.__hyper_downcast() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upgrade.rs:306:13 [INFO] [stdout] | [INFO] [stdout] 305 | fn on_upgrade(mut self) -> OnUpgrade { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | / self.extensions_mut() [INFO] [stdout] 307 | | .remove::() [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upgrade.rs:322:13 [INFO] [stdout] | [INFO] [stdout] 321 | fn on_upgrade(mut self) -> OnUpgrade { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 322 | / self.extensions_mut() [INFO] [stdout] 323 | | .remove::() [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rhyper` (lib) due to 11 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "c9cf2f683268274070f257a590f8e647bc84a15a6dc5d10cbb4d6ca3cbbfd29d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c9cf2f683268274070f257a590f8e647bc84a15a6dc5d10cbb4d6ca3cbbfd29d", kill_on_drop: false }` [INFO] [stdout] c9cf2f683268274070f257a590f8e647bc84a15a6dc5d10cbb4d6ca3cbbfd29d