[INFO] fetching crate rg_formats 0.1.2... [INFO] checking rg_formats-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rg_formats 0.1.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate rg_formats 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rg_formats 0.1.2 [INFO] finished tweaking crates.io crate rg_formats 0.1.2 [INFO] tweaked toml for crates.io crate rg_formats 0.1.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate rg_formats 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4e56ae32e855acbfb7f98de3a967398426f529ca582627015785cbf804e7b09f [INFO] running `Command { std: "docker" "start" "-a" "4e56ae32e855acbfb7f98de3a967398426f529ca582627015785cbf804e7b09f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4e56ae32e855acbfb7f98de3a967398426f529ca582627015785cbf804e7b09f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4e56ae32e855acbfb7f98de3a967398426f529ca582627015785cbf804e7b09f", kill_on_drop: false }` [INFO] [stdout] 4e56ae32e855acbfb7f98de3a967398426f529ca582627015785cbf804e7b09f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 915e1d410439b6406d02f5dca4813d973b267d563978d946dc2e7880f89f3aed [INFO] running `Command { std: "docker" "start" "-a" "915e1d410439b6406d02f5dca4813d973b267d563978d946dc2e7880f89f3aed", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.64 [INFO] [stderr] Compiling quote v1.0.29 [INFO] [stderr] Compiling unicode-ident v1.0.10 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling serde v1.0.171 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling rayon-core v1.11.0 [INFO] [stderr] Checking regex-syntax v0.7.4 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Compiling serde_json v1.0.100 [INFO] [stderr] Compiling rustix v0.38.3 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Checking crossbeam-epoch v0.9.15 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking ryu v1.0.14 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking ciborium-io v0.2.1 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Compiling thiserror v1.0.44 [INFO] [stderr] Checking linux-raw-sys v0.4.3 [INFO] [stderr] Checking itoa v1.0.8 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking walkdir v2.3.3 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking ciborium-ll v0.2.1 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking clap_builder v4.3.11 [INFO] [stderr] Checking aho-corasick v1.0.2 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Compiling syn v2.0.25 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking lexical v6.1.1 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Checking regex-automata v0.3.2 [INFO] [stderr] Checking clap v4.3.11 [INFO] [stderr] Compiling serde_derive v1.0.171 [INFO] [stderr] Compiling thiserror-impl v1.0.44 [INFO] [stderr] Checking regex v1.9.1 [INFO] [stderr] Checking rg_formats v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `byte_slice_trim_ascii` has been stable since 1.80.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 30 | #![feature(byte_slice_trim_ascii)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/sm.rs:174:27 [INFO] [stdout] | [INFO] [stdout] 174 | let path = path.as_ref().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 174 - let path = path.as_ref().clone(); [INFO] [stdout] 174 + let path = path.as_ref(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sm.rs:238:5 [INFO] [stdout] | [INFO] [stdout] 235 | pub fn from_path(sm_path: impl AsRef) -> io::Result, LoadError>> { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 238 | Ok(from_bytes(&bytes, sm_path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sm.rs:802:5 [INFO] [stdout] | [INFO] [stdout] 776 | let steps_type = StepsType::from_bytes(&fields[0]); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 781 | let difficulty = match diff.to_ascii_lowercase().as_slice() { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 802 | Ok(ChartData { [INFO] [stdout] | ________^ [INFO] [stdout] 803 | | steps_type, [INFO] [stdout] 804 | | author: author.clone(), [INFO] [stdout] 805 | | difficulty, [INFO] [stdout] 806 | | level, [INFO] [stdout] 807 | | notedata, [INFO] [stdout] 808 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_utils.rs:14:2 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn test_file_read(path: impl AsRef) -> Vec { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | std::fs::read(path).expect(&err_msg) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rg_formats` (lib) due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "915e1d410439b6406d02f5dca4813d973b267d563978d946dc2e7880f89f3aed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "915e1d410439b6406d02f5dca4813d973b267d563978d946dc2e7880f89f3aed", kill_on_drop: false }` [INFO] [stdout] 915e1d410439b6406d02f5dca4813d973b267d563978d946dc2e7880f89f3aed