[INFO] fetching crate rftp 0.1.7... [INFO] checking rftp-0.1.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rftp 0.1.7 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate rftp 0.1.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rftp 0.1.7 [INFO] finished tweaking crates.io crate rftp 0.1.7 [INFO] tweaked toml for crates.io crate rftp 0.1.7 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate rftp 0.1.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 11d23710c82fd7e90982c3b7182f2d26917ab028ab60c33ea1529676ca0c3232 [INFO] running `Command { std: "docker" "start" "-a" "11d23710c82fd7e90982c3b7182f2d26917ab028ab60c33ea1529676ca0c3232", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "11d23710c82fd7e90982c3b7182f2d26917ab028ab60c33ea1529676ca0c3232", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "11d23710c82fd7e90982c3b7182f2d26917ab028ab60c33ea1529676ca0c3232", kill_on_drop: false }` [INFO] [stdout] 11d23710c82fd7e90982c3b7182f2d26917ab028ab60c33ea1529676ca0c3232 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 139d4850bec9ebbe80da72565fb90512753a474da92996af4116834445b1c98c [INFO] running `Command { std: "docker" "start" "-a" "139d4850bec9ebbe80da72565fb90512753a474da92996af4116834445b1c98c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling signal-hook v0.3.14 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Compiling lock_api v0.4.8 [INFO] [stderr] Compiling crossbeam-utils v0.8.11 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking once_cell v1.13.1 [INFO] [stderr] Checking unicode-segmentation v1.9.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking mio v0.8.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossbeam-channel v0.5.6 [INFO] [stderr] Checking rpassword v4.0.5 [INFO] [stderr] Compiling libz-sys v1.1.8 [INFO] [stderr] Compiling openssl-sys v0.9.75 [INFO] [stderr] Compiling libssh2-sys v0.2.23 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking base64 v0.12.3 [INFO] [stderr] Checking tui v0.19.0 [INFO] [stderr] Compiling thiserror-impl v1.0.32 [INFO] [stderr] Checking thiserror v1.0.32 [INFO] [stderr] Checking ssh2 v0.9.3 [INFO] [stderr] Checking rftp v0.1.7 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 43 | let rftp = Rftp::new()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let terminal = Terminal::new(CrosstermBackend::new(stdout()))?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Ok(App { terminal, rftp }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rftp.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 28 | let matches = clap::clap_app!( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | let session = create_session(destination, &username, port, verbose)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let sftp = session.sftp()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let files = Arc::new(Mutex::new(FileList::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | Ok(Rftp { [INFO] [stdout] | ____________^ [INFO] [stdout] 69 | | session, [INFO] [stdout] 70 | | sftp: Arc::new(sftp), [INFO] [stdout] 71 | | files, [INFO] [stdout] ... | [INFO] [stdout] 75 | | user_message: Arc::new(user_message), [INFO] [stdout] 76 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rftp` (bin "rftp") due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 43 | let rftp = Rftp::new()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let terminal = Terminal::new(CrosstermBackend::new(stdout()))?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Ok(App { terminal, rftp }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rftp.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 28 | let matches = clap::clap_app!( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | let session = create_session(destination, &username, port, verbose)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let sftp = session.sftp()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let files = Arc::new(Mutex::new(FileList::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | Ok(Rftp { [INFO] [stdout] | ____________^ [INFO] [stdout] 69 | | session, [INFO] [stdout] 70 | | sftp: Arc::new(sftp), [INFO] [stdout] 71 | | files, [INFO] [stdout] ... | [INFO] [stdout] 75 | | user_message: Arc::new(user_message), [INFO] [stdout] 76 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rftp` (bin "rftp" test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "139d4850bec9ebbe80da72565fb90512753a474da92996af4116834445b1c98c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "139d4850bec9ebbe80da72565fb90512753a474da92996af4116834445b1c98c", kill_on_drop: false }` [INFO] [stdout] 139d4850bec9ebbe80da72565fb90512753a474da92996af4116834445b1c98c