[INFO] fetching crate rfirebird 0.1.0... [INFO] checking rfirebird-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rfirebird 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate rfirebird 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rfirebird 0.1.0 [INFO] finished tweaking crates.io crate rfirebird 0.1.0 [INFO] tweaked toml for crates.io crate rfirebird 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate rfirebird 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a5470e740496ee9cb3fddcd4b30cfb9366d156eddfd253063df2ec1665896b36 [INFO] running `Command { std: "docker" "start" "-a" "a5470e740496ee9cb3fddcd4b30cfb9366d156eddfd253063df2ec1665896b36", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a5470e740496ee9cb3fddcd4b30cfb9366d156eddfd253063df2ec1665896b36", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a5470e740496ee9cb3fddcd4b30cfb9366d156eddfd253063df2ec1665896b36", kill_on_drop: false }` [INFO] [stdout] a5470e740496ee9cb3fddcd4b30cfb9366d156eddfd253063df2ec1665896b36 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7a5db67d73fe095aaf76f770f4b36fa74ac474bf784125b3c56f0bc1296b6005 [INFO] running `Command { std: "docker" "start" "-a" "7a5db67d73fe095aaf76f770f4b36fa74ac474bf784125b3c56f0bc1296b6005", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.100 [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Compiling libc v0.2.133 [INFO] [stderr] Compiling once_cell v1.14.0 [INFO] [stderr] Checking textwrap v0.15.1 [INFO] [stderr] Compiling convert_case v0.5.0 [INFO] [stderr] Checking papergrid v0.5.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling darling_core v0.13.4 [INFO] [stderr] Compiling toml v0.5.9 [INFO] [stderr] Compiling thiserror-impl v1.0.35 [INFO] [stderr] Compiling clap_derive v3.2.18 [INFO] [stderr] Compiling tabled_derive v0.4.0 [INFO] [stderr] Checking tabled v0.8.0 [INFO] [stderr] Compiling thiserror v1.0.35 [INFO] [stderr] Compiling darling_macro v0.13.4 [INFO] [stderr] Compiling proc-macro-crate v1.2.1 [INFO] [stderr] Compiling darling v0.13.4 [INFO] [stderr] Compiling argopt-impl v0.3.0 [INFO] [stderr] Compiling num_enum_derive v0.5.7 [INFO] [stderr] Checking clap v3.2.22 [INFO] [stderr] Checking num_enum v0.5.7 [INFO] [stderr] Checking argopt v0.3.0 [INFO] [stderr] Checking rfirebird v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `pag`, `sequence`, and `count` are never read [INFO] [stdout] --> src/data.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 21 | pub struct DataPage { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 22 | pub pag: Page, [INFO] [stdout] | ^^^ [INFO] [stdout] 23 | /// Sequence nu... [INFO] [stdout] 24 | pub sequence: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 28 | pub count: u16, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DataPage` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `transaction`, `b_page`, `b_line`, `flags`, and `format` are never read [INFO] [stdout] --> src/record.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct RecordHeader { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 10 | /// The id of the transaction that created this record [INFO] [stdout] 11 | pub transaction: i32, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 12 | /// This is the record’s back pointer page [INFO] [stdout] 13 | pub b_page: i32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 14 | /// This is the record’s back line pointer [INFO] [stdout] 15 | pub b_line: u16, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 16 | pub flags: u16, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 17 | /// The record format version [INFO] [stdout] 18 | pub format: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RecordHeader` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn open(buffer: Rc>>) -> Result { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(Self { header, buffer }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:40:24 [INFO] [stdout] | [INFO] [stdout] 37 | let f = File::open(fpath).map_err(|e| e.to_string())?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let bfr = BufReader::new(f); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | [INFO] [stdout] 40 | Database::open(Rc::new(RefCell::new(bfr))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rfirebird` (lib) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `pag`, `sequence`, and `count` are never read [INFO] [stdout] --> src/data.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 21 | pub struct DataPage { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 22 | pub pag: Page, [INFO] [stdout] | ^^^ [INFO] [stdout] 23 | /// Sequence nu... [INFO] [stdout] 24 | pub sequence: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 28 | pub count: u16, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DataPage` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `transaction`, `b_page`, `b_line`, `flags`, and `format` are never read [INFO] [stdout] --> src/record.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct RecordHeader { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 10 | /// The id of the transaction that created this record [INFO] [stdout] 11 | pub transaction: i32, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 12 | /// This is the record’s back pointer page [INFO] [stdout] 13 | pub b_page: i32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 14 | /// This is the record’s back line pointer [INFO] [stdout] 15 | pub b_line: u16, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 16 | pub flags: u16, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 17 | /// The record format version [INFO] [stdout] 18 | pub format: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RecordHeader` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn open(buffer: Rc>>) -> Result { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(Self { header, buffer }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:40:24 [INFO] [stdout] | [INFO] [stdout] 37 | let f = File::open(fpath).map_err(|e| e.to_string())?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let bfr = BufReader::new(f); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | [INFO] [stdout] 40 | Database::open(Rc::new(RefCell::new(bfr))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rfirebird` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7a5db67d73fe095aaf76f770f4b36fa74ac474bf784125b3c56f0bc1296b6005", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7a5db67d73fe095aaf76f770f4b36fa74ac474bf784125b3c56f0bc1296b6005", kill_on_drop: false }` [INFO] [stdout] 7a5db67d73fe095aaf76f770f4b36fa74ac474bf784125b3c56f0bc1296b6005