[INFO] fetching crate rfc2396 1.1.0... [INFO] checking rfc2396-1.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rfc2396 1.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate rfc2396 1.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rfc2396 1.1.0 [INFO] finished tweaking crates.io crate rfc2396 1.1.0 [INFO] tweaked toml for crates.io crate rfc2396 1.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 16 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bitvec v0.19.6 (latest: v1.0.1) [INFO] [stderr] Adding funty v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding lexical-core v0.7.6 (latest: v0.8.5) [INFO] [stderr] Adding memchr v2.3.4 (latest: v2.7.4) [INFO] [stderr] Adding nom v6.2.2 (latest: v7.1.3) [INFO] [stderr] Adding radium v0.5.3 (latest: v1.1.0) [INFO] [stderr] Adding wyz v0.2.0 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 38ee76a606fddc8376d9fcea6639f5858f8b06eb2cc4fc4b623703291ae40a7a [INFO] running `Command { std: "docker" "start" "-a" "38ee76a606fddc8376d9fcea6639f5858f8b06eb2cc4fc4b623703291ae40a7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "38ee76a606fddc8376d9fcea6639f5858f8b06eb2cc4fc4b623703291ae40a7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "38ee76a606fddc8376d9fcea6639f5858f8b06eb2cc4fc4b623703291ae40a7a", kill_on_drop: false }` [INFO] [stdout] 38ee76a606fddc8376d9fcea6639f5858f8b06eb2cc4fc4b623703291ae40a7a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 41ff761fec3f1595fa4f867b175d6d93d5272bcd6a6bb508fef9616c6b100350 [INFO] running `Command { std: "docker" "start" "-a" "41ff761fec3f1595fa4f867b175d6d93d5272bcd6a6bb508fef9616c6b100350", kill_on_drop: false }` [INFO] [stderr] Compiling radium v0.5.3 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking wyz v0.2.0 [INFO] [stderr] Checking funty v1.1.0 [INFO] [stderr] Compiling nom v6.2.2 [INFO] [stderr] Checking bitvec v0.19.6 [INFO] [stderr] Checking rfc2396 v1.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:2:13 [INFO] [stdout] | [INFO] [stdout] 2 | #![cfg_attr(feature = "cargo-clippy", warn(clippy::cargo, clippy::pedantic, clippy::nursery))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::module_name_repetitions, clippy::non_ascii_literal))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn validate_res<'a, S>(uri: S) -> anyhow::Result<&'a str> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | / (match crate::parsers::uri_reference(input) { [INFO] [stdout] 145 | | Ok((_, matched)) => { [INFO] [stdout] 146 | | if matched == input { [INFO] [stdout] 147 | | Ok(input) [INFO] [stdout] ... | [INFO] [stdout] 152 | | Err(error) => Err(anyhow::anyhow!(error.map(|mut e| e.input = input))), [INFO] [stdout] 153 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/combinators.rs:6:32 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn recognize0<'a, F, E>(parser: F) -> impl FnMut(&'a str) -> nom::IResult<&'a str, &'a str, E> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 6 | nom::combinator::recognize(nom::multi::many0_count(parser)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/combinators.rs:14:32 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn recognize1<'a, F, E>(parser: F) -> impl FnMut(&'a str) -> nom::IResult<&'a str, &'a str, E> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | nom::combinator::recognize(nom::multi::many1_count(parser)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/combinators.rs:22:32 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn recognize_tuple<'a, O, L, E>(list: L) -> impl FnMut(&'a str) -> nom::IResult<&'a str, &'a str, E> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | nom::combinator::recognize(nom::sequence::tuple(list)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/combinators.rs:34:32 [INFO] [stdout] | [INFO] [stdout] 26 | first: F, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | second: G, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | nom::combinator::recognize(nom::sequence::pair(first, second)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rfc2396` (lib) due to 6 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:2:13 [INFO] [stdout] | [INFO] [stdout] 2 | #![cfg_attr(feature = "cargo-clippy", warn(clippy::cargo, clippy::pedantic, clippy::nursery))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::module_name_repetitions, clippy::non_ascii_literal))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn validate_res<'a, S>(uri: S) -> anyhow::Result<&'a str> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | / (match crate::parsers::uri_reference(input) { [INFO] [stdout] 145 | | Ok((_, matched)) => { [INFO] [stdout] 146 | | if matched == input { [INFO] [stdout] 147 | | Ok(input) [INFO] [stdout] ... | [INFO] [stdout] 152 | | Err(error) => Err(anyhow::anyhow!(error.map(|mut e| e.input = input))), [INFO] [stdout] 153 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/combinators.rs:6:32 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn recognize0<'a, F, E>(parser: F) -> impl FnMut(&'a str) -> nom::IResult<&'a str, &'a str, E> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 6 | nom::combinator::recognize(nom::multi::many0_count(parser)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/combinators.rs:14:32 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn recognize1<'a, F, E>(parser: F) -> impl FnMut(&'a str) -> nom::IResult<&'a str, &'a str, E> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | nom::combinator::recognize(nom::multi::many1_count(parser)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/combinators.rs:22:32 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn recognize_tuple<'a, O, L, E>(list: L) -> impl FnMut(&'a str) -> nom::IResult<&'a str, &'a str, E> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | nom::combinator::recognize(nom::sequence::tuple(list)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/combinators.rs:34:32 [INFO] [stdout] | [INFO] [stdout] 26 | first: F, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | second: G, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | nom::combinator::recognize(nom::sequence::pair(first, second)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rfc2396` (lib test) due to 6 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "41ff761fec3f1595fa4f867b175d6d93d5272bcd6a6bb508fef9616c6b100350", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "41ff761fec3f1595fa4f867b175d6d93d5272bcd6a6bb508fef9616c6b100350", kill_on_drop: false }` [INFO] [stdout] 41ff761fec3f1595fa4f867b175d6d93d5272bcd6a6bb508fef9616c6b100350