[INFO] fetching crate rfb 0.1.0... [INFO] checking rfb-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rfb 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate rfb 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rfb 0.1.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate rfb 0.1.0 [INFO] tweaked toml for crates.io crate rfb 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate rfb 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9721e9624065180c13763d9fa177c11a422873da779574ae8e98646acc2b4f9e [INFO] running `Command { std: "docker" "start" "-a" "9721e9624065180c13763d9fa177c11a422873da779574ae8e98646acc2b4f9e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9721e9624065180c13763d9fa177c11a422873da779574ae8e98646acc2b4f9e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9721e9624065180c13763d9fa177c11a422873da779574ae8e98646acc2b4f9e", kill_on_drop: false }` [INFO] [stdout] 9721e9624065180c13763d9fa177c11a422873da779574ae8e98646acc2b4f9e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a2f5f426c2bd9869c98189f15b3560b3b8c526ea694cf7fc73ff376a5381e929 [INFO] running `Command { std: "docker" "start" "-a" "a2f5f426c2bd9869c98189f15b3560b3b8c526ea694cf7fc73ff376a5381e929", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.122 [INFO] [stderr] Compiling proc-macro2 v1.0.37 [INFO] [stderr] Compiling syn v1.0.91 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling crossbeam-epoch v0.9.8 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking miniz_oxide v0.5.1 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling parking_lot_core v0.9.2 [INFO] [stderr] Checking deflate v1.0.0 [INFO] [stderr] Compiling num-rational v0.4.0 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking weezl v0.1.5 [INFO] [stderr] Checking crossbeam-channel v0.5.4 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking lebe v0.5.1 [INFO] [stderr] Checking bit_field v0.10.1 [INFO] [stderr] Checking spin v0.9.2 [INFO] [stderr] Compiling anyhow v1.0.56 [INFO] [stderr] Compiling async-trait v0.1.53 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking png v0.17.5 [INFO] [stderr] Checking bytemuck v1.9.1 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking flate2 v1.0.23 [INFO] [stderr] Checking gif v0.11.3 [INFO] [stderr] Checking mio v0.8.2 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Checking jpeg-decoder v0.2.4 [INFO] [stderr] Checking tiff v0.7.2 [INFO] [stderr] Compiling pin-project-internal v1.0.10 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking pin-project v1.0.10 [INFO] [stderr] Checking flume v0.10.12 [INFO] [stderr] Checking exr v1.4.1 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking image v0.24.1 [INFO] [stderr] Checking rfb v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/keysym/mod.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | Unknown(u32), [INFO] [stdout] | ------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Keysym` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 11 | Unknown(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/keysym/mod.rs:12:11 [INFO] [stdout] | [INFO] [stdout] 12 | Utf32(char), [INFO] [stdout] | ----- ^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Keysym` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 12 | Utf32(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/keysym/mod.rs:27:17 [INFO] [stdout] | [INFO] [stdout] 27 | FunctionKey(u8), [INFO] [stdout] | ----------- ^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Keysym` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 27 | FunctionKey(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rfb/mod.rs:301:9 [INFO] [stdout] | [INFO] [stdout] 300 | fn write_to<'a>(self, stream: &'a mut TcpStream) -> BoxFuture<'a, Result<()>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 301 | / async move { [INFO] [stdout] 302 | | let encoding_type: i32 = self.data.get_type().into(); [INFO] [stdout] 303 | | [INFO] [stdout] 304 | | stream.write_u16(self.position.x).await?; [INFO] [stdout] ... | [INFO] [stdout] 313 | | Ok(()) [INFO] [stdout] 314 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rfb/mod.rs:321:9 [INFO] [stdout] | [INFO] [stdout] 320 | fn write_to<'a>(self, stream: &'a mut TcpStream) -> BoxFuture<'a, Result<()>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | / async move { [INFO] [stdout] 322 | | // TODO: type function? [INFO] [stdout] 323 | | stream.write_u8(0).await?; [INFO] [stdout] ... | [INFO] [stdout] 337 | | Ok(()) [INFO] [stdout] 338 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:58:21 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn new(server: S, config: VncServerConfig, data: VncServerData) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | config: Arc::new(config), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:59:19 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn new(server: S, config: VncServerConfig, data: VncServerData) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | data: Arc::new(Mutex::new(data)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:60:21 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn new(server: S, config: VncServerConfig, data: VncServerData) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | server: Arc::new(server), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rfb` (lib test) due to 6 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/keysym/mod.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | Unknown(u32), [INFO] [stdout] | ------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Keysym` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 11 | Unknown(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/keysym/mod.rs:12:11 [INFO] [stdout] | [INFO] [stdout] 12 | Utf32(char), [INFO] [stdout] | ----- ^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Keysym` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 12 | Utf32(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/keysym/mod.rs:27:17 [INFO] [stdout] | [INFO] [stdout] 27 | FunctionKey(u8), [INFO] [stdout] | ----------- ^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Keysym` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 27 | FunctionKey(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rfb/mod.rs:301:9 [INFO] [stdout] | [INFO] [stdout] 300 | fn write_to<'a>(self, stream: &'a mut TcpStream) -> BoxFuture<'a, Result<()>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 301 | / async move { [INFO] [stdout] 302 | | let encoding_type: i32 = self.data.get_type().into(); [INFO] [stdout] 303 | | [INFO] [stdout] 304 | | stream.write_u16(self.position.x).await?; [INFO] [stdout] ... | [INFO] [stdout] 313 | | Ok(()) [INFO] [stdout] 314 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rfb/mod.rs:321:9 [INFO] [stdout] | [INFO] [stdout] 320 | fn write_to<'a>(self, stream: &'a mut TcpStream) -> BoxFuture<'a, Result<()>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | / async move { [INFO] [stdout] 322 | | // TODO: type function? [INFO] [stdout] 323 | | stream.write_u8(0).await?; [INFO] [stdout] ... | [INFO] [stdout] 337 | | Ok(()) [INFO] [stdout] 338 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:58:21 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn new(server: S, config: VncServerConfig, data: VncServerData) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | config: Arc::new(config), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:59:19 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn new(server: S, config: VncServerConfig, data: VncServerData) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | data: Arc::new(Mutex::new(data)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:60:21 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn new(server: S, config: VncServerConfig, data: VncServerData) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | server: Arc::new(server), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rfb` (lib) due to 6 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a2f5f426c2bd9869c98189f15b3560b3b8c526ea694cf7fc73ff376a5381e929", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2f5f426c2bd9869c98189f15b3560b3b8c526ea694cf7fc73ff376a5381e929", kill_on_drop: false }` [INFO] [stdout] a2f5f426c2bd9869c98189f15b3560b3b8c526ea694cf7fc73ff376a5381e929