[INFO] fetching crate rezip 0.1.3... [INFO] checking rezip-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rezip 0.1.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate rezip 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rezip 0.1.3 [INFO] finished tweaking crates.io crate rezip 0.1.3 [INFO] tweaked toml for crates.io crate rezip 0.1.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate rezip 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cde6dbd8c1959fe6619bbe2c1c2ca1d8ecfec0a5ebdbf031ef378c8465109f7b [INFO] running `Command { std: "docker" "start" "-a" "cde6dbd8c1959fe6619bbe2c1c2ca1d8ecfec0a5ebdbf031ef378c8465109f7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cde6dbd8c1959fe6619bbe2c1c2ca1d8ecfec0a5ebdbf031ef378c8465109f7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cde6dbd8c1959fe6619bbe2c1c2ca1d8ecfec0a5ebdbf031ef378c8465109f7b", kill_on_drop: false }` [INFO] [stdout] cde6dbd8c1959fe6619bbe2c1c2ca1d8ecfec0a5ebdbf031ef378c8465109f7b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 49ee8ecb018b48e67cfbe645eb290e30e6cd8819b358dc1374884bf69626ec87 [INFO] running `Command { std: "docker" "start" "-a" "49ee8ecb018b48e67cfbe645eb290e30e6cd8819b358dc1374884bf69626ec87", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.121 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.89 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling ucd-trie v0.1.3 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Compiling pkg-config v0.3.24 [INFO] [stderr] Checking cpufeatures v0.2.2 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling num-bigint v0.4.3 [INFO] [stderr] Compiling zstd-safe v4.1.4+zstd.1.5.2 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling eyre v0.6.7 [INFO] [stderr] Checking base64ct v1.0.1 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Compiling pest v2.1.3 [INFO] [stderr] Checking gimli v0.26.1 [INFO] [stderr] Checking matrixmultiply v0.3.2 [INFO] [stderr] Checking password-hash v0.3.2 [INFO] [stderr] Compiling quote v1.0.16 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Checking object v0.27.1 [INFO] [stderr] Checking num_threads v0.1.5 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Compiling time-macros v0.2.3 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking rustc-demangle v0.1.21 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking owo-colors v3.3.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking num-complex v0.4.0 [INFO] [stderr] Compiling jobserver v0.1.24 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking flate2 v1.0.22 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking ndarray v0.15.4 [INFO] [stderr] Checking time v0.3.7 [INFO] [stderr] Compiling pest_meta v2.1.3 [INFO] [stderr] Compiling zstd-sys v1.6.3+zstd.1.5.2 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Compiling backtrace v0.3.64 [INFO] [stderr] Checking addr2line v0.17.0 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking crypto-common v0.1.3 [INFO] [stderr] Checking cipher v0.3.0 [INFO] [stderr] Checking bzip2 v0.4.3 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Checking aes v0.7.5 [INFO] [stderr] Checking color-eyre v0.6.1 [INFO] [stderr] Checking sha2 v0.10.2 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha1 v0.10.1 [INFO] [stderr] Checking pbkdf2 v0.10.1 [INFO] [stderr] Compiling pest_generator v2.1.3 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Compiling clap_derive v3.1.4 [INFO] [stderr] Checking py_literal v0.4.0 [INFO] [stderr] Checking ndarray-npy v0.8.1 [INFO] [stderr] Checking clap v3.1.6 [INFO] [stderr] Checking zstd v0.10.0+zstd.1.5.2 [INFO] [stderr] Checking zip v0.6.0 [INFO] [stderr] Checking rezip v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:220:2 [INFO] [stdout] | [INFO] [stdout] 218 | name: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | ) -> Option { [INFO] [stdout] 220 | / values [INFO] [stdout] 221 | | .iter() [INFO] [stdout] 222 | | .rev() [INFO] [stdout] 223 | | .find_map(|(glob, value)| { [INFO] [stdout] ... | [INFO] [stdout] 229 | | }) [INFO] [stdout] 230 | | .cloned() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:272:6 [INFO] [stdout] | [INFO] [stdout] 261 | let reader = if metadata.is_dir() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | Ok(DirFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 273 | | name, [INFO] [stdout] 274 | | metadata, [INFO] [stdout] 275 | | reader, [INFO] [stdout] 276 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:392:7 [INFO] [stdout] | [INFO] [stdout] 391 | .and_then(|zip| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 392 | ZipArchive::new(zip) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:609:36 [INFO] [stdout] | [INFO] [stdout] 609 | .map(|(input, index)| (input, zips[input].by_index(index).unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:623:24 [INFO] [stdout] | [INFO] [stdout] 623 | .and_then(|mut zip| zip.flush().map_err(From::from)) [INFO] [stdout] | ------- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:220:2 [INFO] [stdout] | [INFO] [stdout] 218 | name: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | ) -> Option { [INFO] [stdout] 220 | / values [INFO] [stdout] 221 | | .iter() [INFO] [stdout] 222 | | .rev() [INFO] [stdout] 223 | | .find_map(|(glob, value)| { [INFO] [stdout] ... | [INFO] [stdout] 229 | | }) [INFO] [stdout] 230 | | .cloned() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:272:6 [INFO] [stdout] | [INFO] [stdout] 261 | let reader = if metadata.is_dir() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | Ok(DirFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 273 | | name, [INFO] [stdout] 274 | | metadata, [INFO] [stdout] 275 | | reader, [INFO] [stdout] 276 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:392:7 [INFO] [stdout] | [INFO] [stdout] 391 | .and_then(|zip| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 392 | ZipArchive::new(zip) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:609:36 [INFO] [stdout] | [INFO] [stdout] 609 | .map(|(input, index)| (input, zips[input].by_index(index).unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:623:24 [INFO] [stdout] | [INFO] [stdout] 623 | .and_then(|mut zip| zip.flush().map_err(From::from)) [INFO] [stdout] | ------- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rezip` (bin "rezip" test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rezip` (bin "rezip") due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "49ee8ecb018b48e67cfbe645eb290e30e6cd8819b358dc1374884bf69626ec87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "49ee8ecb018b48e67cfbe645eb290e30e6cd8819b358dc1374884bf69626ec87", kill_on_drop: false }` [INFO] [stdout] 49ee8ecb018b48e67cfbe645eb290e30e6cd8819b358dc1374884bf69626ec87