[INFO] fetching crate rexpect 0.5.0... [INFO] checking rexpect-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rexpect 0.5.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate rexpect 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rexpect 0.5.0 [INFO] finished tweaking crates.io crate rexpect 0.5.0 [INFO] tweaked toml for crates.io crate rexpect 0.5.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate rexpect 0.5.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2527826986cf6999f1e99fe137edd82083e644b34063ad8f5854614e1d6374b8 [INFO] running `Command { std: "docker" "start" "-a" "2527826986cf6999f1e99fe137edd82083e644b34063ad8f5854614e1d6374b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2527826986cf6999f1e99fe137edd82083e644b34063ad8f5854614e1d6374b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2527826986cf6999f1e99fe137edd82083e644b34063ad8f5854614e1d6374b8", kill_on_drop: false }` [INFO] [stdout] 2527826986cf6999f1e99fe137edd82083e644b34063ad8f5854614e1d6374b8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fe87f03d72717bea3b8becbcaf05427054d0f7d1dd977ddaef20c8bb0adef9e8 [INFO] running `Command { std: "docker" "start" "-a" "fe87f03d72717bea3b8becbcaf05427054d0f7d1dd977ddaef20c8bb0adef9e8", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking fastrand v1.8.0 [INFO] [stderr] Checking comma v1.0.0 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking nix v0.25.0 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Compiling thiserror-impl v1.0.34 [INFO] [stderr] Checking thiserror v1.0.34 [INFO] [stderr] Checking rexpect v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:22:21 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(reader: R, writer: W, timeout_ms: Option) -> Self { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Self { [INFO] [stdout] 22 | writer: LineWriter::new(writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:23:21 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(reader: R, writer: W, timeout_ms: Option) -> Self { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | reader: NBReader::new(reader, timeout_ms), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:150:19 [INFO] [stdout] | [INFO] [stdout] 149 | pub fn exp_any(&mut self, needles: Vec) -> Result<(String, String), Error> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | self.exp(&ReadUntil::Any(needles)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:198:12 [INFO] [stdout] | [INFO] [stdout] 194 | fn new(process: PtyProcess, timeout_ms: Option) -> Result { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | let f = process.get_file_handle(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | let reader = f.try_clone()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | let stream = StreamSession::new(reader, f, timeout_ms); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | Ok(Self { process, stream }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:391:5 [INFO] [stdout] | [INFO] [stdout] 376 | let mut rcfile = tempfile::NamedTempFile::new().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 386 | let mut c = Command::new("bash"); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 391 | spawn_command(c, timeout).and_then(|p| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:391:40 [INFO] [stdout] | [INFO] [stdout] 376 | let mut rcfile = tempfile::NamedTempFile::new().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 386 | let mut c = Command::new("bash"); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 391 | spawn_command(c, timeout).and_then(|p| { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 392 | | let new_prompt = "[REXPECT_PROMPT>"; [INFO] [stdout] 393 | | let mut pb = PtyReplSession { [INFO] [stdout] 394 | | prompt: new_prompt.to_string(), [INFO] [stdout] ... | [INFO] [stdout] 404 | | Ok(pb) [INFO] [stdout] 405 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rexpect` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:297:15 [INFO] [stdout] | [INFO] [stdout] 290 | let mut r = NBReader::new(f, None); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 297 | match r.read_until(&ReadUntil::NBytes(10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:22:21 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(reader: R, writer: W, timeout_ms: Option) -> Self { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Self { [INFO] [stdout] 22 | writer: LineWriter::new(writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:23:21 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(reader: R, writer: W, timeout_ms: Option) -> Self { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | reader: NBReader::new(reader, timeout_ms), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:150:19 [INFO] [stdout] | [INFO] [stdout] 149 | pub fn exp_any(&mut self, needles: Vec) -> Result<(String, String), Error> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | self.exp(&ReadUntil::Any(needles)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:198:12 [INFO] [stdout] | [INFO] [stdout] 194 | fn new(process: PtyProcess, timeout_ms: Option) -> Result { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | let f = process.get_file_handle(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | let reader = f.try_clone()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | let stream = StreamSession::new(reader, f, timeout_ms); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | Ok(Self { process, stream }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:391:5 [INFO] [stdout] | [INFO] [stdout] 376 | let mut rcfile = tempfile::NamedTempFile::new().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 386 | let mut c = Command::new("bash"); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 391 | spawn_command(c, timeout).and_then(|p| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:391:40 [INFO] [stdout] | [INFO] [stdout] 376 | let mut rcfile = tempfile::NamedTempFile::new().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 386 | let mut c = Command::new("bash"); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 391 | spawn_command(c, timeout).and_then(|p| { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 392 | | let new_prompt = "[REXPECT_PROMPT>"; [INFO] [stdout] 393 | | let mut pb = PtyReplSession { [INFO] [stdout] 394 | | prompt: new_prompt.to_string(), [INFO] [stdout] ... | [INFO] [stdout] 404 | | Ok(pb) [INFO] [stdout] 405 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rexpect` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "fe87f03d72717bea3b8becbcaf05427054d0f7d1dd977ddaef20c8bb0adef9e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe87f03d72717bea3b8becbcaf05427054d0f7d1dd977ddaef20c8bb0adef9e8", kill_on_drop: false }` [INFO] [stdout] fe87f03d72717bea3b8becbcaf05427054d0f7d1dd977ddaef20c8bb0adef9e8