[INFO] fetching crate rewrk 0.3.2... [INFO] checking rewrk-0.3.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rewrk 0.3.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate rewrk 0.3.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rewrk 0.3.2 [INFO] finished tweaking crates.io crate rewrk 0.3.2 [INFO] tweaked toml for crates.io crate rewrk 0.3.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate rewrk 0.3.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a017a22a352256e5512ae6a049a97c574ec81c7f25b1e8575ad4b15d328fe8af [INFO] running `Command { std: "docker" "start" "-a" "a017a22a352256e5512ae6a049a97c574ec81c7f25b1e8575ad4b15d328fe8af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a017a22a352256e5512ae6a049a97c574ec81c7f25b1e8575ad4b15d328fe8af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a017a22a352256e5512ae6a049a97c574ec81c7f25b1e8575ad4b15d328fe8af", kill_on_drop: false }` [INFO] [stdout] a017a22a352256e5512ae6a049a97c574ec81c7f25b1e8575ad4b15d328fe8af [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 587cb2a3ad8e77e914edbf18a97bdde6da7ec2dc1ecbb13a15b714a4ebf79c6e [INFO] running `Command { std: "docker" "start" "-a" "587cb2a3ad8e77e914edbf18a97bdde6da7ec2dc1ecbb13a15b714a4ebf79c6e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling proc-macro2 v1.0.63 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling tokio v1.29.0 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking itoa v1.0.6 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling openssl v0.10.55 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Compiling serde v1.0.164 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling openssl-sys v0.9.90 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling anyhow v1.0.71 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Compiling serde_json v1.0.99 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking aho-corasick v1.0.2 [INFO] [stderr] Compiling syn v2.0.22 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking ryu v1.0.13 [INFO] [stderr] Checking regex-syntax v0.7.2 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking num_cpus v1.15.0 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex v1.8.4 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling pin-project-internal v1.1.0 [INFO] [stderr] Checking pin-project v1.1.0 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-util v0.7.8 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.3.20 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking rewrk v0.3.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:181:8 [INFO] [stdout] | [INFO] [stdout] 179 | let key = HeaderName::from_str(key).context("Invalid header name")?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | let value = HeaderValue::from_str(value).context("Invalid header value")?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | Ok((key, value)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http/mod.rs:123:56 [INFO] [stdout] | [INFO] [stdout] 123 | .and_then(|response| hyper::body::to_bytes(response.into_body())); [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http/usage.rs:21:35 [INFO] [stdout] | [INFO] [stdout] 20 | pub(crate) fn wrap_stream(&self, stream: I) -> RecordStream { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | RecordStream::new(stream, self.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http/user_input.rs:107:12 [INFO] [stdout] | [INFO] [stdout] 59 | method: Method, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | headers: HeaderMap, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | body: Bytes, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | ) -> Result { [INFO] [stdout] 63 | let uri = Uri::try_from(string)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let scheme = match scheme { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | let mut builder = native_tls::TlsConnector::builder(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let connector = TlsConnector::from(builder.build()?); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let host_header = HeaderValue::from_str(&host)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 108 | | addr, [INFO] [stdout] 109 | | scheme, [INFO] [stdout] 110 | | host, [INFO] [stdout] ... | [INFO] [stdout] 115 | | body, [INFO] [stdout] 116 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rewrk` (bin "rewrk") due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:181:8 [INFO] [stdout] | [INFO] [stdout] 179 | let key = HeaderName::from_str(key).context("Invalid header name")?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | let value = HeaderValue::from_str(value).context("Invalid header value")?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | Ok((key, value)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http/mod.rs:123:56 [INFO] [stdout] | [INFO] [stdout] 123 | .and_then(|response| hyper::body::to_bytes(response.into_body())); [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http/usage.rs:21:35 [INFO] [stdout] | [INFO] [stdout] 20 | pub(crate) fn wrap_stream(&self, stream: I) -> RecordStream { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | RecordStream::new(stream, self.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http/user_input.rs:107:12 [INFO] [stdout] | [INFO] [stdout] 59 | method: Method, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | headers: HeaderMap, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | body: Bytes, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | ) -> Result { [INFO] [stdout] 63 | let uri = Uri::try_from(string)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let scheme = match scheme { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | let mut builder = native_tls::TlsConnector::builder(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let connector = TlsConnector::from(builder.build()?); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let host_header = HeaderValue::from_str(&host)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 108 | | addr, [INFO] [stdout] 109 | | scheme, [INFO] [stdout] 110 | | host, [INFO] [stdout] ... | [INFO] [stdout] 115 | | body, [INFO] [stdout] 116 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rewrk` (bin "rewrk" test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "587cb2a3ad8e77e914edbf18a97bdde6da7ec2dc1ecbb13a15b714a4ebf79c6e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "587cb2a3ad8e77e914edbf18a97bdde6da7ec2dc1ecbb13a15b714a4ebf79c6e", kill_on_drop: false }` [INFO] [stdout] 587cb2a3ad8e77e914edbf18a97bdde6da7ec2dc1ecbb13a15b714a4ebf79c6e