[INFO] fetching crate rework 0.1.0... [INFO] checking rework-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rework 0.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate rework 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rework 0.1.0 [INFO] finished tweaking crates.io crate rework 0.1.0 [INFO] tweaked toml for crates.io crate rework 0.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate rework 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5e7b91987461c6c33be9b96ac368881aef81038895c2ce7d2152ab38f0036c1b [INFO] running `Command { std: "docker" "start" "-a" "5e7b91987461c6c33be9b96ac368881aef81038895c2ce7d2152ab38f0036c1b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5e7b91987461c6c33be9b96ac368881aef81038895c2ce7d2152ab38f0036c1b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e7b91987461c6c33be9b96ac368881aef81038895c2ce7d2152ab38f0036c1b", kill_on_drop: false }` [INFO] [stdout] 5e7b91987461c6c33be9b96ac368881aef81038895c2ce7d2152ab38f0036c1b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d2ca9ff1db4bfcb4bdd1b0f484e344bb08baa5a5b8d4408d2d3f881fe00cb956 [INFO] running `Command { std: "docker" "start" "-a" "d2ca9ff1db4bfcb4bdd1b0f484e344bb08baa5a5b8d4408d2d3f881fe00cb956", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling futures-core v0.3.23 [INFO] [stderr] Compiling futures-task v0.3.23 [INFO] [stderr] Compiling futures-channel v0.3.23 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking futures-sink v0.3.23 [INFO] [stderr] Compiling slab v0.4.7 [INFO] [stderr] Compiling futures-util v0.3.23 [INFO] [stderr] Checking futures-io v0.3.23 [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Checking once_cell v1.13.1 [INFO] [stderr] Compiling tokio v1.20.1 [INFO] [stderr] Checking tracing-core v0.1.29 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Compiling futures-macro v0.3.23 [INFO] [stderr] Compiling tracing-attributes v0.1.22 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Checking tracing v0.1.36 [INFO] [stderr] Checking futures-executor v0.3.23 [INFO] [stderr] Checking futures v0.3.23 [INFO] [stderr] Checking pandet v0.3.0 [INFO] [stderr] Checking rework v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:190:27 [INFO] [stdout] | [INFO] [stdout] 181 | make_work_fn: impl Fn() -> WFn + Send + Sync + 'static, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | make_work_fn: Box::new(make_work_fn), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:191:27 [INFO] [stdout] | [INFO] [stdout] 181 | make_work_fn: impl Fn() -> WFn + Send + Sync + 'static, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | make_init_fn: Box::new(|| NoopInitFn), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:242:27 [INFO] [stdout] | [INFO] [stdout] 230 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | raw_fn: IFn, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 237 | let raw_fn = Arc::new(raw_fn); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | let raw_fn_cp = Arc::clone(&raw_fn); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | make_init_fn: Box::new(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 243 | | let raw_fn = raw_fn_cp.clone(); [INFO] [stdout] 244 | | InitFn { [INFO] [stdout] 245 | | inner: Box::new(move || raw_fn()), [INFO] [stdout] 246 | | } [INFO] [stdout] 247 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:245:28 [INFO] [stdout] | [INFO] [stdout] 238 | let raw_fn_cp = Arc::clone(&raw_fn); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | let raw_fn = raw_fn_cp.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | InitFn { [INFO] [stdout] 245 | inner: Box::new(move || raw_fn()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:325:13 [INFO] [stdout] | [INFO] [stdout] 318 | pub fn build(self) -> Handle { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 325 | Box::new(self.sched), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker.rs:125:20 [INFO] [stdout] | [INFO] [stdout] 116 | resp_tx: UnboundedSender<(Workload, Resp)>, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | panic_tx: UnboundedSender<(Workload, PanicInfo)>, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let (req_tx, req_rx) = unbounded(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | let (cmd_tx, cmd_rx) = channel(0); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | agent: WorkerAgent { id, req_tx, cmd_tx }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker.rs:242:9 [INFO] [stdout] | [INFO] [stdout] 140 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | make_work_fn: impl Fn() -> WFn + Clone + Send + 'static, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | make_init_fn: impl Fn() -> IFn + Clone + Send + 'static, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | let work = move || { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | / thread::Builder::new() [INFO] [stdout] 243 | | .name(format!("worker-thread-{}", self.id)) [INFO] [stdout] 244 | | .spawn(work) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rework` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:190:27 [INFO] [stdout] | [INFO] [stdout] 181 | make_work_fn: impl Fn() -> WFn + Send + Sync + 'static, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | make_work_fn: Box::new(make_work_fn), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:191:27 [INFO] [stdout] | [INFO] [stdout] 181 | make_work_fn: impl Fn() -> WFn + Send + Sync + 'static, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | make_init_fn: Box::new(|| NoopInitFn), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:242:27 [INFO] [stdout] | [INFO] [stdout] 230 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | raw_fn: IFn, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 237 | let raw_fn = Arc::new(raw_fn); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | let raw_fn_cp = Arc::clone(&raw_fn); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | make_init_fn: Box::new(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 243 | | let raw_fn = raw_fn_cp.clone(); [INFO] [stdout] 244 | | InitFn { [INFO] [stdout] 245 | | inner: Box::new(move || raw_fn()), [INFO] [stdout] 246 | | } [INFO] [stdout] 247 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:245:28 [INFO] [stdout] | [INFO] [stdout] 238 | let raw_fn_cp = Arc::clone(&raw_fn); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | let raw_fn = raw_fn_cp.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | InitFn { [INFO] [stdout] 245 | inner: Box::new(move || raw_fn()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:325:13 [INFO] [stdout] | [INFO] [stdout] 318 | pub fn build(self) -> Handle { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 325 | Box::new(self.sched), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker.rs:125:20 [INFO] [stdout] | [INFO] [stdout] 116 | resp_tx: UnboundedSender<(Workload, Resp)>, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | panic_tx: UnboundedSender<(Workload, PanicInfo)>, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let (req_tx, req_rx) = unbounded(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | let (cmd_tx, cmd_rx) = channel(0); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | agent: WorkerAgent { id, req_tx, cmd_tx }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker.rs:242:9 [INFO] [stdout] | [INFO] [stdout] 140 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | make_work_fn: impl Fn() -> WFn + Clone + Send + 'static, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | make_init_fn: impl Fn() -> IFn + Clone + Send + 'static, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | let work = move || { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | / thread::Builder::new() [INFO] [stdout] 243 | | .name(format!("worker-thread-{}", self.id)) [INFO] [stdout] 244 | | .spawn(work) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rework` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "d2ca9ff1db4bfcb4bdd1b0f484e344bb08baa5a5b8d4408d2d3f881fe00cb956", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d2ca9ff1db4bfcb4bdd1b0f484e344bb08baa5a5b8d4408d2d3f881fe00cb956", kill_on_drop: false }` [INFO] [stdout] d2ca9ff1db4bfcb4bdd1b0f484e344bb08baa5a5b8d4408d2d3f881fe00cb956