[INFO] fetching crate revi-core 0.0.0-beta-2... [INFO] checking revi-core-0.0.0-beta-2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate revi-core 0.0.0-beta-2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate revi-core 0.0.0-beta-2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate revi-core 0.0.0-beta-2 [INFO] finished tweaking crates.io crate revi-core 0.0.0-beta-2 [INFO] tweaked toml for crates.io crate revi-core 0.0.0-beta-2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 65 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bstr v0.2.17 (latest: v1.10.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding crossterm v0.20.0 (latest: v0.28.1) [INFO] [stderr] Adding crossterm_winapi v0.8.0 (latest: v0.9.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding mio v0.7.14 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.3.7 (latest: v0.6.0) [INFO] [stderr] Adding mlua v0.6.6 (latest: v0.9.9) [INFO] [stderr] Adding ntapi v0.3.7 (latest: v0.4.1) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding winsafe v0.0.19 (latest: v0.0.22) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f2a2df633b28265d6fcf155bcdb438d56b5e4b85420deb375514b988c481337d [INFO] running `Command { std: "docker" "start" "-a" "f2a2df633b28265d6fcf155bcdb438d56b5e4b85420deb375514b988c481337d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f2a2df633b28265d6fcf155bcdb438d56b5e4b85420deb375514b988c481337d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f2a2df633b28265d6fcf155bcdb438d56b5e4b85420deb375514b988c481337d", kill_on_drop: false }` [INFO] [stdout] f2a2df633b28265d6fcf155bcdb438d56b5e4b85420deb375514b988c481337d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b7a235896754a56b1f4faa4d077a3b17a4d134d1ecbaddaf349e6386b6a152ee [INFO] running `Command { std: "docker" "start" "-a" "b7a235896754a56b1f4faa4d077a3b17a4d134d1ecbaddaf349e6386b6a152ee", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking str_indices v0.4.3 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Compiling lua-src v547.0.0 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking ropey v1.6.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking parking_lot_core v0.8.6 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking crossterm v0.20.0 [INFO] [stderr] Checking revi-ui v0.0.0-beta-2 [INFO] [stderr] Compiling which v6.0.3 [INFO] [stderr] Compiling luajit-src v210.5.10+f725e44 [INFO] [stderr] Compiling mlua v0.6.6 [INFO] [stderr] Checking revi-core v0.0.0-beta-2 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `size` and `clipboard` are never read [INFO] [stdout] --> src/revi.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct ReVi { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 17 | pub is_running: bool, [INFO] [stdout] 18 | size: Position, [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 24 | clipboard: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ReVi` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer.rs:212:5 [INFO] [stdout] | [INFO] [stdout] 205 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | Rope::from_reader(BufReader::new(file)).expect("Failed to open file.") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/revi.rs:69:17 [INFO] [stdout] | [INFO] [stdout] 30 | let mut buffers: Vec>> = files [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let cbuffer = Rc::new(RefCell::new(Buffer::new())); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let main_window = Window::new(w, h, Clone::clone(&buffers[1])) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let command_bar = Window::new(w, 1, cbuffer).with_position((0, h + 2).into()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | [INFO] [stdout] 52 | let windows = vec![command_bar, main_window]; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let revi = Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Rc::new(RefCell::new(revi)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/revi.rs:32:30 [INFO] [stdout] | [INFO] [stdout] 32 | .map(|f| Rc::new(RefCell::new(Buffer::from_path(f.as_str())))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `size` and `clipboard` are never read [INFO] [stdout] --> src/revi.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct ReVi { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 17 | pub is_running: bool, [INFO] [stdout] 18 | size: Position, [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 24 | clipboard: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ReVi` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer.rs:212:5 [INFO] [stdout] | [INFO] [stdout] 205 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | Rope::from_reader(BufReader::new(file)).expect("Failed to open file.") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/revi.rs:69:17 [INFO] [stdout] | [INFO] [stdout] 30 | let mut buffers: Vec>> = files [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let cbuffer = Rc::new(RefCell::new(Buffer::new())); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let main_window = Window::new(w, h, Clone::clone(&buffers[1])) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let command_bar = Window::new(w, 1, cbuffer).with_position((0, h + 2).into()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | [INFO] [stdout] 52 | let windows = vec![command_bar, main_window]; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let revi = Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Rc::new(RefCell::new(revi)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/revi.rs:32:30 [INFO] [stdout] | [INFO] [stdout] 32 | .map(|f| Rc::new(RefCell::new(Buffer::from_path(f.as_str())))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `revi-core` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `revi-core` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "b7a235896754a56b1f4faa4d077a3b17a4d134d1ecbaddaf349e6386b6a152ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b7a235896754a56b1f4faa4d077a3b17a4d134d1ecbaddaf349e6386b6a152ee", kill_on_drop: false }` [INFO] [stdout] b7a235896754a56b1f4faa4d077a3b17a4d134d1ecbaddaf349e6386b6a152ee