[INFO] fetching crate reve 0.0.0... [INFO] checking reve-0.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate reve 0.0.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate reve 0.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate reve 0.0.0 [INFO] finished tweaking crates.io crate reve 0.0.0 [INFO] tweaked toml for crates.io crate reve 0.0.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate reve 0.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8df9a2d5f75f16a3f74cd04bac9dc57175d2774f9192f750f370a7a1a2c96751 [INFO] running `Command { std: "docker" "start" "-a" "8df9a2d5f75f16a3f74cd04bac9dc57175d2774f9192f750f370a7a1a2c96751", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8df9a2d5f75f16a3f74cd04bac9dc57175d2774f9192f750f370a7a1a2c96751", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8df9a2d5f75f16a3f74cd04bac9dc57175d2774f9192f750f370a7a1a2c96751", kill_on_drop: false }` [INFO] [stdout] 8df9a2d5f75f16a3f74cd04bac9dc57175d2774f9192f750f370a7a1a2c96751 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 00016d084797e4b2ee52774dd15ef9325cf6715cabf5a60876d8994d67c530d9 [INFO] running `Command { std: "docker" "start" "-a" "00016d084797e4b2ee52774dd15ef9325cf6715cabf5a60876d8994d67c530d9", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Checking glow v0.13.1 [INFO] [stderr] Checking termcolor v1.4.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Compiling glfw-sys v4.0.0+3.3.5 [INFO] [stderr] Checking glfw v0.54.0 [INFO] [stderr] Checking lueur v0.6.6 [INFO] [stderr] Checking reve v0.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:286:12 [INFO] [stdout] | [INFO] [stdout] 283 | pub fn init(viewport: platform::LogicalSize, backend: T) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 284 | let renderer = Renderer::init(viewport, backend)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 285 | [INFO] [stdout] 286 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 287 | | renderer, [INFO] [stdout] 288 | | drag: None, [INFO] [stdout] 289 | | mode: InteractionMode::default(), [INFO] [stdout] ... | [INFO] [stdout] 305 | | height: 1., [INFO] [stdout] 306 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/renderer.rs:209:12 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn init(viewport: platform::LogicalSize, mut backend: T) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 210 | | pipelines: Pipelines { [INFO] [stdout] 211 | | offscreen: Pipeline::new( [INFO] [stdout] 212 | | default_pipeline, [INFO] [stdout] ... | [INFO] [stdout] 240 | | backend, [INFO] [stdout] 241 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/renderer/mesh.rs:265:12 [INFO] [stdout] | [INFO] [stdout] 259 | let mut indices = Vec::::with_capacity(nindices); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 265 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 266 | | vertices, [INFO] [stdout] 267 | | indices: (!indices.is_empty()).then_some(indices), [INFO] [stdout] 268 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/renderer/scene.rs:86:20 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn new(root: Node) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | nodes: IntMap::from_iter([(root.id, root)]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `reve` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:286:12 [INFO] [stdout] | [INFO] [stdout] 283 | pub fn init(viewport: platform::LogicalSize, backend: T) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 284 | let renderer = Renderer::init(viewport, backend)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 285 | [INFO] [stdout] 286 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 287 | | renderer, [INFO] [stdout] 288 | | drag: None, [INFO] [stdout] 289 | | mode: InteractionMode::default(), [INFO] [stdout] ... | [INFO] [stdout] 305 | | height: 1., [INFO] [stdout] 306 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/renderer.rs:209:12 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn init(viewport: platform::LogicalSize, mut backend: T) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 210 | | pipelines: Pipelines { [INFO] [stdout] 211 | | offscreen: Pipeline::new( [INFO] [stdout] 212 | | default_pipeline, [INFO] [stdout] ... | [INFO] [stdout] 240 | | backend, [INFO] [stdout] 241 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/renderer/mesh.rs:265:12 [INFO] [stdout] | [INFO] [stdout] 259 | let mut indices = Vec::::with_capacity(nindices); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 265 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 266 | | vertices, [INFO] [stdout] 267 | | indices: (!indices.is_empty()).then_some(indices), [INFO] [stdout] 268 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/renderer/scene.rs:86:20 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn new(root: Node) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | nodes: IntMap::from_iter([(root.id, root)]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `reve` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "00016d084797e4b2ee52774dd15ef9325cf6715cabf5a60876d8994d67c530d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "00016d084797e4b2ee52774dd15ef9325cf6715cabf5a60876d8994d67c530d9", kill_on_drop: false }` [INFO] [stdout] 00016d084797e4b2ee52774dd15ef9325cf6715cabf5a60876d8994d67c530d9