[INFO] fetching crate retty 0.29.0... [INFO] checking retty-0.29.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate retty 0.29.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate retty 0.29.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate retty 0.29.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate retty 0.29.0 [INFO] tweaked toml for crates.io crate retty 0.29.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate retty 0.29.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 050ca289ec09d8d53e6a1281c36b1236b44c0e3fd33d8ee066ef1f3b11576ba4 [INFO] running `Command { std: "docker" "start" "-a" "050ca289ec09d8d53e6a1281c36b1236b44c0e3fd33d8ee066ef1f3b11576ba4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "050ca289ec09d8d53e6a1281c36b1236b44c0e3fd33d8ee066ef1f3b11576ba4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "050ca289ec09d8d53e6a1281c36b1236b44c0e3fd33d8ee066ef1f3b11576ba4", kill_on_drop: false }` [INFO] [stdout] 050ca289ec09d8d53e6a1281c36b1236b44c0e3fd33d8ee066ef1f3b11576ba4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6beb0cec5fd1f75d5933898dc6ce6d3d1a2a4d3b66738791c60ce1ca96ab2fae [INFO] running `Command { std: "docker" "start" "-a" "6beb0cec5fd1f75d5933898dc6ce6d3d1a2a4d3b66738791c60ce1ca96ab2fae", kill_on_drop: false }` [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking futures-lite v2.2.0 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking async-task v4.7.0 [INFO] [stderr] Checking concurrent-queue v2.4.0 [INFO] [stderr] Checking piper v0.2.1 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking event-listener v4.0.3 [INFO] [stderr] Checking event-listener v5.2.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking event-listener-strategy v0.4.0 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking event-listener-strategy v0.5.0 [INFO] [stderr] Checking async-lock v3.3.0 [INFO] [stderr] Checking async-channel v2.2.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling anyhow v1.0.80 [INFO] [stderr] Checking async-executor v1.8.0 [INFO] [stderr] Checking async-broadcast v0.7.0 [INFO] [stderr] Checking waitgroup v0.1.2 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking core_affinity v0.8.1 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking chrono v0.4.35 [INFO] [stderr] Checking ctrlc v3.4.2 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking blocking v1.5.1 [INFO] [stderr] Checking clap v4.5.2 [INFO] [stderr] Checking polling v3.5.0 [INFO] [stderr] Checking async-fs v2.1.1 [INFO] [stderr] Checking async-io v2.3.1 [INFO] [stderr] Checking async-signal v0.2.5 [INFO] [stderr] Checking async-net v2.0.0 [INFO] [stderr] Checking async-process v2.1.0 [INFO] [stderr] Checking smol v2.0.0 [INFO] [stderr] Checking async-transport v0.5.0 [INFO] [stderr] Checking retty v0.29.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/handler.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 26 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let context: Context = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let handler: Box< [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | Rc::new(RefCell::new(handler)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/handler.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 26 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let context: Context = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let handler: Box< [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | Rc::new(RefCell::new(context)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor/mod.rs:46:33 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn run(mut self, f: impl Future) -> T { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let local_ex = LocalExecutor::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | LOCAL_EX.set(&local_ex, || { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 47 | | futures_lite::future::block_on(local_ex.run(f)) [INFO] [stdout] 48 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor/mod.rs:47:44 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn run(mut self, f: impl Future) -> T { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | futures_lite::future::block_on(local_ex.run(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor/mod.rs:60:54 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn spawn(mut self, fut_gen: G) -> Result> [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | thread::Builder::new().name(self.name).spawn(move || { [INFO] [stdout] | ______________________________________________________^ [INFO] [stdout] 61 | | if let Some(core_id) = core_id.take() { [INFO] [stdout] 62 | | set_for_current(core_id); [INFO] [stdout] 63 | | } [INFO] [stdout] ... | [INFO] [stdout] 68 | | }) [INFO] [stdout] 69 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor/mod.rs:66:37 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn spawn(mut self, fut_gen: G) -> Result> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let local_ex = LocalExecutor::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | LOCAL_EX.set(&local_ex, || { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 67 | | futures_lite::future::block_on(local_ex.run(fut_gen())) [INFO] [stdout] 68 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor/mod.rs:67:48 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn spawn(mut self, fut_gen: G) -> Result> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | futures_lite::future::block_on(local_ex.run(fut_gen())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `retty` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "6beb0cec5fd1f75d5933898dc6ce6d3d1a2a4d3b66738791c60ce1ca96ab2fae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6beb0cec5fd1f75d5933898dc6ce6d3d1a2a4d3b66738791c60ce1ca96ab2fae", kill_on_drop: false }` [INFO] [stdout] 6beb0cec5fd1f75d5933898dc6ce6d3d1a2a4d3b66738791c60ce1ca96ab2fae