[INFO] fetching crate retrosheet 0.2.4... [INFO] checking retrosheet-0.2.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate retrosheet 0.2.4 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate retrosheet 0.2.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate retrosheet 0.2.4 [INFO] finished tweaking crates.io crate retrosheet 0.2.4 [INFO] tweaked toml for crates.io crate retrosheet 0.2.4 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding lexical-core v0.7.6 (latest: v0.8.5) [INFO] [stderr] Adding nom v5.1.3 (latest: v7.1.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cbf6b7d7f8234c90991a5830170aad9397ed579b014675668a5c55542fd0949c [INFO] running `Command { std: "docker" "start" "-a" "cbf6b7d7f8234c90991a5830170aad9397ed579b014675668a5c55542fd0949c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cbf6b7d7f8234c90991a5830170aad9397ed579b014675668a5c55542fd0949c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cbf6b7d7f8234c90991a5830170aad9397ed579b014675668a5c55542fd0949c", kill_on_drop: false }` [INFO] [stdout] cbf6b7d7f8234c90991a5830170aad9397ed579b014675668a5c55542fd0949c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 87aa535c3dd6e92fe135739d9fa923968a11a151163d434289a7b31aaceaef09 [INFO] running `Command { std: "docker" "start" "-a" "87aa535c3dd6e92fe135739d9fa923968a11a151163d434289a7b31aaceaef09", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling nom v5.1.3 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking retrosheet v0.2.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/event.rs:611:31 [INFO] [stdout] | [INFO] [stdout] 611 | _ => unreachable!(bytes), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `unreachable!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 611 | _ => unreachable!("{}", bytes), [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:128:23 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn new>(id: S) -> Game { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | starters: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers.rs:337:8 [INFO] [stdout] | [INFO] [stdout] 332 | let (input, additional) = opt(complete(preceded( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 337 | Ok((input, PlayDescription::Strikeout(additional, fielders))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers.rs:347:8 [INFO] [stdout] | [INFO] [stdout] 342 | let (input, additional) = opt(complete(preceded( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 347 | Ok((input, PlayDescription::Walk(additional))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers.rs:504:8 [INFO] [stdout] | [INFO] [stdout] 495 | let (input, play_desc) = complete(play_description)(input)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 504 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 505 | | input, [INFO] [stdout] 506 | | PlayEvent { [INFO] [stdout] 507 | | description: play_desc, [INFO] [stdout] ... | [INFO] [stdout] 510 | | }, [INFO] [stdout] 511 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers.rs:546:8 [INFO] [stdout] | [INFO] [stdout] 544 | let (input, event) = play_event(input)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 545 | [INFO] [stdout] 546 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 547 | | input, [INFO] [stdout] 548 | | Event::Play { [INFO] [stdout] 549 | | inning, [INFO] [stdout] ... | [INFO] [stdout] 555 | | }, [INFO] [stdout] 556 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers.rs:614:8 [INFO] [stdout] | [INFO] [stdout] 605 | let (input, event) = alt(( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 614 | Ok((input, event)) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `retrosheet` (lib) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/event.rs:611:31 [INFO] [stdout] | [INFO] [stdout] 611 | _ => unreachable!(bytes), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `unreachable!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 611 | _ => unreachable!("{}", bytes), [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:128:23 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn new>(id: S) -> Game { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | starters: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers.rs:337:8 [INFO] [stdout] | [INFO] [stdout] 332 | let (input, additional) = opt(complete(preceded( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 337 | Ok((input, PlayDescription::Strikeout(additional, fielders))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers.rs:347:8 [INFO] [stdout] | [INFO] [stdout] 342 | let (input, additional) = opt(complete(preceded( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 347 | Ok((input, PlayDescription::Walk(additional))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers.rs:504:8 [INFO] [stdout] | [INFO] [stdout] 495 | let (input, play_desc) = complete(play_description)(input)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 504 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 505 | | input, [INFO] [stdout] 506 | | PlayEvent { [INFO] [stdout] 507 | | description: play_desc, [INFO] [stdout] ... | [INFO] [stdout] 510 | | }, [INFO] [stdout] 511 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers.rs:546:8 [INFO] [stdout] | [INFO] [stdout] 544 | let (input, event) = play_event(input)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 545 | [INFO] [stdout] 546 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 547 | | input, [INFO] [stdout] 548 | | Event::Play { [INFO] [stdout] 549 | | inning, [INFO] [stdout] ... | [INFO] [stdout] 555 | | }, [INFO] [stdout] 556 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers.rs:614:8 [INFO] [stdout] | [INFO] [stdout] 605 | let (input, event) = alt(( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 614 | Ok((input, event)) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `retrosheet` (lib test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "87aa535c3dd6e92fe135739d9fa923968a11a151163d434289a7b31aaceaef09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87aa535c3dd6e92fe135739d9fa923968a11a151163d434289a7b31aaceaef09", kill_on_drop: false }` [INFO] [stdout] 87aa535c3dd6e92fe135739d9fa923968a11a151163d434289a7b31aaceaef09