[INFO] fetching crate retriever 0.0.3... [INFO] checking retriever-0.0.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate retriever 0.0.3 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate retriever 0.0.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate retriever 0.0.3 [INFO] finished tweaking crates.io crate retriever 0.0.3 [INFO] tweaked toml for crates.io crate retriever 0.0.3 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 109 packages to latest compatible versions [INFO] [stderr] Adding autocfg v0.1.8 (latest: v1.3.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding colored v1.9.4 (latest: v2.1.0) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding rand v0.6.5 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.1.0 (latest: v0.3.2) [INFO] [stderr] Adding rand_isaac v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rand_jitter v0.1.4 (latest: v0.4.0) [INFO] [stderr] Adding rand_os v0.1.3 (latest: v0.2.2) [INFO] [stderr] Adding rand_pcg v0.1.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_xorshift v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding simple_logger v1.16.0 (latest: v5.0.0) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6a06fcbfa988a9eaba4a82c43cd0d9fa79115033e45ef5e9c5b4433bf4dc17ce [INFO] running `Command { std: "docker" "start" "-a" "6a06fcbfa988a9eaba4a82c43cd0d9fa79115033e45ef5e9c5b4433bf4dc17ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6a06fcbfa988a9eaba4a82c43cd0d9fa79115033e45ef5e9c5b4433bf4dc17ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6a06fcbfa988a9eaba4a82c43cd0d9fa79115033e45ef5e9c5b4433bf4dc17ce", kill_on_drop: false }` [INFO] [stdout] 6a06fcbfa988a9eaba4a82c43cd0d9fa79115033e45ef5e9c5b4433bf4dc17ce [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 28d1a0915f535c794fe5deb09ecd24d5425eae4a884bc98614077475382a3cee [INFO] running `Command { std: "docker" "start" "-a" "28d1a0915f535c794fe5deb09ecd24d5425eae4a884bc98614077475382a3cee", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking colored v1.9.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking retriever v0.0.3 (/opt/rustwide/workdir) [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking rand v0.6.5 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/bits/bitfield.rs:5:32 [INFO] [stdout] | [INFO] [stdout] 5 | pub(crate) const BITS: usize = (std::mem::size_of::() * 8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 5 - pub(crate) const BITS: usize = (std::mem::size_of::() * 8); [INFO] [stdout] 5 + pub(crate) const BITS: usize = std::mem::size_of::() * 8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internal/mr/reduce.rs:22:18 [INFO] [stdout] | [INFO] [stdout] 16 | pub(crate) fn new(map: Map, reduce: Reduce) -> ReduceRules [INFO] [stdout] | -------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | map: Arc::new(map), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internal/mr/reduce.rs:23:21 [INFO] [stdout] | [INFO] [stdout] 16 | pub(crate) fn new(map: Map, reduce: Reduce) -> ReduceRules [INFO] [stdout] | -------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | reduce: Arc::new(reduce), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internal/mr/summarize.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 24 | rules: Arc>, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | tokens: RVec::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internal/mr/summarize.rs:32:22 [INFO] [stdout] | [INFO] [stdout] 24 | rules: Arc>, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | summary: Summary::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/queries/secondary_index.rs:164:24 [INFO] [stdout] | [INFO] [stdout] 157 | pub fn new(storage: &Storage, f: F) -> Self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | SecondaryIndex(Arc::new(RwLock::new(SecondaryIndexImpl { [INFO] [stdout] | ________________________^ [INFO] [stdout] 165 | | parent_id: storage.id(), [INFO] [stdout] 166 | | gc_chunk_list: RVec::default(), [INFO] [stdout] 167 | | index: HashMap::with_hasher(crate::internal::hasher::HasherImpl::default()), [INFO] [stdout] ... | [INFO] [stdout] 170 | | ), [INFO] [stdout] 171 | | }))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/queries/secondary_index.rs:200:18 [INFO] [stdout] | [INFO] [stdout] 195 | fn indexing_rules(f: F) -> SummaryRules> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | map: Arc::new(move |element, old_index_keys, _internal_idx| { [INFO] [stdout] | __________________^ [INFO] [stdout] 201 | | let new_index_keys = f(element); [INFO] [stdout] 202 | | [INFO] [stdout] 203 | | if old_index_keys != new_index_keys.borrow() { [INFO] [stdout] ... | [INFO] [stdout] 207 | | } [INFO] [stdout] 208 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/queries/secondary_index.rs:209:25 [INFO] [stdout] | [INFO] [stdout] 195 | fn indexing_rules(f: F) -> SummaryRules> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | contribute: Arc::new(|new_index_keys, internal_idx, summary| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 210 | | for new_index_key in new_index_keys.iter_keys() { [INFO] [stdout] 211 | | let idx_set = summary [INFO] [stdout] 212 | | .reverse_index [INFO] [stdout] ... | [INFO] [stdout] 217 | | } [INFO] [stdout] 218 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/queries/secondary_index.rs:219:27 [INFO] [stdout] | [INFO] [stdout] 195 | fn indexing_rules(f: F) -> SummaryRules> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | uncontribute: Arc::new(|old_index_keys, internal_idx, summary| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 220 | | for old_index_key in old_index_keys.iter_keys() { [INFO] [stdout] 221 | | let mut remove = false; [INFO] [stdout] ... | [INFO] [stdout] 233 | | } [INFO] [stdout] 234 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/queries/secondary_index.rs:253:66 [INFO] [stdout] | [INFO] [stdout] 253 | .or_insert_with(|| Summarize::new(&internal_storage, Arc::clone(rules))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/queries/secondary_index.rs:298:30 [INFO] [stdout] | [INFO] [stdout] 292 | query: Q, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 293 | secondary_index: &SecondaryIndex, [INFO] [stdout] 294 | index_key: Cow<'a, IndexKey>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 298 | secondary_index: secondary_index.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traits/idxset.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 32 | fn into_idx_iter(self) -> Self::IdxIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | self.map(|x| x.into_idx_iter()).into_iter().flatten() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/chunk_storage.rs:40:19 [INFO] [stdout] | [INFO] [stdout] 37 | pub(crate) fn new(chunk_key: ChunkKey::Owned) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | data: RVec::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/chunk_storage.rs:41:20 [INFO] [stdout] | [INFO] [stdout] 37 | pub(crate) fn new(chunk_key: ChunkKey::Owned) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | index: HashMap::with_hasher(crate::internal::hasher::HasherImpl::default()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/chunk_storage.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 119 | pub(crate) fn query<'a, Q>(&'a self, query: Q) -> impl Iterator [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | / query [INFO] [stdout] 124 | | .item_idxs(self.chunk_key.borrow(), &self) [INFO] [stdout] 125 | | .into_idx_iter() [INFO] [stdout] 126 | | .flatten() [INFO] [stdout] 127 | | .map(move |idx| self.get_idx(idx)) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/chunk_storage.rs:128:21 [INFO] [stdout] | [INFO] [stdout] 119 | pub(crate) fn query<'a, Q>(&'a self, query: Q) -> impl Iterator [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | .filter(move |element| query.test(element)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/types/entry.rs:99:20 [INFO] [stdout] | [INFO] [stdout] 99 | panic!(format!( [INFO] [stdout] | ____________________^ [INFO] [stdout] 100 | | "retriever: Entry::or_panic(): {:?} doesn't exist", [INFO] [stdout] 101 | | &self.id [INFO] [stdout] 102 | | )) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 99 ~ panic!( [INFO] [stdout] 100 | "retriever: Entry::or_panic(): {:?} doesn't exist", [INFO] [stdout] 101 | &self.id [INFO] [stdout] 102 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/entry.rs:122:14 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn remove(mut self) -> Option { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | Some(self.storage.remove_idx(idx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/reduction.rs:82:28 [INFO] [stdout] | [INFO] [stdout] 63 | map: Map, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | fold: Fold, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | let chunkwise_summaries = RVec::default(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let reduction = Reduce::new( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | gc_chunk_list: RVec::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/reduction.rs:83:20 [INFO] [stdout] | [INFO] [stdout] 63 | map: Map, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | fold: Fold, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | let chunkwise_summaries = RVec::default(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let reduction = Reduce::new( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | rules: Self::chunkwise_rules(map.clone(), fold.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/reduction.rs:84:35 [INFO] [stdout] | [INFO] [stdout] 63 | map: Map, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | fold: Fold, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | let chunkwise_summaries = RVec::default(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let reduction = Reduce::new( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | chunkwise_reductions: HashMap::with_hasher( [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 85 | | crate::internal::hasher::HasherImpl::default(), [INFO] [stdout] 86 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/reduction.rs:98:26 [INFO] [stdout] | [INFO] [stdout] 92 | fn reduction_rules(_map: Map, reduce: Reduce) -> ReduceRules [INFO] [stdout] | --------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let map = reduce.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | ReduceRules::new(move |ss, s, _| map(std::slice::from_ref(ss), s), reduce) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/reduction.rs:106:26 [INFO] [stdout] | [INFO] [stdout] 101 | fn chunkwise_rules(map: Map, reduce: Reduce) -> ReduceRules [INFO] [stdout] | -------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | ReduceRules::new(move |e, s, _| map(e, s), reduce) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/reduction.rs:274:13 [INFO] [stdout] | [INFO] [stdout] 268 | let chunk_key = chunk_key[0] [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | / chunkwise_reductions [INFO] [stdout] 275 | | .entry(chunk_key) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/reduction.rs:276:78 [INFO] [stdout] | [INFO] [stdout] 276 | .or_insert_with(|| Reduce::new(internal_storage, group_size, rules.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/reduction.rs:312:74 [INFO] [stdout] | [INFO] [stdout] 312 | .or_insert_with(|| Reduce::new(internal_storage, group_size, rules.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/storage.rs:261:9 [INFO] [stdout] | [INFO] [stdout] 259 | pub fn dissolve(self) -> impl IntoIterator> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | let chunks: Vec<_> = self.chunks.into(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 261 | chunks.into_iter().map(|chunk| chunk.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/storage.rs:458:20 [INFO] [stdout] | [INFO] [stdout] 453 | pub fn entry<'a, R>(&'a mut self, unique_id: R) -> Entry<'a, R, ChunkKey, ItemKey, Element> [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 458 | self.chunk(unique_id.borrow().chunk_key().borrow(), true) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/storage.rs:541:9 [INFO] [stdout] | [INFO] [stdout] 535 | pub fn query<'a, Q>(&'a self, query: Q) -> impl Iterator [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 539 | let chunk_idxs = query.chunk_idxs(&self); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 540 | [INFO] [stdout] 541 | / chunk_idxs [INFO] [stdout] 542 | | .into_idx_iter() [INFO] [stdout] 543 | | .flatten() [INFO] [stdout] 544 | | .map(move |idx| &self.chunks[idx]) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/storage.rs:546:17 [INFO] [stdout] | [INFO] [stdout] 535 | pub fn query<'a, Q>(&'a self, query: Q) -> impl Iterator [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 539 | let chunk_idxs = query.chunk_idxs(&self); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 546 | / move |chunk_storage: &ChunkStorage| { [INFO] [stdout] 547 | | chunk_storage.query(query.clone()) [INFO] [stdout] 548 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/storage.rs:547:41 [INFO] [stdout] | [INFO] [stdout] 535 | pub fn query<'a, Q>(&'a self, query: Q) -> impl Iterator [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 547 | chunk_storage.query(query.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/storage.rs:709:14 [INFO] [stdout] | [INFO] [stdout] 708 | let chunk = self.chunks.swap_remove(idx); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 709 | Some(chunk.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 30 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `retriever` (lib) due to 31 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "28d1a0915f535c794fe5deb09ecd24d5425eae4a884bc98614077475382a3cee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28d1a0915f535c794fe5deb09ecd24d5425eae4a884bc98614077475382a3cee", kill_on_drop: false }` [INFO] [stdout] 28d1a0915f535c794fe5deb09ecd24d5425eae4a884bc98614077475382a3cee