[INFO] fetching crate resymgen 0.6.0... [INFO] checking resymgen-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate resymgen 0.6.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate resymgen 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate resymgen 0.6.0 [INFO] finished tweaking crates.io crate resymgen 0.6.0 [INFO] tweaked toml for crates.io crate resymgen 0.6.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate resymgen 0.6.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 131fb8b6efd6da57953e6cffb543681dc2ac6adbdee73d2f3eadaa5e35efb375 [INFO] running `Command { std: "docker" "start" "-a" "131fb8b6efd6da57953e6cffb543681dc2ac6adbdee73d2f3eadaa5e35efb375", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "131fb8b6efd6da57953e6cffb543681dc2ac6adbdee73d2f3eadaa5e35efb375", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "131fb8b6efd6da57953e6cffb543681dc2ac6adbdee73d2f3eadaa5e35efb375", kill_on_drop: false }` [INFO] [stdout] 131fb8b6efd6da57953e6cffb543681dc2ac6adbdee73d2f3eadaa5e35efb375 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 31137a190160aa3983a807bdfd63bc67906abf117ce5e35ba161e71dadc540fc [INFO] running `Command { std: "docker" "start" "-a" "31137a190160aa3983a807bdfd63bc67906abf117ce5e35ba161e71dadc540fc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling libc v0.2.113 [INFO] [stderr] Compiling syn v1.0.82 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking quote v1.0.15 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking getrandom v0.2.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking similar v2.1.0 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking serde_yaml v0.8.21 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking resymgen v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checks.rs:426:9 [INFO] [stdout] | [INFO] [stdout] 406 | let mut duplicate_names: BTreeMap<&OrdString, HashSet<&str>> = BTreeMap::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 407 | let mut duplicate_subregions: BTreeMap<&OrdString, HashSet<&Path>> = BTreeMap::new(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 426 | / || { [INFO] [stdout] 427 | | let mut components = Vec::with_capacity(2); [INFO] [stdout] 428 | | if !duplicate_names.is_empty() { [INFO] [stdout] 429 | | components.push(format!( [INFO] [stdout] ... | [INFO] [stdout] 459 | | components.join("\n") [INFO] [stdout] 460 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checks.rs:882:40 [INFO] [stdout] | [INFO] [stdout] 862 | block_iter: F, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 869 | let mut bad_names: BTreeMap<&OrdString, HashSet<&str>> = BTreeMap::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 882 | assert_check(bad_names.is_empty(), || { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 883 | | format!( [INFO] [stdout] 884 | | "Found invalid {} names:\n{}", [INFO] [stdout] 885 | | symbol_type, [INFO] [stdout] ... | [INFO] [stdout] 895 | | ) [INFO] [stdout] 896 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/merge.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 32 | fn new(parent_desc: S, other_desc: S) -> Self { [INFO] [stdout] | -------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | inner: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/merge.rs:328:32 [INFO] [stdout] | [INFO] [stdout] 328 | .flat_map(|(i, s)| s.iter_names().map(move |n| (n.to_owned(), i))) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/merge.rs:550:36 [INFO] [stdout] | [INFO] [stdout] 550 | .flat_map(|(i, s)| s.iter_aliases().map(move |a| (i, a))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/symgen.rs:77:47 [INFO] [stdout] | [INFO] [stdout] 77 | .map(|(v, a)| (v.clone(), (a.clone(), len.get_native(Some(v)).copied()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/symgen.rs:81:47 [INFO] [stdout] | [INFO] [stdout] 81 | .map(|(v, a)| (v.clone(), (a.clone(), None))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/symgen.rs:93:52 [INFO] [stdout] | [INFO] [stdout] 93 | .map(|(v, &l)| (v.clone(), (addr.clone(), Some(l)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/symgen.rs:896:9 [INFO] [stdout] | [INFO] [stdout] 895 | pub fn read_no_init(rdr: R) -> Result { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 896 | serde_yaml::from_reader(rdr).map_err(Error::Yaml) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/symgen.rs:1097:9 [INFO] [stdout] | [INFO] [stdout] 1070 | pub fn write(&self, mut writer: W, int_format: IntFormat) -> Result<()> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1097 | writer.write_all(yaml_bytes).map_err(Error::Io) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/symgen.rs:1217:16 [INFO] [stdout] | [INFO] [stdout] 1216 | fn from(arr: [(OrdString, Block); N]) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1217 | SymGen(BTreeMap::from(arr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/symgen.rs:1286:30 [INFO] [stdout] | [INFO] [stdout] 1285 | let rdr = file_opener(&filepath).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1286 | Error::Subregion(SubregionError::SymGen(( [INFO] [stdout] | ______________________________^ [INFO] [stdout] 1287 | | filepath.clone(), [INFO] [stdout] 1288 | | Box::new(Error::Io(e)), [INFO] [stdout] 1289 | | ))) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/symgen.rs:1292:30 [INFO] [stdout] | [INFO] [stdout] 1291 | self.contents = Some(Box::new(SymGen::read(rdr).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1292 | Error::Subregion(SubregionError::SymGen((filepath.clone(), Box::new(e)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/symgen.rs:1310:23 [INFO] [stdout] | [INFO] [stdout] 1306 | fn from(val: P) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1310 | contents: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/symgen/cursor.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 67 | let mut paths_seen: HashSet>> = [Rc::clone(&self.path)].into(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | / self.symgen [INFO] [stdout] 69 | | .blocks() [INFO] [stdout] 70 | | .flat_map(|block| block.subregions.as_deref().unwrap_or_default().iter()) [INFO] [stdout] | |_____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/symgen/cursor.rs:71:25 [INFO] [stdout] | [INFO] [stdout] 67 | let mut paths_seen: HashSet>> = [Rc::clone(&self.path)].into(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | .filter_map(move |subregion| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 72 | | if let Some(symgen) = &subregion.contents { [INFO] [stdout] 73 | | let path = Rc::new(Cow::Owned( [INFO] [stdout] 74 | | Subregion::subregion_dir(self.path()).join(&subregion.name), [INFO] [stdout] ... | [INFO] [stdout] 80 | | None [INFO] [stdout] 81 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/types.rs:391:20 [INFO] [stdout] | [INFO] [stdout] 390 | fn from(arr: [(Version, T); N]) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 391 | VersionDep(BTreeMap::from(arr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/types.rs:400:20 [INFO] [stdout] | [INFO] [stdout] 396 | fn from_iter(iter: T) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 400 | VersionDep(BTreeMap::from_iter(iter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/types.rs:561:30 [INFO] [stdout] | [INFO] [stdout] 561 | .map(|v| (v, x.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `resymgen` (lib) due to 20 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checks.rs:426:9 [INFO] [stdout] | [INFO] [stdout] 406 | let mut duplicate_names: BTreeMap<&OrdString, HashSet<&str>> = BTreeMap::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 407 | let mut duplicate_subregions: BTreeMap<&OrdString, HashSet<&Path>> = BTreeMap::new(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 426 | / || { [INFO] [stdout] 427 | | let mut components = Vec::with_capacity(2); [INFO] [stdout] 428 | | if !duplicate_names.is_empty() { [INFO] [stdout] 429 | | components.push(format!( [INFO] [stdout] ... | [INFO] [stdout] 459 | | components.join("\n") [INFO] [stdout] 460 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checks.rs:882:40 [INFO] [stdout] | [INFO] [stdout] 862 | block_iter: F, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 869 | let mut bad_names: BTreeMap<&OrdString, HashSet<&str>> = BTreeMap::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 882 | assert_check(bad_names.is_empty(), || { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 883 | | format!( [INFO] [stdout] 884 | | "Found invalid {} names:\n{}", [INFO] [stdout] 885 | | symbol_type, [INFO] [stdout] ... | [INFO] [stdout] 895 | | ) [INFO] [stdout] 896 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/merge.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 32 | fn new(parent_desc: S, other_desc: S) -> Self { [INFO] [stdout] | -------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | inner: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/merge.rs:328:32 [INFO] [stdout] | [INFO] [stdout] 328 | .flat_map(|(i, s)| s.iter_names().map(move |n| (n.to_owned(), i))) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/merge.rs:550:36 [INFO] [stdout] | [INFO] [stdout] 550 | .flat_map(|(i, s)| s.iter_aliases().map(move |a| (i, a))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/symgen.rs:77:47 [INFO] [stdout] | [INFO] [stdout] 77 | .map(|(v, a)| (v.clone(), (a.clone(), len.get_native(Some(v)).copied()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/symgen.rs:81:47 [INFO] [stdout] | [INFO] [stdout] 81 | .map(|(v, a)| (v.clone(), (a.clone(), None))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/symgen.rs:93:52 [INFO] [stdout] | [INFO] [stdout] 93 | .map(|(v, &l)| (v.clone(), (addr.clone(), Some(l)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/symgen.rs:896:9 [INFO] [stdout] | [INFO] [stdout] 895 | pub fn read_no_init(rdr: R) -> Result { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 896 | serde_yaml::from_reader(rdr).map_err(Error::Yaml) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/symgen.rs:1097:9 [INFO] [stdout] | [INFO] [stdout] 1070 | pub fn write(&self, mut writer: W, int_format: IntFormat) -> Result<()> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1097 | writer.write_all(yaml_bytes).map_err(Error::Io) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/symgen.rs:1217:16 [INFO] [stdout] | [INFO] [stdout] 1216 | fn from(arr: [(OrdString, Block); N]) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1217 | SymGen(BTreeMap::from(arr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/symgen.rs:1286:30 [INFO] [stdout] | [INFO] [stdout] 1285 | let rdr = file_opener(&filepath).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1286 | Error::Subregion(SubregionError::SymGen(( [INFO] [stdout] | ______________________________^ [INFO] [stdout] 1287 | | filepath.clone(), [INFO] [stdout] 1288 | | Box::new(Error::Io(e)), [INFO] [stdout] 1289 | | ))) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/symgen.rs:1292:30 [INFO] [stdout] | [INFO] [stdout] 1291 | self.contents = Some(Box::new(SymGen::read(rdr).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1292 | Error::Subregion(SubregionError::SymGen((filepath.clone(), Box::new(e)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/symgen.rs:1310:23 [INFO] [stdout] | [INFO] [stdout] 1306 | fn from(val: P) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1310 | contents: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/symgen/cursor.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 67 | let mut paths_seen: HashSet>> = [Rc::clone(&self.path)].into(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | / self.symgen [INFO] [stdout] 69 | | .blocks() [INFO] [stdout] 70 | | .flat_map(|block| block.subregions.as_deref().unwrap_or_default().iter()) [INFO] [stdout] | |_____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/symgen/cursor.rs:71:25 [INFO] [stdout] | [INFO] [stdout] 67 | let mut paths_seen: HashSet>> = [Rc::clone(&self.path)].into(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | .filter_map(move |subregion| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 72 | | if let Some(symgen) = &subregion.contents { [INFO] [stdout] 73 | | let path = Rc::new(Cow::Owned( [INFO] [stdout] 74 | | Subregion::subregion_dir(self.path()).join(&subregion.name), [INFO] [stdout] ... | [INFO] [stdout] 80 | | None [INFO] [stdout] 81 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/symgen.rs:2229:18 [INFO] [stdout] | [INFO] [stdout] 2219 | let mut block = get_sorted_block(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2225 | let mut final_subregions = block.subregions.clone().unwrap(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2229 | &Block { [INFO] [stdout] | __________________^ [INFO] [stdout] 2230 | | versions: Some(final_versions), [INFO] [stdout] 2231 | | address: final_addresses.clone(), [INFO] [stdout] 2232 | | length: final_addresses.clone(), [INFO] [stdout] ... | [INFO] [stdout] 2236 | | data: final_symbols.clone(), [INFO] [stdout] 2237 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/symgen.rs:2281:18 [INFO] [stdout] | [INFO] [stdout] 2243 | let mut block = get_sorted_block(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2281 | &Block { [INFO] [stdout] | __________________^ [INFO] [stdout] 2282 | | versions, [INFO] [stdout] 2283 | | address, [INFO] [stdout] 2284 | | length, [INFO] [stdout] ... | [INFO] [stdout] 2288 | | data: expanded_symbols.clone(), [INFO] [stdout] 2289 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/types.rs:391:20 [INFO] [stdout] | [INFO] [stdout] 390 | fn from(arr: [(Version, T); N]) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 391 | VersionDep(BTreeMap::from(arr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/types.rs:400:20 [INFO] [stdout] | [INFO] [stdout] 396 | fn from_iter(iter: T) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 400 | VersionDep(BTreeMap::from_iter(iter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_formats/symgen_yml/types.rs:561:30 [INFO] [stdout] | [INFO] [stdout] 561 | .map(|v| (v, x.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `resymgen` (lib test) due to 22 previous errors [INFO] running `Command { std: "docker" "inspect" "31137a190160aa3983a807bdfd63bc67906abf117ce5e35ba161e71dadc540fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "31137a190160aa3983a807bdfd63bc67906abf117ce5e35ba161e71dadc540fc", kill_on_drop: false }` [INFO] [stdout] 31137a190160aa3983a807bdfd63bc67906abf117ce5e35ba161e71dadc540fc