[INFO] fetching crate restest_macros 0.1.0... [INFO] checking restest_macros-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate restest_macros 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate restest_macros 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate restest_macros 0.1.0 [INFO] finished tweaking crates.io crate restest_macros 0.1.0 [INFO] tweaked toml for crates.io crate restest_macros 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 98344cbd041026788281f8ac2e30f56e6c178a0457b3601484f5a231ad901360 [INFO] running `Command { std: "docker" "start" "-a" "98344cbd041026788281f8ac2e30f56e6c178a0457b3601484f5a231ad901360", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "98344cbd041026788281f8ac2e30f56e6c178a0457b3601484f5a231ad901360", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "98344cbd041026788281f8ac2e30f56e6c178a0457b3601484f5a231ad901360", kill_on_drop: false }` [INFO] [stdout] 98344cbd041026788281f8ac2e30f56e6c178a0457b3601484f5a231ad901360 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 24426e67f2f46682630828fa6953dbc216600d0bdc4bc2dcc16e227c8722dcbc [INFO] running `Command { std: "docker" "start" "-a" "24426e67f2f46682630828fa6953dbc216600d0bdc4bc2dcc16e227c8722dcbc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking restest_macros v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:22:35 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn assert_body_matches(input: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let input = parse_macro_input!(input as BodyMatchCall); [INFO] [stdout] | ----- ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | proc_macro::TokenStream::from(input.expand().to_token_stream()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:51:21 [INFO] [stdout] | [INFO] [stdout] 26 | fn expand(mut self) -> Stmt { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let (bindings, return_expr) = [INFO] [stdout] | -------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | BindingPatternsExtractor::new(&self.pat).expand_bindings_and_return_expr(); [INFO] [stdout] 43 | let guard_condition = StringLiteralPatternModifier::new(&mut self.pat).expand_guard_expr(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let match_expr = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let pat = bindings.into(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let match_expr = Box::new(match_expr.into()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | [INFO] [stdout] 51 | Stmt::Local(Local { [INFO] [stdout] | _____________________^ [INFO] [stdout] 52 | | attrs: Vec::new(), [INFO] [stdout] 53 | | let_token, [INFO] [stdout] 54 | | pat, [INFO] [stdout] 55 | | init: Some((equal, match_expr)), [INFO] [stdout] 56 | | semi_token, [INFO] [stdout] 57 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:144:20 [INFO] [stdout] | [INFO] [stdout] 134 | let elems = self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | attrs: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:160:20 [INFO] [stdout] | [INFO] [stdout] 151 | let elems = self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | attrs: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:171:20 [INFO] [stdout] | [INFO] [stdout] 170 | fn mk_ident_pat(ident: Ident) -> Pat { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | Pat::Ident(PatIdent { [INFO] [stdout] | ____________________^ [INFO] [stdout] 172 | | attrs: Vec::new(), [INFO] [stdout] 173 | | by_ref: None, [INFO] [stdout] 174 | | mutability: None, [INFO] [stdout] 175 | | ident, [INFO] [stdout] 176 | | subpat: None, [INFO] [stdout] 177 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:424:20 [INFO] [stdout] | [INFO] [stdout] 417 | fn nest_match(inner: ExprMatch, (expr, pat): (Expr, Pat)) -> ExprMatch { [INFO] [stdout] | ---------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 418 | let match_token = ::default(); [INFO] [stdout] 419 | let expr = Box::new(expr); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 420 | let brace_token = Brace::default(); [INFO] [stdout] 421 | let arms = vec![Self::mk_arm(pat, None, inner.into()), Self::catchall_arm()]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 424 | attrs: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:435:20 [INFO] [stdout] | [INFO] [stdout] 432 | fn mk_arm(pat: Pat, guard: Option<(Token![if], Box)>, body: Expr) -> Arm { [INFO] [stdout] | -------- -------------------------------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 433 | let body = Box::new(body); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 434 | Arm { [INFO] [stdout] 435 | attrs: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `restest_macros` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:22:35 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn assert_body_matches(input: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let input = parse_macro_input!(input as BodyMatchCall); [INFO] [stdout] | ----- ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | proc_macro::TokenStream::from(input.expand().to_token_stream()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:51:21 [INFO] [stdout] | [INFO] [stdout] 26 | fn expand(mut self) -> Stmt { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let (bindings, return_expr) = [INFO] [stdout] | -------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | BindingPatternsExtractor::new(&self.pat).expand_bindings_and_return_expr(); [INFO] [stdout] 43 | let guard_condition = StringLiteralPatternModifier::new(&mut self.pat).expand_guard_expr(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let match_expr = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let pat = bindings.into(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let match_expr = Box::new(match_expr.into()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | [INFO] [stdout] 51 | Stmt::Local(Local { [INFO] [stdout] | _____________________^ [INFO] [stdout] 52 | | attrs: Vec::new(), [INFO] [stdout] 53 | | let_token, [INFO] [stdout] 54 | | pat, [INFO] [stdout] 55 | | init: Some((equal, match_expr)), [INFO] [stdout] 56 | | semi_token, [INFO] [stdout] 57 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:144:20 [INFO] [stdout] | [INFO] [stdout] 134 | let elems = self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | attrs: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:160:20 [INFO] [stdout] | [INFO] [stdout] 151 | let elems = self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | attrs: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:171:20 [INFO] [stdout] | [INFO] [stdout] 170 | fn mk_ident_pat(ident: Ident) -> Pat { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | Pat::Ident(PatIdent { [INFO] [stdout] | ____________________^ [INFO] [stdout] 172 | | attrs: Vec::new(), [INFO] [stdout] 173 | | by_ref: None, [INFO] [stdout] 174 | | mutability: None, [INFO] [stdout] 175 | | ident, [INFO] [stdout] 176 | | subpat: None, [INFO] [stdout] 177 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:424:20 [INFO] [stdout] | [INFO] [stdout] 417 | fn nest_match(inner: ExprMatch, (expr, pat): (Expr, Pat)) -> ExprMatch { [INFO] [stdout] | ---------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 418 | let match_token = ::default(); [INFO] [stdout] 419 | let expr = Box::new(expr); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 420 | let brace_token = Brace::default(); [INFO] [stdout] 421 | let arms = vec![Self::mk_arm(pat, None, inner.into()), Self::catchall_arm()]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 424 | attrs: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:435:20 [INFO] [stdout] | [INFO] [stdout] 432 | fn mk_arm(pat: Pat, guard: Option<(Token![if], Box)>, body: Expr) -> Arm { [INFO] [stdout] | -------- -------------------------------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 433 | let body = Box::new(body); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 434 | Arm { [INFO] [stdout] 435 | attrs: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `restest_macros` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "24426e67f2f46682630828fa6953dbc216600d0bdc4bc2dcc16e227c8722dcbc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "24426e67f2f46682630828fa6953dbc216600d0bdc4bc2dcc16e227c8722dcbc", kill_on_drop: false }` [INFO] [stdout] 24426e67f2f46682630828fa6953dbc216600d0bdc4bc2dcc16e227c8722dcbc