[INFO] fetching crate restate-sdk-shared-core 0.0.5... [INFO] checking restate-sdk-shared-core-0.0.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate restate-sdk-shared-core 0.0.5 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate restate-sdk-shared-core 0.0.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate restate-sdk-shared-core 0.0.5 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate restate-sdk-shared-core 0.0.5 [INFO] tweaked toml for crates.io crate restate-sdk-shared-core 0.0.5 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 143 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding fixedbitset v0.4.2 (latest: v0.5.7) [INFO] [stderr] Adding googletest v0.11.0 (latest: v0.12.0) [INFO] [stderr] Adding googletest_macro v0.11.0 (latest: v0.12.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding matchers v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a62bbbbee8f091da0fd8908233d40208c3d9b02f2ce60fb10912b6a1425858e2 [INFO] running `Command { std: "docker" "start" "-a" "a62bbbbee8f091da0fd8908233d40208c3d9b02f2ce60fb10912b6a1425858e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a62bbbbee8f091da0fd8908233d40208c3d9b02f2ce60fb10912b6a1425858e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a62bbbbee8f091da0fd8908233d40208c3d9b02f2ce60fb10912b6a1425858e2", kill_on_drop: false }` [INFO] [stdout] a62bbbbee8f091da0fd8908233d40208c3d9b02f2ce60fb10912b6a1425858e2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f73c9968a7d9208ea3aeb064ea5662592b3f7c9f3671fd1dbc060f16968d2388 [INFO] running `Command { std: "docker" "start" "-a" "f73c9968a7d9208ea3aeb064ea5662592b3f7c9f3671fd1dbc060f16968d2388", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking const-oid v0.10.0-rc.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Compiling prettyplease v0.2.22 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking bytes-utils v0.1.4 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling assert2-macros v0.3.15 [INFO] [stderr] Compiling googletest_macro v0.11.0 [INFO] [stderr] Compiling test-log-macros v0.2.16 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking heck v0.5.0 [INFO] [stderr] Checking multimap v0.10.0 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Checking googletest v0.11.0 [INFO] [stderr] Checking test-log v0.2.16 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking assert2 v0.3.15 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Compiling prost-derive v0.13.2 [INFO] [stderr] Checking hybrid-array v0.2.0-rc.9 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking crypto-common v0.2.0-rc.1 [INFO] [stderr] Checking simple_asn1 v0.6.2 [INFO] [stderr] Checking prost v0.13.2 [INFO] [stderr] Checking prost-types v0.13.2 [INFO] [stderr] Checking block-buffer v0.11.0-rc.1 [INFO] [stderr] Checking digest v0.11.0-pre.9 [INFO] [stderr] Checking sha2 v0.11.0-pre.4 [INFO] [stderr] Checking jsonwebtoken v9.3.0 [INFO] [stderr] Checking prost-build v0.13.2 [INFO] [stderr] Compiling ambassador v0.4.1 [INFO] [stderr] Checking restate-sdk-shared-core v0.0.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request_identity.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn with_key(mut self, key: &str) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | self.keys.push(Self::parse_key(key)?); [INFO] [stdout] 86 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 87 | | validation: self.validation, [INFO] [stdout] 88 | | keys: self.keys, [INFO] [stdout] 89 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request_identity.rs:130:78 [INFO] [stdout] | [INFO] [stdout] 130 | .map_err(|e| VerifyError::ExtractHeader(SIGNATURE_SCHEME_HEADER, Box::new(e)))? [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request_identity.rs:137:86 [INFO] [stdout] | [INFO] [stdout] 137 | .map_err(|e| VerifyError::ExtractHeader(SIGNATURE_JWT_V1_HEADER, Box::new(e)))? [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service_protocol/encoding.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn decode_to(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | M::decode(self.1).map_err(|e| DecodingError::DecodeMessage(self.0.message_type(), e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/context.rs:229:21 [INFO] [stdout] | [INFO] [stdout] 226 | pub(crate) fn new(is_partial: bool, values: Vec<(String, Bytes)>) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | values: values [INFO] [stdout] | _____________________^ [INFO] [stdout] 230 | | .into_iter() [INFO] [stdout] 231 | | .map(|(key, val)| (key, Some(val))) [INFO] [stdout] 232 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/context.rs:231:41 [INFO] [stdout] | [INFO] [stdout] 231 | .map(|(key, val)| (key, Some(val))) [INFO] [stdout] | ---------- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/errors.rs:146:20 [INFO] [stdout] | [INFO] [stdout] 143 | pub fn new(state: &'static str, event: impl fmt::Debug + 'static) -> Self { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | event: Box::new(event), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/transitions/mod.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 43 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | context: &mut CTX, [INFO] [stdout] 45 | event: E, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | ) -> Result<(Self, Self::Output), VMError> { [INFO] [stdout] 47 | Transition::transition(self, context, event).map(|s| (s, ())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/transitions/mod.rs:56:15 [INFO] [stdout] | [INFO] [stdout] 52 | pub(super) fn do_transition(&mut self, event: E) -> Result [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | match mem::replace(&mut self.last_transition, Ok(State::WaitingStart)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/transitions/input.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 41 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | context: &mut Context, [INFO] [stdout] 43 | NewStartMessage(msg): NewStartMessage, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | Ok(State::WaitingReplayEntries { [INFO] [stdout] | ____________^ [INFO] [stdout] 71 | | entries: Default::default(), [INFO] [stdout] 72 | | async_results: Default::default(), [INFO] [stdout] 73 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/transitions/input.rs:56:66 [INFO] [stdout] | [INFO] [stdout] 55 | .map(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Ok::<(String, Bytes), BadEagerStateKeyError>(( [INFO] [stdout] | __________________________________________________________________^ [INFO] [stdout] 57 | | String::from_utf8(e.key.to_vec()).map_err(BadEagerStateKeyError)?, [INFO] [stdout] 58 | | e.value, [INFO] [stdout] 59 | | )) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/transitions/journal.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 103 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let (s, msg) = TransitionAndReturn::transition_and_return( [INFO] [stdout] | - --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 117 | | s, [INFO] [stdout] 118 | | Input { [INFO] [stdout] 119 | | invocation_id: start_info.debug_id.clone(), [INFO] [stdout] ... | [INFO] [stdout] 131 | | }, [INFO] [stdout] 132 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/transitions/journal.rs:207:12 [INFO] [stdout] | [INFO] [stdout] 174 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | context: &mut Context, [INFO] [stdout] 176 | SysCompletableEntry(sys_name, expected): SysCompletableEntry, [INFO] [stdout] | --------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | let (mut s, actual) = TransitionAndReturn::transition_and_return( [INFO] [stdout] | - ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | Ok((s, ar_handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/transitions/terminal.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 21 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | Ok(State::Suspended) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `restate-sdk-shared-core` (lib) due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request_identity.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn with_key(mut self, key: &str) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | self.keys.push(Self::parse_key(key)?); [INFO] [stdout] 86 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 87 | | validation: self.validation, [INFO] [stdout] 88 | | keys: self.keys, [INFO] [stdout] 89 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request_identity.rs:130:78 [INFO] [stdout] | [INFO] [stdout] 130 | .map_err(|e| VerifyError::ExtractHeader(SIGNATURE_SCHEME_HEADER, Box::new(e)))? [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request_identity.rs:137:86 [INFO] [stdout] | [INFO] [stdout] 137 | .map_err(|e| VerifyError::ExtractHeader(SIGNATURE_JWT_V1_HEADER, Box::new(e)))? [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service_protocol/encoding.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn decode_to(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | M::decode(self.1).map_err(|e| DecodingError::DecodeMessage(self.0.message_type(), e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/context.rs:229:21 [INFO] [stdout] | [INFO] [stdout] 226 | pub(crate) fn new(is_partial: bool, values: Vec<(String, Bytes)>) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | values: values [INFO] [stdout] | _____________________^ [INFO] [stdout] 230 | | .into_iter() [INFO] [stdout] 231 | | .map(|(key, val)| (key, Some(val))) [INFO] [stdout] 232 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/context.rs:231:41 [INFO] [stdout] | [INFO] [stdout] 231 | .map(|(key, val)| (key, Some(val))) [INFO] [stdout] | ---------- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/errors.rs:146:20 [INFO] [stdout] | [INFO] [stdout] 143 | pub fn new(state: &'static str, event: impl fmt::Debug + 'static) -> Self { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | event: Box::new(event), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/transitions/mod.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 43 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | context: &mut CTX, [INFO] [stdout] 45 | event: E, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | ) -> Result<(Self, Self::Output), VMError> { [INFO] [stdout] 47 | Transition::transition(self, context, event).map(|s| (s, ())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/transitions/mod.rs:56:15 [INFO] [stdout] | [INFO] [stdout] 52 | pub(super) fn do_transition(&mut self, event: E) -> Result [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | match mem::replace(&mut self.last_transition, Ok(State::WaitingStart)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/transitions/input.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 41 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | context: &mut Context, [INFO] [stdout] 43 | NewStartMessage(msg): NewStartMessage, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | Ok(State::WaitingReplayEntries { [INFO] [stdout] | ____________^ [INFO] [stdout] 71 | | entries: Default::default(), [INFO] [stdout] 72 | | async_results: Default::default(), [INFO] [stdout] 73 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/transitions/input.rs:56:66 [INFO] [stdout] | [INFO] [stdout] 55 | .map(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Ok::<(String, Bytes), BadEagerStateKeyError>(( [INFO] [stdout] | __________________________________________________________________^ [INFO] [stdout] 57 | | String::from_utf8(e.key.to_vec()).map_err(BadEagerStateKeyError)?, [INFO] [stdout] 58 | | e.value, [INFO] [stdout] 59 | | )) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/transitions/journal.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 103 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let (s, msg) = TransitionAndReturn::transition_and_return( [INFO] [stdout] | - --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 117 | | s, [INFO] [stdout] 118 | | Input { [INFO] [stdout] 119 | | invocation_id: start_info.debug_id.clone(), [INFO] [stdout] ... | [INFO] [stdout] 131 | | }, [INFO] [stdout] 132 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/transitions/journal.rs:207:12 [INFO] [stdout] | [INFO] [stdout] 174 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | context: &mut Context, [INFO] [stdout] 176 | SysCompletableEntry(sys_name, expected): SysCompletableEntry, [INFO] [stdout] | --------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | let (mut s, actual) = TransitionAndReturn::transition_and_return( [INFO] [stdout] | - ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | Ok((s, ar_handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/transitions/terminal.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 21 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | Ok(State::Suspended) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/mod.rs:97:24 [INFO] [stdout] | [INFO] [stdout] 97 | .map(|msg| msg.decode_to::().unwrap()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/mod.rs:163:16 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn input_entry_message(b: impl AsRef<[u8]>) -> InputEntryMessage { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | value: Bytes::copy_from_slice(b.as_ref()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/mod.rs:164:11 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn input_entry_message(b: impl AsRef<[u8]>) -> InputEntryMessage { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | ..InputEntryMessage::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `restate-sdk-shared-core` (lib test) due to 18 previous errors [INFO] running `Command { std: "docker" "inspect" "f73c9968a7d9208ea3aeb064ea5662592b3f7c9f3671fd1dbc060f16968d2388", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f73c9968a7d9208ea3aeb064ea5662592b3f7c9f3671fd1dbc060f16968d2388", kill_on_drop: false }` [INFO] [stdout] f73c9968a7d9208ea3aeb064ea5662592b3f7c9f3671fd1dbc060f16968d2388